Repository navigation
refactor(plugin): port security policy resolution to TypeScript - #799
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsBlocking findings (1)
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1eb78b2 to
7a77479
Compare
7a77479 to
2228b64
Compare
2228b64 to
0216913
Compare
0216913 to
ad511ed
Compare
There was a problem hiding this comment.
💡 Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: ad511edcbb
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
mldangelo-oai
left a comment
There was a problem hiding this comment.
Re-reviewed the exact current head and reconciled all prior threads. The compatibility behavior is well covered; the remaining comments are nonblocking simplification and documentation cleanup.
ad511ed to
9986e31
Compare
9986e31 to
90e02bd
Compare
mldangelo-oai
left a comment
There was a problem hiding this comment.
Re-reviewed exact head 90e02bd. Windows containment now compares native directory identities while walking canonical parents, covering the Unicode casing collision without recreating path matching in JavaScript. The operator guidance is reduced to the actionable contract; all prior threads are resolved and all required checks pass.
90e02bd to
fd360d0
Compare
fd360d0 to
f6586b3
Compare
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
f6586b3 to
5326f6c
Compare
5326f6c to
8dc7cec
Compare
8dc7cec to
01def5d
Compare
01def5d to
5b98708
Compare
5b98708 to
42b102c
Compare
Summary
Replace the Python SECURITY.md resolver and its tests with a typed helper bundled alongside the MCP runtime. Policy discovery and root-to-leaf guidance use the existing Node launcher.
Changes
launch_codex_security_mcp[.cmd] --helper resolve-security-md --repo PATH [--list | --scope PATH] [--out PATH], defaulting to stdout. Limit the SDK's Python interpreter instruction to.pyhelper scripts.Testing
Risk and rollout
Stacked on #798. The helper entrypoint changes from the Python script to the shared launcher, with callers updated together. Previously accepted arguments and home expansion remain supported intentionally. GNU Linux
file/..compatibility requires retaining the existing resolver; native realpath is not a drop-in replacement. Other Python helpers remain for subsequent migration slices. There are no new top-level CLI flags.Public disclosure review