Repository navigation
Fronius: add support for single phase meters - #4093
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Production-meter handling can still raise ZeroDivisionError, and single-phase regression coverage is missing.
1 open finding
What changed in this PR
Adds support for Fronius single-phase meters by handling missing phase measurements.
Changes:
- Defaults missing phase and frequency values.
- Guards counter current calculations against invalid voltages.
- Requires production-meter handling and regression coverage updates.
| File | Summary |
|---|---|
packages/modules/devices/fronius/fronius_http_api/meter_reader.py |
Handles missing phase measurements; production-meter division and regression coverage remain unresolved. |
packages/modules/devices/fronius/fronius_http_api/counter.py |
Safely calculates currents for missing or zero voltages. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| power_factors = [data["PowerFactor_Phase_"+str(num)] for num in range(1, 4)] | ||
| frequency = data["Frequency_Phase_Average"] | ||
| powers = [data.get(f"PowerReal_P_Phase_{num}", 0) for num in range(1, 4)] | ||
| voltages = [data.get(f"Voltage_AC_Phase_{num}", 0) for num in range(1, 4)] |
LKuemmel
approved these changes
Oct 20, 2026
LKuemmel
pushed a commit
that referenced
this pull request
Oct 22, 2026
* add support for single phase meters * fix zero division for production counter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #66008972
Einphasige Smartmeter werfen KeyError