[ndrsnhs]

Victron erwartet in allen Modi die Übergabe des Grid Setpoints.
In dieser Implementierung wird dafür Mode 1 genutzt.
Mode 2 deaktiviert die Phasensaldierung und ist daher nicht nutzbar.
Mode 3 setzt die Register entgegen der Dokumentation nach 10-14 Sekunden zurück

Die für die Berechnung nötigen zusätzlichen Daten werden als dataclass übergeben. Die Entscheidung welche Werte und wie diese genutzt werden/ die Berechnung verbleibt damit in der Komponente.

Für die Entladesperre wird weiterhin Mode 2 genutzt. Bei kompletter Sperre des Speichers spielt die fehlende Saldierung keine Rolle. Die Register haben eine längere Lebensdauer als in Mode 3

[Copilot]

🟡 Changes recommended

The dispatch can pass SetPoint objects to unupdated battery implementations, and Victron’s unconditional register read can interrupt control writes.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Extends battery control with EVU power data and Victron ESS Mode 1 grid-setpoint handling.

Changes:

• Adds and propagates the SetPoint dataclass.
• Migrates battery adapters and MQTT/configuration handling.
• Updates Victron charge/discharge control.

File summaries

File	Summary
packages/modules/devices/victron/victron/bat.py	Implements Victron Mode 1 grid-setpoint control.
packages/modules/devices/varta/varta/bat_modbus.py	Migrates battery control input.
packages/modules/devices/sungrow/sungrow_sh/bat.py	Migrates battery control input.
packages/modules/devices/sungrow/sungrow_ihm/bat.py	Migrates battery control input.
packages/modules/devices/sonnen/sonnenbatterie/bat.py	Migrates battery control input.
packages/modules/devices/solis/solis/bat.py	Migrates battery control input.
packages/modules/devices/solax/solax/bat.py	Migrates battery control input.
packages/modules/devices/solaredge/solaredge/bat.py	Migrates battery control input.
packages/modules/devices/sma/sma_sunny_island/bat.py	Migrates battery control input.
packages/modules/devices/sma/sma_sunny_boy/bat.py	Migrates battery control input.
packages/modules/devices/sigenergy/sigenergy/bat.py	Migrates battery control input.
packages/modules/devices/qcells/qcells/bat.py	Migrates battery control input.
packages/modules/devices/marstek/venus_c_e/bat.py	Migrates battery control input.
packages/modules/devices/kostal/kostal_plenticore/bat.py	Migrates battery control input.
packages/modules/devices/good_we/good_we/bat.py	Migrates battery control input.
packages/modules/devices/generic/mqtt/bat.py	Migrates MQTT battery control input.
packages/modules/devices/batterx/batterx/bat.py	Migrates battery control input.
packages/modules/devices/anker/solarbank/bat.py	Migrates battery control input.
packages/modules/devices/alpha_ess/alpha_ess/bat.py	Migrates battery control input.
packages/modules/common/configurable_device.py	Passes setpoint data through the fault wrapper.
packages/helpermodules/update_config.py	Registers the EVU power topic.
packages/helpermodules/setdata.py	Validates EVU power input.
packages/helpermodules/mosquitto_dynsec/missing_role_topics_test.py	Updates internal topic permissions tests.
packages/control/process.py	Passes complete battery setpoints to devices.
packages/control/bat.py	Adds the EVU power setpoint field.
packages/control/bat_all.py	Populates EVU power for battery control.

Review details

Suppressed comments (1)

packages/modules/devices/victron/victron/bat.py:64

• This read is performed even for None and 0 setpoints, although bat_power is only used in the charge/discharge branches. Besides adding a Modbus request every control cycle, a read failure can prevent the following self-regulation/stop writes and leave the previous Victron mode active. Read register 842 only when calculating an active grid setpoint (or use the cached value for that calculation).

        bat_power = self.__tcp_client.read_holding_registers(842, ModbusDataType.INT_16, unit=modbus_id)

• Files reviewed: 26/26 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

The new SetPoint contract is not reflected in the AbstractBat interface and remaining sample implementations.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 1

Open (2)

• This now passes a Set object to every controllable battery, but several implementations not…
• Update set_power_limit interface to accept SetPoint dataclass · New

[Copilot]

Copilot review overview

🟡 Changes recommended

The AbstractBat contract migration leaves the repository’s documented sample implementations on the old scalar API.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 2

Open (3)

• This now passes a Set object to every controllable battery, but several implementations not…
• Update sample batteries for the new SetPoint contract · New
• Update set_power_limit interface to accept SetPoint dataclass

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved critical issues affect sample execution and production Victron/control-thread behavior.

Review effort: Lite
Findings: 5 · 1

Open (6)

• Use setpoint.power_limit instead of removed power_limit · New
• Use setpoint.power_limit instead of removed power_limit · New
• Pass an immutable setpoint snapshot to the worker · New
• Handle missing evu_power before issuing Victron commands · New
• This now passes a Set object to every controllable battery, but several implementations not…
• Update set_power_limit interface to accept SetPoint dataclass

Resolved since last review (1)

• Update sample batteries for the new SetPoint contract

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved critical Victron stop-handling and moderate control/test issues remain.

Review effort: Lite
Findings: 2

Open (2)

• Handle zero power limit independently of missing EVU power · New
• Pass an immutable setpoint snapshot to the worker

Resolved since last review (5)

• Handle missing evu_power before issuing Victron commands
• Use setpoint.power_limit instead of removed power_limit
• Use setpoint.power_limit instead of removed power_limit
• This now passes a Set object to every controllable battery, but several implementations not…
• Update set_power_limit interface to accept SetPoint dataclass

[Copilot]

Copilot review overview

🟡 Changes recommended

A critical circular import and additional contract and Victron control issues remain unresolved.

Review effort: Lite
Findings: 1

Open (1)

• Avoid circular runtime import of SetPoint · New

Resolved since last review (2)

• Handle zero power limit independently of missing EVU power
• Pass an immutable setpoint snapshot to the worker

[Copilot]

Copilot review overview

🟡 Changes recommended

A critical Sungrow register collision and a moderate Victron read-path issue remain unresolved; EVU handoff coverage is also requested.

Review effort: Lite
Findings: 1

Open (1)

• Write charge-mode marker to register 8024 · New

Resolved since last review (1)

• Avoid circular runtime import of SetPoint

[Copilot]

Copilot review overview

🔵 Needs a closer look

Resolve the three moderate findings and add the requested EVU-power regression assertion.

Review effort: Lite
Findings: None

Resolved since last review (1)

• Write charge-mode marker to register 8024

Previously missed (1)

In code that hasn't changed since last review

Read bat_power only during active control

packages/​modules/​devices/​victron/​victron/​bat.py:64

This read is performed before the no-control and stop branches, even though those paths do not use bat_power. A transient failure reading register 842 will therefore prevent the reset/stop writes from being sent (and adds an unnecessary Modbus round trip on every such call). Move the read into the nonzero active-control path so self-regulation and the discharge lock remain operable when the power-status register cannot be read.

[LKuemmel]

Passt soweit, SunEnergyXT fehlt noch von den neuen Modulen.