Repository navigation
Description
Phase 6 libobs core follow-up: port only obs_sceneitem_get_group in libobs/obs-scene-item-get-group.c.h to obs-scene after prerequisite #5276 lands. Keep the shared static get_sceneitem_parent_group implementation and reorder users in C, reachable through the real callable obs_sceneitem_parent_group_lookup seam. Respect the current hold on adapter-adding swaps; this issue is future work, not authorization to start a held swap.
The prerequisite adds test/cmocka/test_sceneitem_get_group.c, which becomes an unchanged Tier 2 contract. Mirror every assertion in the existing core-state category binary, add an oracle and differential/mutation coverage, and wire its recorder to the separately linked Rust wrapper. Preserve NULL scene/item and group-item rejection before field access/locking; exactly one balanced C-owned full-lock around lookup; first-match parent-group pointer identity; foreign/absent group results; and the borrowed return with no added reference. Characterized details include ignoring the removed flag and matching NULL parent/context pointers.
Keep layouts, locking, traversal and source context ownership in C through narrow real seams. Every standalone Rust-static consumer must link any needed real C adapter source, never an aborting stub. Prove Darwin fake bindings if introduced (#5226), build EVERY Linux *_rust cmocka target and run both Windows MSVC and Darwin pre-queue links, plus all applicable test tiers and repository validation. Preserve public headers, existing C tests, WebSocket compatibility, sorted unity groups and canonical test registrations. New Rust cases belong to the existing amalgamated category binary.
The prerequisite branch/PR and final validation are recorded on #5276. Claim and implement this follow-up only after the prerequisite is merged and the hold permits its adapters.
Prerequisite READY PR: #5289 (Refs #5276), published head 4e5dc34be5516f9ea45c274def061fecc8551900. It passed 322 native-build cases, Linux Tier 2 with all 66 Rust-static targets and new characterization repeated 25 times per library, unchanged related suites, equal 1,769-symbol export sets, all eight Windows category links, all 57 Rust-static fixtures on each of Windows MSVC and Darwin arm64, explicit new C-fixture links for both, one full lint and one-primary-agent review. Ordinary hosted PR/queue checks remain required after optional repeated client self-tests timed out. Native Windows/macOS runtime is not claimed.
Activity