Repository navigation
graphics: isolate the real image max-size C dependency seam (Refs #5214) - #5222
Merged
Merged
Conversation
…ntract
Ci-Attestation: {"at":1795080811,"gate":"data/all/compatibility","host":"linux-x86_64","key":"","lane":"client-checks","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":120,"stamp":"c14dd43f4db1475558f185e48823ca0f","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080811,"gate":"data/all/flatpak-manifest","host":"linux-x86_64","key":"","lane":"client-checks","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":120,"stamp":"81d49606af1ab6ec1dc4f332fb64df58","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080811,"gate":"data/all/qt-xml","host":"linux-x86_64","key":"","lane":"client-checks","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":120,"stamp":"e4fce61f5026fc9c9f8df4eb41bce7d6","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080811,"gate":"data/all/services-schema","host":"linux-x86_64","key":"","lane":"client-checks","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":120,"stamp":"b6451d7b6afc57ba976391d0294b5ed2","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080689,"gate":"general/all/client-lint","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"79264840e0992f8747b359dddba7a428","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080811,"gate":"python/all/self-test","host":"linux-x86_64","key":"","lane":"client-checks","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":120,"stamp":"0654551e90f4277b89d038196b431aa5","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080690,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"f68f2d5466b104117a061cf96933e059","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080690,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"17a807395138d2b47119a608a1c064f5","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080690,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"c3f0f5476e07858a15f9da02fd53e662","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080690,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"084f47a899ba2d82b798abf66cca3837","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080689,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"efde86bf645f05abd83b2546f95585c5","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080690,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"4fa5eabca51f544158b8c417530ccf86","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080690,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"4dd4d0c220aabae1c8198b3958291d24","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080690,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"0237c0573314bc1ece7c09c638b0d937","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080690,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"7da7a78dcf403ee26e5f94b9fa9bb57e","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080690,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"6eaddb53dcb2f8fcbe2bd9ccc90597b4","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080689,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"71c78d44e87df7ddeb5e597be0d286bc","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795080689,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"cb678710af7fcf2b01dca822508ee7a3fbf40f0b1d8cb245d0dffa6e9485983d","lane":"client-lint","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":18,"stamp":"49178d472e71ec024bf0977e2dff6c2b","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Ci-Attestation: {"at":1795081394,"gate":"rust/x86_64-unknown-linux-gnu/client-test","host":"linux-x86_64","key":"b6fff9d8ccc3fba07eb7d55c4dae6427a83aeb7c74db5218c29ff863594daace","lane":"client-test-x86_64-unknown-linux-gnu","parents":["57b184bd6dec9ddfb251fde915fae45fcc1dc627"],"secs":582,"stamp":"791ad3e8b3cf09560b3da390f56e152a","tree":"4e743d5771f475279ba2608a81755545a2489e94","v":1,"via":"run"}
Client-Checks: {"checks":{"base":"4f62019c31e8e151bc62a76f6b6d490e693b1aba","coverage":"all-tracked-applicable-files","diff":["libobs/build/libobs.core+.h.c","libobs/build/libobs.core-output+.h.c","libobs/build/libobs.graphics-image-max-size+.h.c","libobs/build/libobs.media+.h.c","libobs/build/libobs.media-image-orientation-fields+.h.c","libobs/build/libobs.media-texture-file-data-convert+.h.c","libobs/build/libobs.media-texture-file-data-session+.h.c","libobs/build/modules.d/graphics.json","libobs/build/modules.d/media.json","libobs/build/source-sets.d/LIBOBS_SOURCES.json","libobs/graphics/graphics-ffmpeg.c.h","libobs/graphics/graphics-image-max-size.c.h","libobs/graphics/graphics-texture-file-data-adapter.c.h","libobs/graphics/graphics-texture-file-data-convert.c.h","libobs/graphics/graphics.c.h","libobs/obs-audio-info-queries.c.h","libobs/obs-output-total-bytes-query.c.h","libobs/obs-output.c.h","libobs/obs-video-stats-queries.c.h","libobs/obs.c.h","test/cmocka/build/test-graph.json","test/cmocka/test_audio_info_queries.c","test/cmocka/test_image_max_texture_size.c","test/cmocka/test_output_total_bytes_query.c","test/cmocka/test_video_stats_queries.c","test/cmocka/tests.d/test_audio_info_queries.cmake","test/cmocka/tests.d/test_image_max_texture_size.cmake","test/cmocka/tests.d/test_output_total_bytes_query.cmake","test/cmocka/tests.d/test_video_stats_queries.cmake"],"head":"26f0032912d50aa03e6d55f928fb24246a021f5f","tools":{"orchestrator-python":"3.13.15 (main, Aug 14 2026, 15:34:59) [Clang 22.1.3 ]","schema-dependencies":"3.13.15 (main, Aug 14 2026, 15:34:59) [Clang 22.1.3 ]\n{'jsonschema': '4.26.0', 'json_source_map': '1.0.5'}","uv":"uv 0.13.5 (x86_64-unknown-linux-gnu)","xmllint":"xmllint: using libxml version 21504\n compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 DTDValid HTML C14N Catalog XPath XPointer XInclude Iconv ISO8859X Regexps Automata RelaxNG Schemas Modules Debug"},"tracked-digest":"d56b57bc93dc6b82eb91dd810f1cb3b55204b1ddd6423e4c43e3c3e0021fd173","tree":"4e743d5771f475279ba2608a81755545a2489e94"}}
zackees
enabled auto-merge
November 19, 2026 09:44
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone image-file consumers need the real maximum-texture-size callback without importing the full private graphics runtime. This C-only prerequisite puts the atomic state, getter and updater in a separately linkable unity member, preserving the existing
gs_createpublication andgs_destroyreset points. The original C image-file orchestration remains selected. The opaque FFmpeg session, unchanged conversion implementation and orientation fields have separate archive members.RED commit
5a64d8a17requires the missing standalone production unit and fails CMake configuration. The GREEN extraction makes the new C contract pass for initial zero, ordinary limits,UINT32_MAXand reset. The unchanged viewport characterization verifies create/destroy behavior through the public image loader in both C-reference and hybrid modes. The extracted object has no undefined symbols; its test executable needs only cmocka and libc.Local validation built all 64 Linux
*_rusttargets and passed all 71 selected characterizations in each OFF/ON mode, with identical 1,769-symbol public exports. All 317native_build::tests, build-group/module inventory checks andsoldr cargo fmt --all --checkpass.ci/windows_link_check.pyalso passes: all eight Rust category binaries and all 55 configured cmocka Rust fixtures link on Windows MSVC, and all 55 link on Darwin arm64. The explicitci/cmocka_link_check.py --alias mac-arm64pass succeeds as well. The new standalone C contract cross-links on both Windows and Darwin. The single finalSOLDR_PORCELAIN=0 ./lintrun passes (160.2 s, including valid soldr Rust-lint verdict replays)../pushcompleted the selected client proofs, full host Rust tests, repository self-tests/validators and GNU Windows category links, then signed and verified the published head.This step removes the hidden-runtime dependency of
gs_image_max_texture_size. It does not claim to repair the held Rust swap's twelve Windows import/static collisions, nine Linux dependency-closure failures or one Darwin logger failure: those remain shared-support work in step B. The C-only prerequisite passes the corresponding configured targets while retaining master's C behavior. The #5155 branch and its hold remain untouched.Refs #5214
Refs #5145