Skip to content

test: Isolate graphics image max-texture-size seam before the #5145 Rust swap #5214

Closed

Description

@zackees

Prerequisite step A from the #5155 investigation, before the #5145 Rust image-file data swap. Refs #5145.

The real gs_image_max_texture_size callback currently shares graphics.c.h's private atomic state and full runtime dependencies. Standalone Rust-static image consumers cannot link that hidden callback without dragging in unrelated graphics symbols; an aborting test callback is not a valid replacement.

Keep the original C image-file orchestration selected. Extract the real getter and atomic update seam into a separately linkable private C unit, preserving the exact gs_create publication and gs_destroy reset points. Keep the opaque FFmpeg session, conversion and orientation implementations in separate lazy archive members. No Rust behavior, public headers, existing C tests or WebSocket changes.

Acceptance: commit a RED standalone contract and GREEN extraction, characterize publication/reset including the original lifecycle call sites, update unity/source/module inventories, run the complete native_build module, build every Linux *_rust cmocka target and graphics characterizations, Windows and Darwin link checks, formatting and lint. Compare results with the twelve Windows, nine Linux and one Darwin failures recorded in #5155; broader shared support and harness fixes remain step B.

Activity

  1. added
    portPort a C unit to Rust (four-tier policy)
    readyMeets the definition of Ready; claimable
    P2Normal priority
    on Nov 19, 2026
  2. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Claiming: step A C dependency preparation in pool slot fix5159, branch test/5214-image-max-size-seam. 1. Commit the standalone seam/lifecycle contract RED. 2. Extract the atomic getter/update unit and separate real session/conversion/orientation archive members with C orchestration retained. 3. Run the full native_build module, every Linux *_rust link and focused characterizations, Windows/Darwin links, fmt and lint; publish per backpressure. First PR expected this session after verified GREEN.

  3. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Landed on master in #5222 (d8f5045): the real graphics image max-size seam is isolated into a standalone C object with no undefined symbols. This is step A of the #5155 split (Refs #5145).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Normal priorityportPort a C unit to Rust (four-tier policy)readyMeets the definition of Ready; claimablesize:SHours

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions