Repository navigation
graphics: characterize and extract NV12/P010 capability queries (Refs #5209) - #5217
Merged
Merged
Conversation
…ion (RED) Refs #5209. The GPU-free characterization passed unchanged original C in C-reference and hybrid modes, 25 repeats each. The extraction guard requires the missing graphics-planar-capability-queries.c.h seam.
Keep the C-owned TLS and original validator in the same graphics unity group. The committed RED fixture fails solely on the missing extraction seam; the original behavior passed 25 repeats in each library configuration.
Refs #5209. The explicit Darwin ARM64 fixture compile exposed its private graphics header dependency on SIMDe. Declare the existing header-only provider without changing the test or any public header. Ci-Attestation: {"at":1795077459,"gate":"data/all/compatibility","host":"linux-x86_64","key":"","lane":"client-checks","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":360,"stamp":"c579dd1f0456c4fd35f848bbb70195c9","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077459,"gate":"data/all/flatpak-manifest","host":"linux-x86_64","key":"","lane":"client-checks","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":360,"stamp":"073abb82b547c11299a4f3d207ac6c00","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077459,"gate":"data/all/qt-xml","host":"linux-x86_64","key":"","lane":"client-checks","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":360,"stamp":"1ce95b9c4cf154671ca9e1780bfdf319","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077459,"gate":"data/all/services-schema","host":"linux-x86_64","key":"","lane":"client-checks","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":360,"stamp":"d486849acdaa6ad40af9746dd7e13cdc","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"general/all/client-lint","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"03d81218ab08522b86dad3d5b1ecd68e","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077459,"gate":"python/all/self-test","host":"linux-x86_64","key":"","lane":"client-checks","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":360,"stamp":"5cdf9840a05a1c886c86f3a27d639ad4","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"4f694884f23f2028e1342af42afe745e","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077098,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"b30e2af4369f9afe89f886bda84a9e05","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"1ffc0883f34560716f45bf60cff372e7","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"b4e6eb11f677a143709afa3619e6aa35","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"6667ab2543036798777ec34cd2ac6e06","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"e32710335e3e4101ac79f34e117e16c0","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"afcfa0ad22ec0b0bd2cf4c4d6b006fd3","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"0ca20ae6921b1d9301feae4066377760","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"bbced9a775bf8f8a4b65a3c3373c0068","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"939be7d553da11cba66093cb57520961","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"53630737172fcc3065d1e45ea4df90e8","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795077097,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"1299b8143a31c5aee97c5de15ca25981b15b2566abda1ee7815997fb2e6c1bb5","lane":"client-lint","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":218,"stamp":"4b8ed009adfc7dda0ab288c5646fb338","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Ci-Attestation: {"at":1795078432,"gate":"rust/x86_64-unknown-linux-gnu/client-test","host":"linux-x86_64","key":"8b05f7d1094beaa843eba0231cf3618fa8069b4faa0ccd449ed29cf678826e98","lane":"client-test-x86_64-unknown-linux-gnu","parents":["465f5a00821bbd8423a60f5b608ff9c33c06878d"],"secs":970,"stamp":"715335de38864790d0bdd013c4e54b50","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da","v":1,"via":"run"} Client-Checks: {"checks":{"base":"9d7600e74b6e68efb03259f1b1809835638b9139","coverage":"all-tracked-applicable-files","diff":["libobs/build/libobs.core+.h.c","libobs/build/libobs.graphics+.h.c","libobs/build/libobs.ported-hotkey-inject-entry+.h.c","libobs/build/ported-source-sets/hotkey-inject-entry.json","libobs/cmake/rust-exports.d/obs-hotkey-inject_entry.txt","libobs/cmake/rust-hidden.d/obs-hotkey-inject_entry.txt","libobs/graphics/graphics-planar-capability-queries.c.h","libobs/graphics/graphics.c.h","libobs/obs-hotkey-inject-entry-fields.c.h","rust/README.md","rust/obs-build/tests/native/registration/headless_characterizations_expected.json","rust/obs-build/tests/native/registration/portal_output_expected.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_background_enum.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_background_press.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_background_trigger.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_binding_press_steps.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_getters_characterization.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_inject_entry.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_load.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_pair_steps.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_press_steps.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_unregister_entry.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_portal_shortcuts.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_wayland_hotkeys.json","rust/obs-c-oracle/oracle/hotkey_inject_entry.c","rust/obs-c-oracle/oracle/hotkey_inject_entry_fields.c","rust/obs-hotkey/src/ffi/inject_entry.rs","rust/obs-hotkey/src/ffi/mod.rs","rust/obs-hotkey/src/inject_entry.rs","rust/obs-hotkey/src/lib.rs","rust/obs-hotkey/tests/hotkey/inject_entry.rs","rust/obs-hotkey/tests/hotkey/inject_entry_parity.rs","rust/obs-hotkey/tests/hotkey/main.rs","test/cmocka/build/test-graph.json","test/cmocka/hotkey-inject-entry-link-support.c","test/cmocka/test_graphics_planar_capability_queries.c","test/cmocka/tests.d/hotkey_inject_entry_link_support.cmake","test/cmocka/tests.d/test_graphics_planar_capability_queries.cmake"],"head":"8a738aeab92224503c9b29f45154f870ac573fc6","tools":{"orchestrator-python":"3.13.15 (main, Aug 14 2026, 15:34:59) [Clang 22.1.3 ]","schema-dependencies":"3.13.15 (main, Aug 14 2026, 15:34:59) [Clang 22.1.3 ]\n{'jsonschema': '4.26.0', 'json_source_map': '1.0.5'}","uv":"uv 0.13.5 (x86_64-unknown-linux-gnu)","xmllint":"xmllint: using libxml version 21504\n compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 DTDValid HTML C14N Catalog XPath XPointer XInclude Iconv ISO8859X Regexps Automata RelaxNG Schemas Modules Debug"},"tracked-digest":"31338f6210947d50019aa750bb19259add945c29dc672e9b73e729d9790f8664","tree":"28c4df823c111ab3aaade5092142c8c2bdc695da"}}
zackees
enabled auto-merge
November 19, 2026 08:55
This was referenced Nov 19, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional NV12/P010 capability queries now have a GPU-free C characterization and an isolated C source for their later Rust swap. Both public bodies move verbatim from
graphics.c.htographics-planar-capability-queries.c.h, retaining the existing C-owned TLS and validator through unity-local declarations. The graphics unity group and canonical test graph are sorted, with matching source-set/module ownership, a tests.d pointer, and the existing header-only SIMDe provider for ARM64 private graphics headers.The three-case fixture covers missing context with exact diagnostics, missing optional callbacks (individually and together), every false/true result combination, two exact fake-device pointers, and independent query dispatch. It never asserts any real host's graphics capability. Public headers, existing C tests (including
test_encoder_tex_active_null.c), Rust sources, and the WebSocket plugin are unchanged.RED
ed905c1a5requires the absent extraction seam and fails C compilation with its explicit missing-seam diagnostic. The same characterization first passed against unchanged original C in both library modes, 25 repeats each. GREEN extracts the bodies unchanged; the fixture passes 25 repeats in each mode again, all 64 Linux standalone*_rusttargets build, and C-reference/hybrid exports match exactly at 1,769 symbols. The completenative_build::module passes 317 tests after extraction, with zero failed or ignored. Build-group and Windows diagnostic checks pass 14 tests, and one read-only clud-review reviewer found no issues.The pre-queue Windows link checker passes the Rust categories plus hybrid libobs and all 55 configured standalone Rust fixtures on each of Windows MSVC x64 and Darwin ARM64. The new C fixture also compiles and links explicitly on both. Its explicit Darwin compile first exposed the private graphics headers' SIMDe include dependency; the final registration declares the existing header-only provider and both links pass. The old Windows link tree used the superseded cmake/cross source directory; preserving that tree and configuring the current root project resolved the environment mismatch.
Full
SOLDR_PORCELAIN=0 ./lintran once and passed in 499.4 seconds. Final forced-fetch/merge-tree checks are clean against queued #5210/#5196 and held graphics #5155. Only already-DIRTY #4655/#4124 conflict; all temporary refs were deleted. The prerequisite issue remains open, Ready and accepted for this worker.The publication client lint passed clippy and Dylint on all six supported targets (218.8 seconds). Its main Linux host suite passed 9,140 tests with six skipped, and the additional obs-util feature configuration passed 920 with none skipped.
This is a behavior-neutral C prerequisite. Rust Tier 1 mirrors and Tier 3 differential/mutation tests belong to the separate swap; Tier 4 does not apply to these non-protocol queries. Native Windows/macOS execution and real GPU support have not been tested locally.
Refs #5209