Skip to content

test: Extract and characterize graphics index-buffer data/type queries before Rust swap #5235

Closed

Description

@zackees

C-only prerequisite for the Phase 6 graphics index-buffer data/type queries, later targeting obs-graphics.

The exact remaining public bodies are gs_indexbuffer_get_data and gs_indexbuffer_get_type in libobs/graphics/graphics.c.h:1300-1314. gs_indexbuffer_get_num_indices is already ported as indexbuffer maintenance and stays unchanged. Extract only the pair verbatim into libobs/graphics/graphics-indexbuffer-queries.c.h in the sorted existing libobs/build/libobs.graphics+.h.c group, following merged #5217 and retaining the private TLS/validation dependencies through same-group declarations. No Rust, public-header changes or existing-C-test edits.

Add a GPU-free C characterization using the established real-header graphics_subsystem / enter-context fixture with recording fake backend exports. Pin context validation before NULL-buffer diagnostics, exact log labels and messages, NULL data and the existing (enum gs_index_type)0 fallback, mandatory callback dispatch exactly once with the original buffer, successful backend-returned NULL data without diagnostics, both declared index enum results, and independent query routing. Do not invent a host default or invoke a missing mandatory callback. Add its tests.d pointer and sorted canonical test graph; source/group/module inventories must agree.

Acceptance: original and extracted C-reference/hybrid characterization, committed extraction-contract RED then GREEN, complete native_build:: module, focused Linux Tier 2 fixture plus EVERY *_rust target and symbol parity, ci/windows_link_check.py (separate Darwin pass if Windows fails), explicit new fixture cross-linking, and one full ./lint. Refresh shared G/graphics.c.h/test-graph PR conflicts with forced fetches and merge-tree before publication. This extraction changes no user-visible behavior and has no protocol surface.

The follow-up Rust swap is a separate issue after this prerequisite lands: frozen C assertions mirrored in the Graphics category, original-C oracle/differential/mutation coverage, unchanged dual-library Tier 2, and real private adapter support for every standalone Rust-static consumer.

Activity

  1. added
    portPort a C unit to Rust (four-tier policy)
    readyMeets the definition of Ready; claimable
    P2Normal priority
    on Nov 19, 2026
  2. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Claiming: graphics index-buffer data/type-query characterization and behavior-neutral C extraction (pool slot obs-studio2, branch test/5235-graphics-indexbuffer-queries).

    1. Characterize original C through a GPU-free recording backend; commit RED for the missing extraction seam.
    2. Move only gs_indexbuffer_get_data and gs_indexbuffer_get_type verbatim into the sorted graphics unity group, with tests.d and sorted graph registration and matching inventories. The already ported count/maintenance APIs remain unchanged.
    3. Run the whole native_build:: module, focused Linux Tier 2 plus EVERY *_rust target, Windows/Darwin links and one full lint; check overlapping PRs with forced fetches and merge-tree before publication.

    Expected first PR this session after GREEN validation, subject to backpressure. No Rust in this prerequisite; the swap gets a separate follow-up issue.

  3. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Landed on master in #5240 (9f055c7): the index-buffer data/type queries are extracted and characterized. The Rust swap is #5241.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Normal priorityportPort a C unit to Rust (four-tier policy)readyMeets the definition of Ready; claimablesize:SHours

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions