Skip to content

obs-core: swap video level queries to safe Rust (Refs #5187) - #5196

Merged
rdoupe merged 3 commits into
masterfrom
port/5187-video-level-queries
Nov 19, 2026
Merged

rdoupe merged 3 commits into
masterfrom
port/5187-video-level-queries

Conversation

@rdoupe

@rdoupe rdoupe commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Refs #5187

Swaps obs_get_video_sdr_white_level and obs_get_video_hdr_nominal_peak_level (extracted in #5188) to safe Rust in obs-core.

  • Safe core obs_core::video_level_queries: None (NULL core) or no graphics returns exactly 300.0 (0x43960000) / 1000.0 (0x447a0000); otherwise the stored level's exact bits, with no validation, clamping or arithmetic.
  • Thin FFI shim plus a real private C adapter (libobs/obs-video-level-queries-fields.c.h): one call returns the current core, Rust checks it for NULL, and only then a second call reads video.graphics and both levels. No public header changes; the exports are in rust-exports.d/obs-core-video_level_queries.txt.
  • The original stays as the C-reference group libobs.ported-video-level-queries and as the Tier 3 oracle (rust/obs-c-oracle/oracle/video_level_queries.c).
  • The unchanged test_video_level_queries.c now links libobs_rust-static and the real adapter in its graph entry. Its checked-in registration expectation goes in a new unsuffixed core-relinked family next to hotkey-control. video_level_queries_link_support.cmake adds the adapter to every other Rust-static consumer.
  • oracle/source_deinterlace_links.c dropped its obs_get_video_sdr_white_level stand-in, which would now clash with the Rust export in obs-tests-core (duplicate symbol). The only binary that links obs-source-seam also links obs-core, and there the export returns 300 for a NULL core, like the stand-in did.

Evidence

RED (fc7b390), soldr cargo test -p obs-data --test obs-tests-core video_level_queries:

failures:
    obs_core::video_level_queries::graphics_returns_exact_field_bits
    obs_core::video_level_queries::no_core_before_and_after
    obs_core::video_level_queries::no_graphics_ignores_stored_fields
test result: FAILED. 1 passed; 3 failed

GREEN (1303511a4), same command: test result: ok. 7 passed; 0 failed (4 Tier 1 mirrors, plus Tier 3 real_c_adapter_layout, characterized_edges_match_original_c (3 core states × 14×14 edge bit patterns: signed zeros, subnormal, smallest normal, largest finite, ±inf, quiet NaN payloads, the defaults) and the proptest random_level_bits_match_original_c). Each Tier 3 case also checks that the core bytes and the global core pointer are unchanged after every call. Signaling NaNs are left out of the random cases because 32-bit x86 float returns can quiet them, in the C as well as the Rust.

Mutation: returning the stored SDR level without checking graphics fails characterized_edges_match_original_c and random_level_bits_match_original_c; reverted.

Tier 2, OBS_CTEST_JOBS=10 uv run rust/tools/linux-validate/run.py --repeat 1 --tests 'test_video_level_queries|test_no_core_getters|test_video_levels_range|test_get_audio|test_video_stop_requested_rust|test_service_handler_getters_rust|test_hotkey_background_control':

== libobs exported symbols, C vs Rust
== [OFF] tests load /build/tree/libobs-c-reference/libobs.so.30
100% tests passed, 0 tests failed out of 1018
== [ON] tests load /build/tree/libobs/libobs.so.30
100% tests passed, 0 tests failed out of 1018

(The targeted repeat passed 7/7 on both.)

Also: soldr cargo test -p obs-studio-rust --test obs-tests-app native_build:: (314 passed), uv run ci/windows_link_check.py (exit 0), ./lint ok.

Tier 4 doesn't apply (this isn't a protocol query); the C++ obs-websocket plugin is untouched.

🤖 Generated with Claude Code

@rdoupe

rdoupe commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator Author

Fixup for the macOS Tier 2 failure (run 44464288901, job Rust Tier 2 (macos-26)):

test_video_level_queries.c:37: --- 1133903872 != 1126384999
[  FAILED  ] no_core_before_and_after
[  FAILED  ] graphics_returns_exact_field_bits

Cause: on macOS the relinked fixture bound obs_get_video_sdr_white_level / obs_get_video_hdr_nominal_peak_level to libobs.dylib's copy (two-level namespace, no interposition), and that copy reads the dylib's own NULL obs, so every stored-bits case got the 300.0 / 1000.0 defaults. Linux hid it because the executable's obs interposes the shared library's.

Fix (520f192), same shape as the hotkey fixtures: the public shims forward to obs_video_level_queries_{sdr_white_level,hdr_nominal_peak_level}_request, listed in rust-hidden.d so libobs does not export them, and the fixture's graph entry redirects its calls there with definitions. The C test file is unchanged.

Local checks after rebasing onto master:

  • OBS_CTEST_JOBS=10 uv run rust/tools/linux-validate/run.py --repeat 1 --tests test_video_level_queries: 1021/1021 on both builds, plus the repeat pass.
  • soldr cargo test -p obs-data --test obs-tests-core video_level: 7 passed.
  • soldr cargo test -p obs-studio-rust --test obs-tests-app native_build::: 315 passed (registration entries).
  • soldr cargo test -p obs-util --lib export_list: 4 passed.
  • ./lint: ok.

The macOS fix itself can only be confirmed by the macos-26 lane on this push.

@rdoupe

rdoupe commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased onto master after #5190 swapped the video-info query beside this one. Conflicts were list-only (rust/obs-core/src/lib.rs, src/ffi/mod.rs, tests/obs_core/main.rs, libobs/build/libobs.core+.h.c): kept both modules and both -fields.c.h includes; no code change.

  • ./lint: ok
  • soldr cargo test -p obs-data --test obs-tests-core -- video_level_queries video_info_query: 15 passed
  • OBS_CTEST_JOBS=10 uv run rust/tools/linux-validate/run.py --repeat 1 --tests "test_video_level_queries|test_video_info_query": full graph 1023/1023 passed, then test_video_info_query, test_video_info_query_rust, test_video_level_queries 3/3 passed

rdoupe and others added 2 commits November 19, 2026 04:03
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
obs_get_video_sdr_white_level and obs_get_video_hdr_nominal_peak_level
now come from obs-core. A real C adapter returns the current core; Rust
checks it for NULL before a second adapter reads the graphics pointer
and both stored levels. Defaults (300.0, 1000.0) without a core or
graphics; otherwise the stored bits verbatim.

The unchanged test_video_level_queries fixture now links the Rust export
and the real adapter (new core-relinked registration family). The
deinterlace oracle's SDR white level stand-in is dropped: obs-core's
export answers 300 there for a NULL core.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ci-Attestation: {"at":1795065287,"gate":"data/all/compatibility","host":"linux-x86_64","key":"","lane":"client-checks","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":58,"stamp":"d1c09d6a52dca0eb7d52be5169c0a8da","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065287,"gate":"data/all/flatpak-manifest","host":"linux-x86_64","key":"","lane":"client-checks","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":58,"stamp":"d79410b81fb5fc0764ac165882b4582a","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065287,"gate":"data/all/qt-xml","host":"linux-x86_64","key":"","lane":"client-checks","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":58,"stamp":"2761e464dfb43192011b858a282c7329","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065287,"gate":"data/all/services-schema","host":"linux-x86_64","key":"","lane":"client-checks","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":58,"stamp":"9c0b5e8b7e64b3eac10544671af9b3e7","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"general/all/client-lint","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"b0680622bb87973fd797dd55165b4f36","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065287,"gate":"python/all/self-test","host":"linux-x86_64","key":"","lane":"client-checks","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":58,"stamp":"377e4c5f90577ad813940075bb779871","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"f4a0958af0523789d406613b5c5260bb","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"5ec11291e9b13e03af810f5b7c21f561","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"b7a5d44e4aa6c79fcbd1736bad129ecb","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"945ce2df7c33ce30fa0a0672328bbd95","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"466972374c06148df092455341d2f0a8","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"c2baedd22b1a0eb05856299ae05a6e64","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"d2d757dfb484dd579e8c321cba89be65","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"9871e7c3ae5ab370cf7aabe65c0d5a51","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"1cd90e534459d78360633c5ec80515ae","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"133e4c1a36259827b7c67026eb1a009b","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"f0188189872180559f35d8f9cc651e55","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065228,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"4a63020b33b8ba092ddcceb7994616ac87fc965740e7a0329ffd27a240838992","lane":"client-lint","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":63,"stamp":"442000b86710771b2edf1352882d3e76","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}
Ci-Attestation: {"at":1795065512,"gate":"rust/x86_64-unknown-linux-gnu/client-test","host":"linux-x86_64","key":"6e6b798617abe2f2a5b4ed05e43d456eeed9636d815594f36464b601fc4f8158","lane":"client-test-x86_64-unknown-linux-gnu","parents":["fc7b39008bfc6aaf93ffc5d6bbcbb80cb0fbfd9f"],"secs":224,"stamp":"c2b0042ceab90b96eb595b4ad5dfbc10","tree":"9a57fcd04113215777a91a07ff69180f4288a01f","v":1,"via":"run"}

Client-Checks: {"checks":{"base":"1bad0135e0fbc45f9ab2164bfb94c54395b193c4","coverage":"all-tracked-applicable-files","diff":["libobs/build/libobs.core+.h.c","libobs/build/libobs.ported-video-level-queries+.h.c","libobs/build/ported-source-sets/video-level-queries.json","libobs/cmake/rust-exports.d/obs-core-video_level_queries.txt","libobs/obs-video-level-queries-fields.c.h","rust/README.md","rust/obs-build/tests/native/registration/rust-static/cases/core-relinked/test_video_level_queries.json","rust/obs-build/tests/native/registration/rust_static_entries.rs","rust/obs-c-oracle/oracle/source_deinterlace_links.c","rust/obs-c-oracle/oracle/video_level_queries.c","rust/obs-core/src/ffi/mod.rs","rust/obs-core/src/ffi/video_level_queries.rs","rust/obs-core/src/lib.rs","rust/obs-core/src/video_level_queries.rs","rust/obs-core/tests/obs_core/main.rs","rust/obs-core/tests/obs_core/video_level_queries.rs","rust/obs-core/tests/obs_core/video_level_queries_parity.rs","test/cmocka/build/test-graph.json","test/cmocka/tests.d/video_level_queries_link_support.cmake"],"head":"ed825037a5b936e327b65b36e3599c3197a4195b","tools":{"orchestrator-python":"3.13.16 (main, Oct 14 2026, 01:04:01) [Clang 23.1.3 ]","schema-dependencies":"3.13.16 (main, Oct 14 2026, 01:04:01) [Clang 23.1.3 ]\n{'jsonschema': '4.26.0', 'json_source_map': '1.0.5'}","uv":"uv 0.13.5 (x86_64-unknown-linux-gnu)","xmllint":"xmllint: using libxml version 21504-GITv2.15.4\n   compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 DTDValid HTML C14N Catalog XPath XPointer XInclude Iconv ICU ISO8859X Regexps Automata RelaxNG Schemas Schematron Modules Debug Zlib"},"tracked-digest":"e3a53df5c08449a7af4ab81d4bf3224fa317e2bd2bc903a8b86bb34120761977","tree":"9a57fcd04113215777a91a07ff69180f4288a01f"}}
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 19, 2026
On macOS the relinked test_video_level_queries bound its calls to
libobs.dylib's copy of the queries (two-level namespace), which read the
dylib's own NULL core, so the stored-bits cases got the defaults
(macos-26 Tier 2: 0x43960000 != 0x43234567). Follow the hotkey fixtures:
the public shims forward to hidden *_request entries, and the fixture's
definitions redirect its calls to them, so the test reaches the static
Rust code and its own core.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Ci-Attestation: {"at":1795080244,"gate":"data/all/compatibility","host":"linux-x86_64","key":"","lane":"client-checks","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":95,"stamp":"8cc5f8707c81eab8a6a050e46df32ca7","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080244,"gate":"data/all/flatpak-manifest","host":"linux-x86_64","key":"","lane":"client-checks","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":95,"stamp":"fbf0e3805038c75bf804c4f75041a396","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080244,"gate":"data/all/qt-xml","host":"linux-x86_64","key":"","lane":"client-checks","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":95,"stamp":"c1bf43d90857a53b9f512350b64c8d30","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080244,"gate":"data/all/services-schema","host":"linux-x86_64","key":"","lane":"client-checks","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":95,"stamp":"304dfb37fbaa7c08807778caf43dbf21","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080148,"gate":"general/all/client-lint","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"79395ec373e987a097e256abed68df09","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080244,"gate":"python/all/self-test","host":"linux-x86_64","key":"","lane":"client-checks","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":95,"stamp":"98079eb46a013e70f75ed5db809354ff","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080149,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"de57b4c3b62984ab74251810b474e2d9","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080149,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"a8ac48c50ecea3f6c70dbf5b38f56d30","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080148,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"9031f58fcc0eda54f451b1ea6d5917ff","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080148,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"4de90d2df023334f664d66577ede401c","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080148,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"e6dd0bce89807ecf31f4f66bd0c43577","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080148,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"c66b707a8ea4dcd3085cec5522c23bac","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080149,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"6625ec4fddb5fb60d95fc59130d06508","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080149,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"58372f16d8873eef819f2258a45a7c75","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080148,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"343f558fab9546d6602aa6b74fef3b0c","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080148,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"bf2de8465234361bf6889c128ea8d30c","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080148,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"912aa231c1bc3d05432f3a48092f78a6","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080148,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"7489645b3e74c694c26bac006c8e710f9f003e609db1c9675e1c315fceaf4381","lane":"client-lint","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":67,"stamp":"38bbf5ffaf55f7fc830025050f750fb1","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}
Ci-Attestation: {"at":1795080475,"gate":"rust/x86_64-unknown-linux-gnu/client-test","host":"linux-x86_64","key":"12c2bc0ad89b190a45c74fc1a3aa1afc14a5336a09a1f0f4f427d8c5fd3f8df0","lane":"client-test-x86_64-unknown-linux-gnu","parents":["8bcebbe627cb436921715de6a45b66e8f8c14437"],"secs":230,"stamp":"9ae663497813a0f1fd8c8e2852a3d43c","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0","v":1,"via":"run"}

Client-Checks: {"checks":{"base":"f5a3921464865812ebc4ee68cd80b34d1dce9b00","coverage":"all-tracked-applicable-files","diff":["ci/macos_native_fixtures.py","ci/test_macos_native_fixtures.py","docs/ci-tooling.md","libobs/build/libobs.core+.h.c","libobs/build/libobs.ported-video-level-queries+.h.c","libobs/build/ported-source-sets/video-level-queries.json","libobs/cmake/rust-exports.d/obs-core-video_level_queries.txt","libobs/cmake/rust-hidden.d/obs-core-video_level_queries.txt","libobs/obs-video-level-queries-fields.c.h","rust/README.md","rust/obs-build/tests/native/registration/rust-static/cases/core-relinked/test_video_level_queries.json","rust/obs-build/tests/native/registration/rust_static_entries.rs","rust/obs-c-oracle/oracle/source_deinterlace_links.c","rust/obs-c-oracle/oracle/video_level_queries.c","rust/obs-core/src/ffi/mod.rs","rust/obs-core/src/ffi/video_level_queries.rs","rust/obs-core/src/lib.rs","rust/obs-core/src/video_level_queries.rs","rust/obs-core/tests/obs_core/main.rs","rust/obs-core/tests/obs_core/video_level_queries.rs","rust/obs-core/tests/obs_core/video_level_queries_parity.rs","test/cmocka/build/test-graph.json","test/cmocka/tests.d/video_level_queries_link_support.cmake"],"head":"755523354449630d94f4d3438fa7744e95a3207e","tools":{"orchestrator-python":"3.13.16 (main, Oct 14 2026, 01:04:01) [Clang 23.1.3 ]","schema-dependencies":"3.13.16 (main, Oct 14 2026, 01:04:01) [Clang 23.1.3 ]\n{'jsonschema': '4.26.0', 'json_source_map': '1.0.5'}","uv":"uv 0.13.5 (x86_64-unknown-linux-gnu)","xmllint":"xmllint: using libxml version 21504-GITv2.15.4\n   compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 DTDValid HTML C14N Catalog XPath XPointer XInclude Iconv ICU ISO8859X Regexps Automata RelaxNG Schemas Schematron Modules Debug Zlib"},"tracked-digest":"8c4ff8d3e97dd2e308da8ab6b713cd38373b2adcb66f802b3cb9e115672f8af1","tree":"c83a97ad898b9cd199908093cb71cebfc21717e0"}}
@rdoupe
rdoupe force-pushed the port/5187-video-level-queries branch from bb7a4fe to 9950a78 Compare November 19, 2026 09:28
@rdoupe

rdoupe commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased onto master after #5191 extracted the video-stats queries next to this one in libobs/build/libobs.core+.h.c; the conflict was the include list only (kept both obs-video-level-queries-fields.c.h and obs-video-stats-queries.c.h).

Rechecked on the new head (9950a78):

  • ./lint: ok
  • soldr cargo test -p obs-data --test obs-tests-core video_level: 7 passed
  • OBS_CTEST_JOBS=10 uv run rust/tools/linux-validate/run.py --repeat 1 --tests 'video_level_queries|source_deinterlace': 4/4 passed

@rdoupe
rdoupe enabled auto-merge November 19, 2026 09:28
@rdoupe
rdoupe added this pull request to the merge queue Nov 19, 2026
Merged via the queue into master with commit 62933c8 Nov 19, 2026
42 checks passed
@rdoupe
rdoupe deleted the port/5187-video-level-queries branch November 19, 2026 10:16
@obs-rust-project-manager obs-rust-project-manager Bot moved this from Needs fix to Done in obs-rust Multiview Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant