Repository navigation
fix: hide Windows child processes and cache Codex version checks - #182
Draft
dmarshall-kno2 wants to merge 1 commit into
Draft
dmarshall-kno2 wants to merge 1 commit into
dmarshall-kno2 wants to merge 1 commit into
Conversation
Preserve summary isolation while avoiding repeated compatibility probes. Handle native Windows paths and retain bare-filename fallback. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background sync and Codex summary workers can open terminal windows on Windows. Each summary also repeats the Codex compatibility probe, and native Windows conversation paths lose their project name.
This change hides the existing child launches, caches compatibility checks within each worker, and uses native path parsing while preserving the
unknownproject fallback for a bare filename.The compatibility cache coalesces concurrent checks, invalidates executable identity changes, retries one observed identity change, evicts failures, and bounds retained entries. Each summary still gets its own read-only ephemeral app-server. The original launch command, arguments, version floor, timeout, environment and approval policy are preserved. Sync continues exporting OpenCode before its authoritative lock check.
The installer regression distinguishes Windows direct-child termination from POSIX process-group termination. Source and affected generated distribution files are included. The MCP bundle is unchanged: same-dependency build graph and output comparisons show these changed modules do not reach that entry point. The existing MIT license is retained.
Validation on Windows against upstream
7e06519357777badd7a115d2014a7ef845904310:The patch remains byte-for-byte identical to the reviewed candidate. Linux/macOS execution, real model summaries, real npm installer windows and Windows grandchild termination have not been verified. The existing Ubuntu Node 22/24 PR CI remains required; the Windows results do not substitute for it.
No dependency, version, marketplace registry or release metadata changes are included. Release/version/registry publication remains with the maintainers.