Repository navigation
fix(core): a navigation-only action raises no success toast unless it declares successMessage (objectui#12755) - #12799
Merged
objectstack-fleet[bot] merged 4 commits intoOct 16, 2026
Conversation
… declares successMessage (objectui#12755)
type: 'url', its navigation alias and type: 'form' only change the route,
yet their { success: true } reached handlePostExecution and the generic
completedSuccessfully toast. The runner now marks that result silent
(success stays true) unless the action declares a successMessage.
Actions that write keep their toast.
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EB9zdzi7QEfaykkzXZPUpU
…(objectui#12755) Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EB9zdzi7QEfaykkzXZPUpU
…vigation-no-toast
…release Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EB9zdzi7QEfaykkzXZPUpU
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
Contributor
Author
席位核对 · ACCEPT ·
|
objectstack-fleet
Bot
deleted the
claude/issue-12755-navigation-no-toast
branch
October 16, 2026 21:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12755
Clause-②: no
What
A navigation-only action no longer claims a success.
type: 'url', itsnavigationalias andtype: 'form'only change the route, yet each raised the generic success toast ("Action completed successfully" / 「操作已成功完成」) after it navigated. On objectstack-ai/cloud#2909 that toast made a user believe an invitation had been sent.How
packages/core/src/actions/ActionRunner.ts:executeUrl,executeNavigationandexecuteFormhand their result to a newannounceNavigation. A successful navigation is markedsilent(the existing flag that means "no success toast for this result") and keepssuccess: true, unless the action declares a non-emptysuccessMessage. In that case the declared copy still toasts.InlineActionSchema, so the rule lives in the runner.composeSuccessMessageis unchanged (objectui#12757 is a separate card).Clause-② reason: a runner stops announcing a success that did nothing. No key, prop, export or accept set changes.
Tests
ActionRunner.navigationNoToast-12755.test.ts: a bare url action navigates silently; the navigation alias and a form action stay silent; url plussuccessMessagetoasts that copy; a refused url still error-toasts; CONTROL: an api action keeps its success toast.successMessageturns the declared-copy test red.useActionRunner.test.tspinned the result{ success: true }for a navigation; it now pins{ success: true, silent: true }. The only non-test reader ofsilentis the toast gate.Live reading
Backend from
e2e/live/ci/start-backend.sh(published 18.0.0-next.2 showcase) with the console dev server from this branch. On a showcase task record, 'Open Docs' (type: 'url') in the overflow menu:Screenshots: branch
claude/issue-12755-evidence,evidence/12755/.Acceptance notes
navigate,navigate_createandnavigate_editalso only navigate and return a non-silent success. They are outside this card's file surface and were not measured live.ActionResult.silentin@object-ui/typesstill describes only the hand-off case.Provenance: built by the cloud session
session_01EB9zdzi7QEfaykkzXZPUpU(claim6224263987) and opened by thedomain:uiseat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. The seat appended(objectui#12755)to the title, replaced the dev's footer line with this paragraph, and changed nothing else.Generated by Claude Code