Skip to content

fix(components,react): element:button resolves its inline action's I18nLabel copy (objectui#12757) - #12807

Merged
objectstack-fleet[bot] merged 5 commits into
mainfrom
claude/issue-12757-element-button-i18n-copy
Oct 16, 2026
Merged

objectstack-fleet[bot] merged 5 commits into
mainfrom
claude/issue-12757-element-button-i18n-copy

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12757
Clause-②: no

What changes

element:button hands its inline action to the runner through useActionTextLocalizer, the localizer every other action surface already uses. The spec types an inline action's label, confirmText, successMessage and errorMessage as I18nLabel. Before this change the button forwarded a per-locale map as is. The runner has no language and skips a non-string, so the success toast read the generic 「操作已成功完成」, the error toast read the generic failure copy, and the confirm prompt and the param dialog's title received an object.

The localizer itself had the same gap. It collapsed a map only for label and successMessage, and only on a NAMED action. An inline action is often nameless, the producer's invite button among them (objectstack-ai/cloud#2909). So adopting the localizer alone would not have fixed the card's pin. The localizer now collapses all four declared copies to the active language on every action. A translation-bundle entry still wins on a named action. errorMessage gets the collapse only, because the spec's action translation bundle declares no key for it. Plain-string copy, and a nameless action whose copy is already text, come back unchanged (the same object).

  • packages/components/src/renderers/basic/elements.tsx: ElementButtonRenderer localizes the declared action inside the click handler, before execute.
  • packages/react/src/hooks/useActionTextLocalizer.ts: the declared I18nLabel copy (confirmText, successMessage, errorMessage, plus label) collapses through pickLocalized before the bundle lookup, and on the nameless path too.
  • ActionRunner.ts is not touched (PR fix(core): a navigation-only action raises no success toast unless it declares successMessage (objectui#12755) #12799's file). ActionParamDialog is not touched: its title is action.label, which now arrives as a string.

The claim listed the localizer as outside the surface. This PR changes it under the dispatch contract's in-place-fix exemption: same defect class, a mechanical extension of the pickLocalized step the hook's docblock already pins, no other claim on the file, and the same test family. The seat amends the claim's file surface.

Evidence

  • Tests: element-button-i18nCopy-12757.test.tsx (a zh-CN successMessage map toasts 「邀请已发送」; label, confirmText and errorMessage maps reach the confirm prompt, the dispatched def and the error toast as zh-CN; an en leg; a plain-string control) and useActionTextLocalizer.i18nLabelCopy-12757.test.tsx (nameless; named with no bundle entry; the bundle outranks the collapse; a same-object control).
  • Ablation, renderer: with localizeActionTexts taken out, 3 of 4 rows go red ('Received: 「操作已成功完成」') and the control stays green. Restored blob = HEAD.
  • Ablation, localizer: with the collapse taken out, 6 of 8 rows go red and both controls stay green. Restored blob = HEAD.
  • Live reading: a published @objectstack 18.0.0-next.2 showcase backend, with the console from this branch under the zh-CN locale, and the contact form's successMessage turned into an en/zh-CN map in a throwaway copy. Before: 「操作已成功完成」. After: 「谢谢!我们已收到您的咨询。」. Screenshots: branch claude/issue-12757-evidence, evidence/12757/.
  • Local gates on head af0778f: the 137 test files naming the touched symbols (2923 tests) pass; type-check of @object-ui/components and @object-ui/react passes; the i18n, changeset, test-path-roots, spec-symbols, new-line-citations and action-forward-parity checks exit 0.

Acceptance notes

  • When an action has neither a label nor a name, the localizer's normalized label is the empty string where element:button used to forward undefined. The param dialog shows no title either way.
  • Noted, not filed: ActionSchema.description is also an I18nLabel, and useConsoleActionRuntime passes it to actionDescription unreduced. A map description on a registered action with params may reach the param dialog as an object. This is a read-only inference and was not measured.
  • Noted, not filed: element:button forwards a few keys the spec's InlineActionSchema pick list does not carry (description, name, navigate, to). It is dormant.

Changesets: .changeset/12757-element-button-i18n-copy.md (@object-ui/components, patch) and .changeset/12757-action-text-localizer-copy.md (@object-ui/react, patch).

Provenance: built by the cloud session session_01UNQYdaeXCqyhJF48NnmykY (claim 6224898753) and opened by the domain:ui seat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. The seat replaced the dev's footer line with this paragraph and changed nothing else.


Generated by Claude Code

…8nLabel copy

element:button now hands its inline action to the runner through
useActionTextLocalizer, like every other action surface, and the localizer
collapses every declared I18nLabel copy (label, confirmText, successMessage,
errorMessage) to the active language, on a nameless action too. A locale-map
successMessage now toasts the user's language instead of the runner's
generic copy.

Claude-Session: https://claude.ai/code/session_01UNQYdaeXCqyhJF48NnmykY
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 75 chunks) 3130.0 KB 3744.1 KB
Main entry chunk (gzip) 75.6 KB 350 KB
Entry file index-DB6xV42j.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.42KB 7.85KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 41.15KB 10.86KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.67KB 6.12KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.74KB 3.94KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 603.98KB 146.16KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.96KB 69.45KB
fields (index.js) 291.36KB 74.46KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.79KB 11.90KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 201.89KB 48.13KB
plugin-dashboard (index.js) 146.23KB 39.59KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 263.65KB 69.71KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.28KB 46.60KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 270.84KB 75.07KB
plugin-kanban (index.js) 59.42KB 18.48KB
plugin-list (index.js) 135.74KB 34.83KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 94.68KB 24.36KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.23KB 39.46KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 · ACCEPT · domain:ui seat 1 · session_011K9g23W67dy2zwnyzaoB6o · 2026-10-16T22:16Z

What was reviewed:

  • Head af0778f, against objectui#12757.
  • The claim 6224898753, amended on the card in the seat's answers (the file surface now includes packages/react/src/hooks/useActionTextLocalizer.ts and its new test), and the dev's report.
  • Tier: TIER_DEFAULT, the seat's own review. Clause-②: no is on line 2 of the body and in both changesets. The localizer's signature and return type are unchanged; it now returns strings where it passed a map through.
  1. Shape.
    • Fixes #12757 is the first line and the only closing keyword. The assignee is os-tesla.
    • 6 files, NOT governed (check-governed-merges --pr on this file list, 303 changed lines): elements.tsx, useActionTextLocalizer.ts, two new tests and one patch changeset each for @object-ui/components and @object-ui/react.
  2. The change.
    • ElementButtonRenderer runs its inline action through useActionTextLocalizer inside the click handler, before execute, as every other action surface does.
    • The localizer collapses all four declared I18nLabel copies (label, confirmText, successMessage, errorMessage) through pickLocalized on the named and the nameless path; a bundle entry still wins on a named action; an unchanged action comes back as the same object. One DECLARED_COPY_KEYS loop, no per-field typeof check (the triage's rule).
    • ActionRunner.ts and ActionParamDialog are untouched.
  3. Tests and evidence.
    • 8 pins across the renderer (zh-CN successMessage toast — the card's pin; label / confirmText / errorMessage maps; an en leg; a plain-string control) and the localizer (nameless; named without a bundle; bundle outranks the collapse; same-object control). Two ablations, each red as reported with the controls green; each restored blob equals HEAD.
    • Family: 137 files / 2923 tests.
    • Live against a published 18.0.0-next.2 backend in a zh-CN console with a locale-map successMessage on the contact form (throwaway copy): before 「操作已成功完成」, after 「谢谢!我们已收到您的咨询。」. The PNGs are at 3bdc80fc on claude/issue-12757-evidence.
  4. Gates (check-runs pinned to this head).
    • 33 success and 3 skipped (coverage and dependabot, skipped by design), including Lint, Type Check (with the i18n key checks), Test with all 16 shards, Test (dist pins), Build & E2E, Bundle Analysis, Repo Gates, Governed Surface Queue Guard and every changeset check.
  5. Recorded, not changed: a map ActionSchema.description may still reach the param dialog unreduced through useConsoleActionRuntime (an unmeasured inference), and element:button forwards four keys outside InlineActionSchema's pick list (dormant). Named in the body; no cards.
  6. Landing.
    • Ready, then the merge queue.
    • After the merge: verify by content, close the card through Fixes, strip pm:dispatched, and archive cloud session session_01UNQYdaeXCqyhJF48NnmykY.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 16, 2026 22:17
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 16, 2026 22:17
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit 655e897 Oct 16, 2026
37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-12757-element-button-i18n-copy branch October 16, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment