fix(plugin-detail): a detail section on a print page prints every declared field and no "Show N empty fields" button by objectstack-fleet[bot] · Pull Request #12729 · objectstack-ai/objectui

objectstack-fleet · 2026-10-16T15:42:54Z

Fixes #12717
Clause-②: no

What

On a page that declares print, a record:details section prints every field it declares. The "Show N empty fields" / "Hide empty fields" button no longer reaches paper.

packages/plugin-detail/src/DetailSection.tsx hides empty fields for two reasons, and they belong to two different owners.

shouldAutoHideEmpty is the renderer's own density heuristic. No author declares it, and it depends on the viewport (useIsMobile) and on a ratio of empty fields, so it is a screen concern. On a print page it is now off. Every declared field prints, an empty one as the shared placeholder dash. The toggle is derived from the heuristic (showEmptyToggle = emptyCount > 0 && shouldAutoHideEmpty), so with no auto-hide there is no toggle. This follows card ②'s rule (objectui#11958): record:details is in the printable block subset because it prints every field it declares. That is the same reason the collapsed section already opens on paper.
hideAllEmptySection (section.hideEmpty === true) is the authored record:details key. On paper it keeps doing what it declares: an all-empty section prints nothing at all, with no heading and no control. It is not gated.

usePrintPage() is now read once, above every early return (isPrintPage). The existing collapse gate and the new heuristic gate both read that one value.

Not done, deliberately:

No print:hidden on the button. The empty fields would still be missing from the paper.
No change to page-print.ts.
The gate stays local to the heuristic, so objectui#12618 (the on-screen all-empty fold, on hold) can change that fold and keep this gate.

Off a print page, the toggle, the heuristic and the authored hide are unchanged.

Tests

packages/plugin-detail/src/__tests__/detailSectionPrintEmptyToggle-12717.test.tsx, all at head 9f28cd2:

Inside a PrintPageProvider: no toggle, all four declared fields present, two placeholders.
Inside a PrintPageProvider: an authored hideEmpty: true all-empty section renders nothing.
Control, off a print page: the toggle reads "Show 2 empty fields" and the empty rows are hidden.

Each test was proven red by a one-off ablation, then restored. Each restore was checked: blob 576f471d0f52 equals HEAD and git diff HEAD is empty.

Deleting the print gate turns test 1 red.
Gating the authored hide on print (the wrong fix) turns test 2 red.
Turning the heuristic off everywhere turns test 3 red.

pnpm exec vitest run packages/plugin-detail at 9f28cd2: 275 files passed, 1 skipped; 2663 tests passed, 14 skipped.

Local gates (`9f28cd2`)

All of these exited 0:

the closure build for @object-ui/plugin-detail;
the @object-ui/plugin-detail build and type-check;
the console build with VITE_BASE_PATH=/console/;
check:changeset-claims, changeset:check, check:test-path-roots, check:spec-symbols and the changeset presence check.

eslint on the changed files reports 0 errors. Its 12 warnings were all in DetailSection.tsx already; the base file has the same 12.

Acceptance notes

NOT MEASURED: PDF reading. The showcase invoice print page showcase_invoice_document is not in the published showcase at @objectstack/cli@18.0.0-next.2, nor in objectstack main 6d1660d. As a fallback, I added a throwaway page-level print to a showcase record page in a scratch copy of the backend. It never reached the served page metadata, and no print page mounted on the record route, so no before/after PDF could be rendered.
Other controls in this file on paper:
- A collapsible section's disclosure chevron still prints, inside the header button that card ② opens. It is outside this claim's file surface, so it is reported, not fixed.
- The hover copy and pencil buttons are invisible until hover, so they draw nothing on paper.

Provenance: built by the cloud session session_01D7HiWiz4iSX26uyJLB8jNs (claim 6218362787) and opened by the domain:ui seat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. The seat replaced the dev's own footer lines with this line.

Generated by Claude Code

…lared field and no empty-field toggle The empty-field auto-hide is a screen density heuristic; on a page that declares `print` it hid the empty rows and left its "Show N empty fields" button on paper. It is now off under a print page, read through the same `usePrintPage()` answer the collapse gate uses. The authored all-empty `hideEmpty` is unchanged. Claude-Session: https://claude.ai/code/session_01D7HiWiz4iSX26uyJLB8jNs Co-authored-by: Claude <noreply@anthropic.com>

github-actions · 2026-10-16T15:45:46Z

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 73 chunks)	3120.4 KB	3744.1 KB
Main entry chunk (gzip)	66.0 KB	350 KB
Entry file	`index-NGbgat97.js`	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	21.42KB	7.85KB
app-shell (runtime-config.js)	22.59KB	7.89KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.11KB	3.87KB
auth (ActiveOrganizationStorage.js)	27.95KB	10.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	40.22KB	10.61KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	20.39KB	6.02KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.72KB	2.24KB
auth (SocialSignInButtons.js)	9.70KB	3.93KB
auth (UserMenu.js)	3.39KB	1.21KB
auth (auth-gate-events.js)	1.62KB	0.83KB
auth (authStyles.js)	5.27KB	1.86KB
auth (createAuthClient.js)	41.19KB	11.12KB
auth (createAuthenticatedFetch.js)	8.54KB	3.46KB
auth (index.js)	3.63KB	1.64KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	11.08KB	4.58KB
collaboration (CommentThread.js)	27.26KB	8.03KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.28KB	2.60KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (commentAuthorship.js)	1.39KB	0.78KB
collaboration (index.js)	1.93KB	0.85KB
collaboration (useCollaborationTranslation.js)	6.50KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	597.81KB	144.28KB
core (index.js)	10.18KB	4.04KB
create-plugin (index.js)	27.94KB	9.51KB
data-objectstack (index.js)	248.96KB	69.45KB
fields (index.js)	290.81KB	74.35KB
i18n (LocalizationContext.js)	2.92KB	1.42KB
i18n (builtinAggregateLabels.js)	0.86KB	0.49KB
i18n (currency.js)	2.59KB	1.22KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	8.87KB	3.64KB
i18n (index.js)	5.52KB	2.39KB
i18n (pickLocalized.js)	9.86KB	3.95KB
i18n (provider.js)	39.35KB	12.88KB
i18n (translateFn.js)	0.20KB	0.18KB
i18n (useDisplayLocale.js)	3.52KB	1.76KB
i18n (useObjectLabel.js)	36.87KB	9.88KB
i18n (useSafeTranslation.js)	7.14KB	2.92KB
layout (index.js)	40.67KB	11.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.99KB	0.87KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	6.62KB	2.45KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useSpecGesture.js)	5.52KB	2.10KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	15.35KB	5.51KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	6.82KB	2.38KB
permissions (discardProofCache.js)	1.04KB	0.55KB
permissions (evaluator.js)	8.33KB	3.07KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	4.83KB	2.27KB
plugin-ai (index.js)	16.04KB	3.92KB
plugin-calendar (index.js)	54.94KB	16.05KB
plugin-charts (index.js)	84.97KB	23.36KB
plugin-chatbot (index.js)	201.89KB	48.13KB
plugin-dashboard (index.js)	146.15KB	39.55KB
plugin-designer (index.js)	233.95KB	50.08KB
plugin-detail (index.js)	263.44KB	69.61KB
plugin-editor (index.js)	2.23KB	1.05KB
plugin-form (index.js)	180.28KB	46.60KB
plugin-gantt (index.js)	178.36KB	45.08KB
plugin-grid (index.js)	270.35KB	74.86KB
plugin-kanban (index.js)	59.42KB	18.48KB
plugin-list (index.js)	132.91KB	34.06KB
plugin-map (index.js)	27.07KB	8.96KB
plugin-markdown (index.js)	13.88KB	4.80KB
plugin-report (index.js)	46.66KB	13.13KB
plugin-timeline (index.js)	39.21KB	11.85KB
plugin-tree (index.js)	15.07KB	5.33KB
plugin-view (index.js)	93.43KB	23.94KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	12.07KB	3.68KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	120.23KB	39.46KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	4.50KB	2.06KB
react (schema-input.js)	4.31KB	2.07KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (body-dialect.js)	4.50KB	1.99KB
sdui-parser (codegen.js)	9.45KB	3.76KB
sdui-parser (dashboard-widget-options.js)	3.07KB	1.30KB
sdui-parser (index.js)	7.30KB	3.12KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	25.28KB	7.81KB
sdui-parser (provenance.js)	3.84KB	1.90KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	23.87KB	7.83KB
types (ai.js)	4.39KB	2.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	4.12KB	1.61KB
types (authoring-nodes.js)	0.20KB	0.19KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (cloud.js)	0.20KB	0.18KB
types (complex.js)	4.44KB	2.07KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (dashboard-widget-layout.js)	2.06KB	0.96KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (expression.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	1.13KB	0.65KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	5.78KB	2.70KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	5.00KB	2.39KB
types (navigation.js)	0.20KB	0.18KB
types (node-slots.js)	7.18KB	2.34KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	2.52KB	1.31KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-approval-decision.js)	0.20KB	0.20KB
types (record-components.js)	0.20KB	0.19KB
types (record-panels.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (select-option.js)	0.20KB	0.19KB
types (spec-report.js)	4.99KB	1.96KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (strict-authoring-face.js)	19.93KB	7.26KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	8.48KB	3.50KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

objectstack-fleet · 2026-10-16T15:58:39Z

席位核对 · ACCEPT · `domain:ui` seat 1 · `session_011K9g23W67dy2zwnyzaoB6o` · 2026-10-16T15:58Z

What was reviewed:

Head 9f28cd2c11, against objectui#12717 (triage grade 6218206205, p1, the print chain).
The claim 6218362787 (Clause-②: no) and the dev's report 6219124800 on the card.
This is the lane seat's own review at TIER_DEFAULT. No narrowing, schema or governed text is touched, so no contract-review tier is owed.

Shape.
- Fixes #12717 is the first line and the only closing keyword. Clause-②: no starts line 2, and the assignee is os-tesla.
- 3 files, +114/−2, all inside the claim: DetailSection.tsx, the new pin, and one @object-ui/plugin-detail: patch changeset. NOT governed.
The change, read in the diff.
- usePrintPage() is read once, above every early return (isPrintPage). The card ② collapse gate and the new heuristic gate share it.
- shouldAutoHideEmpty, the renderer's own viewport-and-ratio density call, is off on a print page. Every declared field prints, and the toggle, which derives from the heuristic, does not draw.
- The authored hideEmpty: true all-empty hide is untouched, as declared.
- There is no print:hidden and no change to page-print.ts. Off a print page nothing changes.
Gates (check-runs pinned to this head). 33 success and 3 skipped by design, including Lint, Type Check, Test with all 16 shards, Test (dist pins), Build & E2E, Bundle Analysis, Live E2E (informational) and every changeset check. The dev's three ablations each turn exactly one pin red, and the restored blob equals HEAD.
Accepted gap: the PDF re-render triage asked for is NOT MEASURED. The invoice print page showcase_invoice_document is not in the published showcase at 18.0.0-next.2, and a throwaway page-level print did not reach the served metadata there. Acceptance 1–4 are pinned in jsdom inside a real PrintPageProvider.
Carried:
- The disclosure chevron of a collapsible section still prints: objectui#12732, serial after this PR.
- Hover-only copy and pencil buttons draw nothing on paper; noted only.
Landing. Ready, then auto-merge into the merge queue. After the merge: verify by content, close the card through Fixes, strip pm:dispatched, and archive cloud session session_01D7HiWiz4iSX26uyJLB8jNs.

Generated by Claude Code

objectstack-fleet Bot assigned os-tesla Oct 16, 2026

github-actions Bot added plugin tests labels Oct 16, 2026

objectstack-fleet Bot mentioned this pull request Oct 16, 2026

print page: a collapsible record:details section still draws its disclosure chevron and clickable-header chrome on paper — card ② opens the section but keeps the screen control #12732

Closed

objectstack-fleet Bot marked this pull request as ready for review October 16, 2026 15:59

objectstack-fleet Bot enabled auto-merge October 16, 2026 16:00

objectstack-fleet Bot added this pull request to the merge queue Oct 16, 2026

Merged via the queue into main with commit 263e9dd Oct 16, 2026
37 checks passed

objectstack-fleet Bot deleted the claude/issue-12717-print-empty-toggle branch October 16, 2026 16:12

Navigation Menu

Repository navigation

fix(plugin-detail): a detail section on a print page prints every declared field and no "Show N empty fields" button - #12729

fix(plugin-detail): a detail section on a print page prints every declared field and no "Show N empty fields" button#12729
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-12717-print-empty-toggle

objectstack-fleet Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

objectstack-fleet Bot commented Oct 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

objectstack-fleet Bot commented Oct 16, 2026

What

Tests

Local gates (9f28cd2)

Acceptance notes

Uh oh!

github-actions Bot commented Oct 16, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

objectstack-fleet Bot commented Oct 16, 2026

席位核对 · ACCEPT · domain:ui seat 1 · session_011K9g23W67dy2zwnyzaoB6o · 2026-10-16T15:58Z

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Local gates (`9f28cd2`)

席位核对 · ACCEPT · `domain:ui` seat 1 · `session_011K9g23W67dy2zwnyzaoB6o` · 2026-10-16T15:58Z