fix(plugin-detail): a record on a print page does not print its approval band (objectui#12751)

[objectstack-fleet]

Fixes #12751
Clause-②: no

What

On a page that declares print, a record in approval no longer prints its approval band. The "Recall approval" button, the "In approval · editable" / "Locked for approval" status badge and the "Approvals — 0 of 1" tally do not reach paper. Off a print page the band is unchanged.

packages/plugin-detail/src/DetailView.tsx now reads usePrintPage() once, above every early return (isPrintPage), the way DetailSection reads it since PR #12729. The approval band's condition gains && !isPrintPage, so on a print page none of the band is drawn: the badge, the recall button, the tally, the per-group ticks and the recall-error line.

Why hide the status and the tally, not print them as text

The card leaves this open. The spec answers it:

• Its print-page refusals reject record:approvals and record:approval_decision because what they show changes per viewer and per decision.
• It rejects record:path because the current stage is a field that record:details already prints.

The band's badge is host-threaded per viewer (the approvals read, the submitter signal), and its tally moves with every decision. A printed record that should say it is awaiting approval prints the record's own status field through record:details. Printing a plain-text badge would add new rendering that nobody has asked for.

Tests

• New DetailView.printApprovalBand-12751.test.tsx:
  • inside a PrintPageProvider, for both an editable and a locking approval: no recall button, no role=status, no progressbar, and the record's field still renders;
  • CONTROL off a print page: the band, the recall button, the badge text and the progressbar render.
  • Result: 4 passed.
• Ablation with the fix committed (the band condition back to schema.showHeader === false && (() => {): Tests 2 failed | 2 passed (4). Both print rows went red and both controls stayed green. The file was restored from HEAD; blob 97b55210cfb0 equals HEAD and git diff HEAD is empty.
• pnpm exec vitest run packages/plugin-detail: 2682 passed, 14 skipped.
• The 37 test files outside plugin-detail that name DetailView: 1784 passed.
• After the merge with main: the three approval-band files, 28 passed.

Local gates

All of these exited 0:

• the closure build for @object-ui/plugin-detail;
• the plugin-detail type-check;
• check:changeset-claims, changeset:check, check:test-path-roots, check:spec-symbols and check:new-line-citations;
• the changeset presence check.

eslint: 0 errors. DetailView.tsx has the same warning count as on main, and the new test file is clean.

Printed page

Setup:

• Published @objectstack/*@18.0.0-next.2 showcase backend.
• A throwaway A4 print page on showcase_invoice, added in the scratch copy only.
• INV-1010 in its finance and legal sign-off, submitted by the signed-in admin.
• Printed to PDF with Chromium on both the record route and the named page route.

Results:

• Before: the PDF carries "In approval · editable", "Recall approval" and "Approvals — 0 of 1" above the fields.
• After: only the record's fields.

The PNGs are on branch claude/issue-12751-evidence under evidence/12751/.

Acceptance notes

• Found on the same PDF, not fixed here: the invoice number does not print. record:details hides the record's title field because it assumes a page header draws it, and a print page refuses page:header. This is reported for the seat to file.
• Not gated here: DetailView's own header (showHeader: true) and the auto-tabs strip. They would print their controls if an author enabled them inside a print page. No producer was measured doing so.
• The approval decision action bar and the Print button do not reach paper today; their host already hides them in print.

Provenance: built by the cloud session session_01F54KeYBZhaNDNQjYZJ3HmP (claim 6223385481) and opened by the domain:ui seat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. The seat made no change to the dev's text and added this line.

---

Generated by Claude Code

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 74 chunks)	3127.1 KB	3744.1 KB
Main entry chunk (gzip)	75.6 KB	350 KB
Entry file	index-Cbywa0NO.js	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	21.42KB	7.85KB
app-shell (runtime-config.js)	22.59KB	7.89KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.11KB	3.87KB
auth (ActiveOrganizationStorage.js)	27.95KB	10.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	41.15KB	10.86KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	20.67KB	6.12KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.72KB	2.24KB
auth (SocialSignInButtons.js)	9.74KB	3.94KB
auth (UserMenu.js)	3.39KB	1.21KB
auth (auth-gate-events.js)	1.62KB	0.83KB
auth (authStyles.js)	5.27KB	1.86KB
auth (createAuthClient.js)	41.19KB	11.12KB
auth (createAuthenticatedFetch.js)	8.54KB	3.46KB
auth (index.js)	3.63KB	1.64KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	11.08KB	4.58KB
collaboration (CommentThread.js)	27.26KB	8.03KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.28KB	2.60KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (commentAuthorship.js)	1.39KB	0.78KB
collaboration (index.js)	1.93KB	0.85KB
collaboration (useCollaborationTranslation.js)	6.50KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	600.51KB	145.04KB
core (index.js)	10.18KB	4.04KB
create-plugin (index.js)	27.94KB	9.51KB
data-objectstack (index.js)	248.96KB	69.45KB
fields (index.js)	291.36KB	74.46KB
i18n (LocalizationContext.js)	2.92KB	1.42KB
i18n (builtinAggregateLabels.js)	0.86KB	0.49KB
i18n (currency.js)	2.59KB	1.22KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	8.87KB	3.64KB
i18n (index.js)	5.52KB	2.39KB
i18n (pickLocalized.js)	9.86KB	3.95KB
i18n (provider.js)	39.35KB	12.88KB
i18n (translateFn.js)	0.20KB	0.18KB
i18n (useDisplayLocale.js)	3.52KB	1.76KB
i18n (useObjectLabel.js)	36.87KB	9.88KB
i18n (useSafeTranslation.js)	7.14KB	2.92KB
layout (index.js)	40.67KB	11.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.99KB	0.87KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	6.62KB	2.45KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useSpecGesture.js)	5.52KB	2.10KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	15.35KB	5.51KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	6.82KB	2.38KB
permissions (discardProofCache.js)	1.04KB	0.55KB
permissions (evaluator.js)	8.33KB	3.07KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	4.83KB	2.27KB
plugin-ai (index.js)	16.04KB	3.92KB
plugin-calendar (index.js)	54.94KB	16.05KB
plugin-charts (index.js)	84.97KB	23.36KB
plugin-chatbot (index.js)	201.89KB	48.13KB
plugin-dashboard (index.js)	146.23KB	39.59KB
plugin-designer (index.js)	233.95KB	50.08KB
plugin-detail (index.js)	263.88KB	69.75KB
plugin-editor (index.js)	2.23KB	1.05KB
plugin-form (index.js)	180.28KB	46.60KB
plugin-gantt (index.js)	178.36KB	45.08KB
plugin-grid (index.js)	270.84KB	75.07KB
plugin-kanban (index.js)	59.42KB	18.48KB
plugin-list (index.js)	132.61KB	34.08KB
plugin-map (index.js)	27.07KB	8.96KB
plugin-markdown (index.js)	13.88KB	4.80KB
plugin-report (index.js)	46.66KB	13.13KB
plugin-timeline (index.js)	39.21KB	11.85KB
plugin-tree (index.js)	15.07KB	5.33KB
plugin-view (index.js)	93.43KB	23.94KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	12.07KB	3.68KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	120.23KB	39.46KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	4.50KB	2.06KB
react (schema-input.js)	4.31KB	2.07KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (body-dialect.js)	4.50KB	1.99KB
sdui-parser (codegen.js)	9.45KB	3.76KB
sdui-parser (dashboard-widget-options.js)	3.07KB	1.30KB
sdui-parser (index.js)	7.30KB	3.12KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	25.28KB	7.81KB
sdui-parser (provenance.js)	3.84KB	1.90KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	23.87KB	7.83KB
types (ai.js)	4.39KB	2.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	4.12KB	1.61KB
types (authoring-nodes.js)	0.20KB	0.19KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (cloud.js)	0.20KB	0.18KB
types (complex.js)	4.44KB	2.07KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (dashboard-widget-layout.js)	2.06KB	0.96KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (expression.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	1.13KB	0.65KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	5.78KB	2.70KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	5.00KB	2.39KB
types (navigation.js)	0.20KB	0.18KB
types (node-slots.js)	7.18KB	2.34KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	2.52KB	1.31KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-approval-decision.js)	0.20KB	0.20KB
types (record-components.js)	0.20KB	0.19KB
types (record-panels.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (select-option.js)	0.20KB	0.19KB
types (spec-report.js)	4.99KB	1.96KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (strict-authoring-face.js)	19.93KB	7.26KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	8.48KB	3.50KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped

[objectstack-fleet]

席位核对 · ACCEPT · domain:ui seat 1 · session_011K9g23W67dy2zwnyzaoB6o · 2026-10-16T20:42Z

What was reviewed:

• Head 6d50f33, against objectui#12751.
• The claim 6223385481, and the dev's report with the seat's answers on the card.
• Tier: TIER_DEFAULT, the seat's own review. Clause-②: no is on line 2 of the body and in the changeset. No prop, export, type member or key changes; usePrintPage is an existing @object-ui/react export.

1. Shape.
   • Fixes #12751 is the first line and the only closing keyword. The assignee is os-tesla.
   • 3 files, NOT governed (check-governed-merges --pr on this file list, 129 changed lines): DetailView.tsx, one new test and one @object-ui/plugin-detail patch changeset.
2. The change.
   • DetailView reads usePrintPage() !== null once, above every early return, the same way DetailSection reads it since PR fix(plugin-detail): a detail section on a print page prints every declared field and no "Show N empty fields" button #12729, so the hook order never depends on a branch.
   • The approval band's condition gains && !isPrintPage. On a print page none of it is drawn: the status badge, the recall button, the tally, the per-group ticks and the recall-error line. Off a print page the condition is unchanged.
   • H2 is answered as hide, by the spec's own print refusals: record:approvals and record:approval_decision show per-viewer, per-decision state, and record:path leaves the stage to record:details. An author who wants the approval status on paper prints the record's status field.
3. Tests and evidence.
   • 4 pins: two print rows (an editable and a locking approval draw no recall, no role=status, no progressbar, and the field still renders) and two controls off a print page. The ablation turns both print rows red and leaves both controls green; the restored blob equals HEAD.
   • packages/plugin-detail passes, 2682 tests. The 37 other files naming DetailView pass, 1784 tests. On the merged head, the three approval-band files pass, 28 tests.
   • Live against a published 18.0.0-next.2 backend, a throwaway A4 print page on showcase_invoice, printed to PDF on the record route and the named page route. Before: "In approval · editable", "Recall approval" and "Approvals — 0 of 1" on paper. After: only the record's fields. The PNGs are at 52726b6 on claude/issue-12751-evidence.
4. Gates (check-runs pinned to this head).
   • 33 success and 3 skipped (coverage and dependabot, skipped by design), including Lint, Type Check, Test with all 16 shards, Test (dist pins), Build & E2E, Bundle Analysis, Repo Gates, Governed Surface Queue Guard and every changeset check.
5. Recorded:
   • The invoice number missing from the same PDF is filed as objectui#12787 (record:details hides the title field for a page header that a print page refuses).
   • DetailView's own header (showHeader: true) and the auto-tabs strip have no print gate and no measured producer on a print page. Named in the body; no card.
6. Landing.
   • Ready, then auto-merge into the merge queue.
   • After the merge: verify by content, close the card through Fixes, strip pm:dispatched, and archive cloud session session_01F54KeYBZhaNDNQjYZJ3HmP.

---

Generated by Claude Code