Skip to content

feat(app-shell): Publish opens the pending-changes sheet to confirm, Changes opens it to review (objectui#12517) - #12595

Merged
objectstack-fleet[bot] merged 4 commits into
mainfrom
claude/issue-12517-publish-posture
Oct 16, 2026
Merged

feat(app-shell): Publish opens the pending-changes sheet to confirm, Changes opens it to review (objectui#12517)#12595
objectstack-fleet[bot] merged 4 commits into
mainfrom
claude/issue-12517-publish-posture

Conversation

@objectstack-fleet

@objectstack-fleet objectstack-fleet Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #12517
Clause-②: no

What changed

Target 3 — one sheet, one component, one prop. DraftChangesPanel takes posture, either review (the default) or confirm. The Studio keeps one changesPosture state beside changesOpen. Publish sets confirm and Changes sets review, each before opening, and the single DraftChangesPanel mount passes it. The Home page, DraftPreviewBar and CommitTimeline pass nothing and keep the review behaviour. Publish is still review-then-confirm (objectui#2261): the header click only opens the sheet, and only the footer's Publish all publishes.

Target 1 — Publish opens to confirm. When the list first arrives on each open, every row is expanded, a summary line above the list counts what the publish carries (for example 4 items · 2 object · 1 app · 1 page), and focus moves to Publish all. The line is built from the panel's existing per-type grouping, the one that draws the OBJECT · 2 headings, so there is no second classification. A row the author collapses stays collapsed while the rows classify. The seed runs in a layout effect, so no frame shows the list collapsed first.

Target 2 — Changes opens to review. Rows stay collapsed, focus lands on the list, and Publish all is in the footer, unfocused. There is no summary line.

Constraints kept. With nothing pending, Publish stays disabled and described by publish-none-reason (objectui#12303); on a read-only package the reason still rides its wrapper. studio-changes-count and the other test ids are unchanged. The objectui#12510 pin DraftChangesPanel.accessibleNames-12510 stays green.

New language-pack keys under preview.changes: summaryItems (with plural forms) and summaryType, in all ten locales.

Deviations

  • The type segments show the raw canonical type, the same token the group headings show (2 object), not a localized plural noun. The panel has no type-label table, and it sits on the console's eager graph, so it cannot import the metadata-admin one.
  • Publish all does not exist until the list loads, so focus starts on the list and moves to Publish all when the list arrives, unless the author has already moved it.
  • The confirm posture reads each draft's detail at open (two reads per row), because every row is expanded. The review posture still reads lazily on expand.

Screenshots

These are on the never-merged evidence branch claude/issue-12517-evidence, at a writable package with four drafts of three types, 1280 px wide.

Read from the DOM at capture, in both themes: confirm showed data-posture=confirm, four aria-expanded=true and active element draft-changes-publish; review showed data-posture=review, four aria-expanded=false and active element draft-changes-list.

Test evidence (head 737592f)

  • pnpm exec vitest run packages/app-shell/src/views/studio-design/StudioDesignSurface.: 82 files, 560 tests passed.
  • pnpm exec vitest run over every DraftChangesPanel*, DraftPreviewBar* and CommitTimeline* test, plus packages/i18n/: 98 files passed, 1413 tests passed, 13 skipped.
  • Full pnpm --filter @object-ui/app-shell test, once, on ad97f9d: 1427 files passed, 1 skipped; 13553 tests passed, 9 skipped; exit 0. One ru locale value and a merge of main came after this run. On 737592f only the two targeted batches above were re-run.
  • type-check for @object-ui/app-shell and @object-ui/i18n, build, check:i18n-keys, check:i18n-drift, check:i18n-designer-parity, check:new-line-citations and check-changeset-presence all exit 0. eslint on the touched files: 0 errors.
  • New pins: DraftChangesPanel.posture-12517.test.tsx (confirm, review, and a CONTROL for a host that passes no posture) and StudioDesignSurface.publishPosture-12517.test.tsx (which door passes which posture, and that nothing pending still leaves Publish disabled with its reason). Each was ablated once and went red: seeding moved back to a passive effect, the seed removed, and Publish set to review. Each was restored with git diff HEAD empty.

Acceptance notes

  • For a NEW object, the drill-in lists _packageId under Also changed. That is a framework key shown as the author's edit, the same shape as the read-decoration keys stripped earlier. It is reported to the seat, not fixed here.
  • In dark mode the New and Update badges keep their light fills. This is pre-existing polish, not in this card's scope.

Generated by Claude Code

claude added 4 commits October 15, 2026 23:10
@claude
feat(app-shell): Publish opens the pending-changes sheet to confirm, …
ac17a0f 
…Changes to review

DraftChangesPanel takes a `posture` prop. `confirm` expands every row
once the list arrives, puts a per-type summary line above it and moves
focus to Publish all; `review` (the default) keeps rows collapsed and
focus on the list. The Studio's Publish passes `confirm`, its Changes
button `review`; every other host passes nothing and keeps reviewing.

Claude-Session: https://claude.ai/code/session_01MxLBRTq32u4PebqJCjFXW7
Co-authored-by: Claude <noreply@anthropic.com>
@claude
fix(app-shell): seed the confirm posture's expansion before paint
ad97f9d 
The seed ran in a passive effect, so the commit that first rendered the
list painted it collapsed for a frame; a loaded test run read that frame.
Seed in layout effects, and pin that no collapsed row is ever observed.

Claude-Session: https://claude.ai/code/session_01MxLBRTq32u4PebqJCjFXW7
Co-authored-by: Claude <noreply@anthropic.com>
@claude
fix(i18n): give ru its own order for the confirm summary's type segment
459d12b 
The ru value was byte-identical to en, which the untranslated-identity
pin reads as a value never translated.

Claude-Session: https://claude.ai/code/session_01MxLBRTq32u4PebqJCjFXW7
Co-authored-by: Claude <noreply@anthropic.com>
@claude
Merge remote-tracking branch 'origin/main' into claude/issue-12517-pu…
737592f 
…blish-posture
@objectstack-fleet

objectstack-fleet Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

席位核对 — ACCEPT · objectui#12517 · head 737592f · 2026-10-16T01:27Z

Seat domain:ui#4, session session_01SJn1GEkrbbBQkhGC26wEDw. Checked against GitHub and the diff, not against the report (relayed on the card). The seat opened this PR from the dev's pr_title_draft and pr_body_draft (degraded channel); the body is the dev's, verbatim.

Checklist

  • Form: draft → main, assignee os-sales. The first line is Fixes #12517, and the next line is exactly Clause-②: no. git merge-tree against current main (ae923ec) is clean. The branch carries a merge commit of origin/main (1b3b5b1) and no rewrite.
  • Sibling: feat(app-shell): Studio home returns to the Studio landing; the two Setup exits say so #12590 (objectui#12513) does not conflict with this PR. The only conflict in a three-way stack is feat(app-shell): Studio home returns to the Studio landing; the two Setup exits say so #12590's own import line against objectui#12524, now on main, which feat(app-shell): Studio home returns to the Studio landing; the two Setup exits say so #12590's follow-up round resolves.
  • Diff:
    • DraftChangesPanel.tsx gets a posture prop ('review' | 'confirm', default review).
      • On open: a layout effect resets the expansion.
      • On the first list arrival of that open: a second layout effect seeds every row in confirm and moves focus to Publish all, only if the author has not moved it.
      • onOpenAutoFocus puts focus on the labelled list in place of the close button.
      • The summary line is built from the existing byType grouping.
    • StudioDesignSurface.tsx: a changesPosture state beside changesOpen. Publish sets confirm, Changes sets review, and the one mount passes it. The footer button stays the only publisher (objectui#2261), and objectui#12303's disabled-with-reason Publish is unchanged.
    • New preview.changes.summaryItems / summaryType keys in all ten locale packs, so @object-ui/i18n is in the changeset.
  • Tests:
    • New files: DraftChangesPanel.posture-12517 (5 tests, with a CONTROL for a host that passes no posture) and StudioDesignSurface.publishPosture-12517 (4 tests).
    • Ablations: three, each turned red.
    • The flake it caught: one collapsed frame before the expansion. It was a real defect, fixed with a layout effect and pinned with a MutationObserver.
    • Suites: the 82 StudioDesignSurface.* files and 98 panel and i18n files pass on 737592f. The full app-shell suite passed on ad97f9d (13553 tests); CI runs it on this head's merge ref.
  • Changeset: user-facing prose; minor for @object-ui/app-shell and @object-ui/i18n, which suits a new prop and new keys.
  • Contract faces: none. posture is an optional prop with the old behaviour as its default.
  • Screenshots: both postures in light and dark, with the DOM read at capture (data-posture, aria-expanded, the active element), on the never-merged claude/issue-12517-evidence (a4de5c7). The seat sent them to the maintainer at 2026-10-16T01:27Z.
  • CI on 737592f: running at this record. Landing waits for green.

Rulings on the open questions, deviations and findings

  1. The summary line's type segments use the raw canonical token: A. It is the same token the group headings above it already show, and there is no second classification. A localized plural-noun table would be a new label surface with one reader (axis 4).
  2. The contract notes (degraded channel, the lock path in this container, the model-free trailers): A.
  3. Footprint beyond the claim's wording (the import line, the ten locale packs, and two detail reads per row in confirm): A, accepted. Each is the smallest change that meets target 1.
  4. Focus in the other hosts: with no prop they get the review posture, which now puts focus on the labelled list at open where Radix used to pick the close button. That is the review posture as the card defines it (target 2), applied the same way in every host. Accepted, and recorded.
  5. Focus reaches Publish all when the list arrives, not at the instant of open: accepted. The button does not exist before then.
  6. The registry stamp _packageId listed under "Also changed" for a new object (class a): filed as Pending-changes drill-in lists the registry stamp _packageId under "Also changed" for a new object draft, as if the author had added it #12594, deduped, with the producer question (the spec's METADATA_READ_DECORATIONS) left to its owners. No panel-side filter.
  7. The light New and Update badges in dark mode: noted, not filed; pre-existing polish.

Implemented-by: cloud session session_01MxLBRTq32u4PebqJCjFXW7, branch claude/issue-12517-publish-posture
Reviewed-by: seat domain:ui#4, session_01SJn1GEkrbbBQkhGC26wEDw

Generated by Claude Code

@objectstack-fleet objectstack-fleet Bot mentioned this pull request Oct 16, 2026
Closed
@github-actions

github-actions Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 70 chunks) 3092.0 KB 3119.4 KB
Main entry chunk (gzip) 73.3 KB 350 KB
Entry file index-BNSW5VNy.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.19KB 7.76KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 596.60KB 143.79KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.20KB 69.22KB
fields (index.js) 283.09KB 72.13KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.67KB 11.85KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 201.89KB 48.13KB
plugin-dashboard (index.js) 145.69KB 39.39KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 262.91KB 69.49KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.83KB 46.61KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 262.82KB 72.91KB
plugin-kanban (index.js) 53.23KB 16.71KB
plugin-list (index.js) 129.82KB 33.09KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 93.43KB 23.94KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet objectstack-fleet Bot mentioned this pull request Oct 16, 2026
Merged
@objectstack-fleet

objectstack-fleet Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Landing · head 737592f · 2026-10-16T01:39Z

  • Checks on 737592f: 34 success, plus 3 expected skips (dependabot, Test (coverage), Test (coverage shard …)). Nothing is red. The 16 test shards carry the full @object-ui/app-shell suite on this head's merge ref, which closes the report's declared narrowing (its local full run was on ad97f9d).
  • Mergeable: yes (clean). git merge-tree against current main (7b5e558) is clean. The queue's merge group runs the full CI on the combined tree.
  • Sibling: feat(app-shell): Studio home returns to the Studio landing; the two Setup exits say so #12590 (objectui#12513) is in the same shell header, in other elements, and its stack with this PR is clean in either order.
  • Path surface: no governed path; Governed Surface Queue Guard is green. The ACCEPT 6205929525 lists the files.
  • Nothing has been posted since the ACCEPT: no review, no review comment and no objection.
  • Action: mark it ready for review, then enable auto-merge through the merge queue. Fixes #12517 closes the card on merge.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 16, 2026 01:40
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 16, 2026 01:40
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit 92c2a69 Oct 16, 2026
38 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-12517-publish-posture branch October 16, 2026 01:52
This was referenced Oct 16, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@os-sales os-sales

Labels

package: app-shell package: i18n tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Publish opens the pending-changes sheet in a confirmation posture; Changes opens it in review posture

2 participants

@os-sales @claude