fix(app-shell): the pending-changes drill-in no longer lists the protection envelope as authored keys (objectui#12594)

[objectstack-fleet]

Fixes #12594
Clause-②: no

What changed

Expanding a NEW object draft in the pending-changes sheet listed the registry stamp _packageId under "Also changed:" as if the author had typed it. computeChangeDetail in packages/app-shell/src/preview/DraftChangesPanel.tsx now removes the ADR-0010 protection envelope from both bodies before it compares them. The keys are read from the spec's MetadataProtectionFields via Object.keys, with no local list. Every list the drill-in renders (fields added, changed and removed; keys added, changed and removed) and the no-change mark read that one envelope-free pair.

The fetched bodies keep the envelope. fetchItemBody also feeds the security-posture lint and the member-existence probe, and the lint's docblock says the envelope stays on its input. So the strip sits at the diff seam, not in unwrapItem. Nothing served or saved changes: no producer route, and no addition to METADATA_READ_DECORATIONS, per the triage grade.

Option chosen: (a), every envelope key left out of the diff

Measured before choosing:

• The spec does not split the envelope into registry stamps and loader-declared lock keys. MetadataProtectionFields is one flat shape. The split exists only inside objectstack's metadata-protocol (DERIVED_PROVENANCE_KEYS against the lock family) and is not exported, so no local split was invented.
• No draft can change a lock. On a local HotCRM backend, a draft PUT that sets _lock: full is refused with 400 VALIDATION_ERROR ("the metadata API never sets, changes or removes a lock", ADR-0010 section 3.5).

Four axes:

• Real business need: a separate line for an envelope change (option b) would render for a flow that does not exist.
• Long-term soundness: the panel reads the spec's own declaration, the same derivation rule the read-decoration strip follows.
• AI error resistance: the lock contract is enforced loudly at the save door, not by consumer tolerance.
• Startup focus: no new label, i18n key or test surface for an unexercised flow.

Screenshots (new object draft expanded; local HotCRM backend, package created through POST /api/v1/packages)

Before, on main (_packageId listed under Also changed):

• https://github.com/objectstack-ai/objectui/blob/b75c910b2d764eb0ffde280f702ab77888eae416/docs/design/studio-redesign/findings/12594/12594-before-new-object-light.png?raw=true
• https://github.com/objectstack-ai/objectui/blob/b75c910b2d764eb0ffde280f702ab77888eae416/docs/design/studio-redesign/findings/12594/12594-before-new-object-dark.png?raw=true

After (gone; label, name, nameField, sharingModel and the fields still list):

• https://github.com/objectstack-ai/objectui/blob/b75c910b2d764eb0ffde280f702ab77888eae416/docs/design/studio-redesign/findings/12594/12594-after-new-object-light.png?raw=true
• https://github.com/objectstack-ai/objectui/blob/b75c910b2d764eb0ffde280f702ab77888eae416/docs/design/studio-redesign/findings/12594/12594-after-new-object-dark.png?raw=true

Tests (at 16a2796)

• New pin DraftChangesPanel.protectionEnvelope-12594.test.tsx, 5 tests, green. It checks that:

  • a NEW object's drill-in lists no MetadataProtectionFields key, with label and a field still listed as controls;
  • the CONTROL _unpublished, a key AppSchema declares outside the envelope, still lists;
  • an UPDATE that differs only in the envelope reads "No differences detected";
  • computeChangeDetail drops the envelope in both directions.

  The fixtures carry every key Object.keys(MetadataProtectionFields) names.

• Targeted reach set, green: every DraftChangesPanel, DraftPreviewBar and CommitTimeline test, plus every test that mounts DraftChangesPanel, including the objectui#12510, objectui#12517 and objectui#8181 pins. Test Files 42 passed (42), Tests 265 passed (265).

• Ablation, removing the strip: 4 of 5 red (the spec-read guard stays green as designed). Restored; git diff HEAD empty.

• Ablation, replacing the strip with an underscore-prefix filter: exactly the CONTROL test goes red. Restored; git diff HEAD empty.

• @object-ui/app-shell type-check (the test project lists the new file), build, and eslint on the touched files all pass (0 errors; the warnings are pre-existing). check:i18n-keys, check:i18n-drift, check-changeset-presence, check-spec-symbol-derivation and check:new-line-citations all exit 0.

• Full app-shell suite: not measured locally (the run was lost to a worker restart); CI runs it.

Acceptance notes

• Card acceptance 2 (a pin at the producer) is superseded by the triage grade, which keeps the producer unchanged. The pin lives at the panel's diff seam instead.
• The spec declares no top-level underscore key that an author types (the authoring-key lint treats every underscore key as the tooling channel). The underscore CONTROL is therefore _unpublished, a spec-declared machine-managed key outside the envelope.
• Observation, not filed: a NEW object's field list also shows the system fields the draft read serves (created_at, owner_id and so on). Those are real fields the published object gets.

Session: https://claude.ai/code/session_016v3WXCXoatAw13mUAHxwJB

---

Generated by Claude Code

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 70 chunks)	3092.1 KB	3119.4 KB
Main entry chunk (gzip)	73.3 KB	350 KB
Entry file	index-D1ta52ZE.js	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	21.19KB	7.76KB
app-shell (runtime-config.js)	22.59KB	7.89KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.11KB	3.87KB
auth (ActiveOrganizationStorage.js)	27.95KB	10.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	40.22KB	10.61KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.15KB	5.40KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.72KB	2.24KB
auth (SocialSignInButtons.js)	9.70KB	3.93KB
auth (UserMenu.js)	3.39KB	1.21KB
auth (auth-gate-events.js)	1.62KB	0.83KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	41.19KB	11.12KB
auth (createAuthenticatedFetch.js)	8.54KB	3.46KB
auth (index.js)	3.63KB	1.64KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	11.08KB	4.58KB
collaboration (CommentThread.js)	27.26KB	8.03KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.28KB	2.60KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (commentAuthorship.js)	1.39KB	0.78KB
collaboration (index.js)	1.93KB	0.85KB
collaboration (useCollaborationTranslation.js)	6.50KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	596.60KB	143.79KB
core (index.js)	10.18KB	4.04KB
create-plugin (index.js)	27.94KB	9.51KB
data-objectstack (index.js)	248.20KB	69.22KB
fields (index.js)	283.13KB	72.14KB
i18n (LocalizationContext.js)	2.92KB	1.42KB
i18n (builtinAggregateLabels.js)	0.86KB	0.49KB
i18n (currency.js)	2.59KB	1.22KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	8.87KB	3.64KB
i18n (index.js)	5.52KB	2.39KB
i18n (pickLocalized.js)	9.86KB	3.95KB
i18n (provider.js)	39.35KB	12.88KB
i18n (translateFn.js)	0.20KB	0.18KB
i18n (useDisplayLocale.js)	3.52KB	1.76KB
i18n (useObjectLabel.js)	36.87KB	9.88KB
i18n (useSafeTranslation.js)	7.14KB	2.92KB
layout (index.js)	40.67KB	11.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.99KB	0.87KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	6.62KB	2.45KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useSpecGesture.js)	5.52KB	2.10KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	15.35KB	5.51KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	6.82KB	2.38KB
permissions (discardProofCache.js)	1.04KB	0.55KB
permissions (evaluator.js)	8.33KB	3.07KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	4.83KB	2.27KB
plugin-ai (index.js)	16.04KB	3.92KB
plugin-calendar (index.js)	54.94KB	16.05KB
plugin-charts (index.js)	84.97KB	23.36KB
plugin-chatbot (index.js)	201.89KB	48.13KB
plugin-dashboard (index.js)	145.69KB	39.39KB
plugin-designer (index.js)	233.95KB	50.08KB
plugin-detail (index.js)	262.91KB	69.49KB
plugin-editor (index.js)	2.23KB	1.05KB
plugin-form (index.js)	180.88KB	46.69KB
plugin-gantt (index.js)	178.36KB	45.08KB
plugin-grid (index.js)	262.82KB	72.91KB
plugin-kanban (index.js)	53.23KB	16.71KB
plugin-list (index.js)	129.82KB	33.09KB
plugin-map (index.js)	27.07KB	8.96KB
plugin-markdown (index.js)	13.88KB	4.80KB
plugin-report (index.js)	46.66KB	13.13KB
plugin-timeline (index.js)	39.21KB	11.85KB
plugin-tree (index.js)	15.07KB	5.33KB
plugin-view (index.js)	93.43KB	23.94KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	12.07KB	3.68KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	120.63KB	39.56KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	4.50KB	2.06KB
react (schema-input.js)	4.31KB	2.07KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (body-dialect.js)	4.50KB	1.99KB
sdui-parser (codegen.js)	9.45KB	3.76KB
sdui-parser (dashboard-widget-options.js)	3.07KB	1.30KB
sdui-parser (index.js)	7.30KB	3.12KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	25.28KB	7.81KB
sdui-parser (provenance.js)	3.84KB	1.90KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	23.87KB	7.83KB
types (ai.js)	4.39KB	2.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	4.12KB	1.61KB
types (authoring-nodes.js)	0.20KB	0.19KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (cloud.js)	0.20KB	0.18KB
types (complex.js)	4.44KB	2.07KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (dashboard-widget-layout.js)	2.06KB	0.96KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (expression.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	1.13KB	0.65KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	5.78KB	2.70KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	5.00KB	2.39KB
types (navigation.js)	0.20KB	0.18KB
types (node-slots.js)	7.18KB	2.34KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	2.52KB	1.31KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-approval-decision.js)	0.20KB	0.20KB
types (record-components.js)	0.20KB	0.19KB
types (record-panels.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (select-option.js)	0.20KB	0.19KB
types (spec-report.js)	4.99KB	1.96KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (strict-authoring-face.js)	19.93KB	7.26KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	8.48KB	3.50KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped

[objectstack-fleet]

席位核对 — ACCEPT · objectui#12594 · head 16a2796 · 2026-10-16T02:55Z

Seat domain:ui#4, session session_01SJn1GEkrbbBQkhGC26wEDw. Checked against GitHub and the diff, not against the report (relayed on the card). The seat opened this PR from the dev's pr_title_draft and pr_body_draft (degraded channel); the body is the dev's, verbatim.

Checklist

• Form: draft → main, assignee os-sales. The first line is Fixes #12594, and the next line is exactly Clause-②: no. git merge-tree against current main (8415d9f) is clean. Two commits (c06d7be, 16a2796), no rewrite.
• Sibling: none in flight from this seat. Studio: controls without an accessible name (records toolbar, flow nodes, sheets, landing cards) #12510's, Publish opens the pending-changes sheet in a confirmation posture; Changes opens it in review posture #12517's and Three other draft-envelope consumers take getDraft().item verbatim, with no read-decoration strip #8181's DraftChangesPanel pins are in the dev's reach set (42 files, 265 tests, green).
• Diff:
  • DraftChangesPanel.tsx: PROTECTION_ENVELOPE_KEYS = Object.freeze(Object.keys(MetadataProtectionFields)) from @objectstack/spec/kernel, the subpath the panel already imports stripReadDecorations from. No local key list.
  • withoutProtectionEnvelope copies the body and deletes those keys. It never mutates the fetched body.
  • computeChangeDetail strips both sides before it compares, so the field lists, the key lists and the no-change mark all read one envelope-free pair. That is the "one change point for every list" the dispatch asked for.
  • unwrapItem is unchanged apart from its docblock. The body it returns keeps the envelope, because the security-posture lint and the member-existence probe read the same body as served. The old docblock line ("a real change to one of them IS a change this diff should report") is replaced, matching the ruling below.
• Tests:
  • New file DraftChangesPanel.protectionEnvelope-12594.test.tsx, 5 tests:
    • a guard that the spec's envelope is non-empty;
    • a NEW object lists no envelope key, with label and a field still listed;
    • the CONTROL _unpublished still lists;
    • an UPDATE that differs only in the envelope reads "No differences detected";
    • computeChangeDetail drops the envelope in both directions.
  • Two ablations, each restored to the HEAD blob:
    • With the strip removed, 4 of 5 go red.
    • With the strip replaced by an underscore-prefix filter, exactly the CONTROL goes red, so the CONTROL can fail.
  • The full app-shell suite was not measured locally (the run was lost to a worker restart). CI runs it on this head.
• Changeset: @object-ui/app-shell patch, user-facing prose. Patch suits a display fix with no API change.
• Contract faces: none. Nothing served or saved changes: no producer route and no METADATA_READ_DECORATIONS change, per the triage grade (6206274674).
• Screenshots: a new object draft expanded, before and after, in light and dark, on the never-merged claude/issue-12594-evidence (b75c910). The seat read all four: + _packageId sits under "Also changed:" on main and is absent on this branch, while label, name, nameField, sharingModel and the fields still list. Sent to the maintainer at 2026-10-16T02:55Z.
• CI on 16a2796: running at this record. Landing waits for green.

Rulings on the open questions, deviations and findings

1. The open choice: (a), every envelope key left out of the diff. On the four axes:

   • Real business need. The card's defect is a stamp listed as an authored edit. No real flow moves a lock through a draft: the save door refuses a draft PUT that sets _lock with 400 VALIDATION_ERROR (ADR-0010 §3.5), which the dev measured live. A separate envelope line (b) would render for a flow that does not exist.
   • Long-term soundness. The keys come from the spec's own declaration, the same derivation rule the read-decoration strip already follows. A split between registry stamps and lock keys (c) would fork a classification the spec does not export.
   • AI error resistance. The lock contract is enforced loudly at the save door, not by a tolerant consumer. A future spec key joins the strip with no edit here.
   • Startup focus. No new label, i18n key or test surface for an unexercised flow.

   If ADR-0010's later phases let a draft move a lock, (b) is a small follow-up on this same seam.

2. The strip sits in computeChangeDetail, not unwrapItem: accepted. The dispatch's assumption 1 named unwrapItem as the place where the keys survive, and that holds. Stripping there would change what the lint and the probe read.

3. Card acceptance 2 (a pin at the producer) is superseded by the triage grade, which keeps the producer unchanged. The pin lives at the panel's diff seam.

4. The contract notes (degraded channel; the feature worktree left until the PR opens; the shared checkout's stale local branch deleted): A.

5. Observations, not filed: agreed.

   • A new object's field list also shows the system fields the draft read serves (created_at, owner_id and so on). It is noisy, but true: the published object gets those fields.
   • FieldSchema also spreads the envelope, and the strip is top-level only. A served draft's fields carry no envelope key today, so nothing lists. The spec-derived key list covers it if a field ever does.

Implemented-by: cloud session session_016v3WXCXoatAw13mUAHxwJB, branch claude/issue-12594-drill-in-envelope-keys
Reviewed-by: seat domain:ui#4, session_01SJn1GEkrbbBQkhGC26wEDw

---

Generated by Claude Code

[objectstack-fleet]

Landing · head 16a2796 · 2026-10-16T03:07Z

• Checks on 16a2796: 33 success, plus 3 expected skips (dependabot, Test (coverage), Test (coverage shard …)). Nothing is red. The 16 test shards carry the full @object-ui/app-shell suite on this head's merge ref, which closes the report's declared narrowing (its local full run was lost to a worker restart). Two path-filtered checks that ran on feat(app-shell): Publish opens the pending-changes sheet to confirm, Changes opens it to review (objectui#12517) #12595 (Spec Main Shape Gate, Close issues referenced in other repositories) were not triggered by this diff.
• Mergeable: yes (clean). git merge-tree against current main (8415d9f) is clean. The queue's merge group runs the full CI on the combined tree.
• Sibling: none in flight from this seat.
• Path surface: no governed path; Governed Surface Queue Guard is green. The ACCEPT 6206996162 lists the files.
• Nothing has been posted since the ACCEPT: no review, no review comment and no objection.
• Action: mark it ready for review, then enable auto-merge through the merge queue. Fixes #12594 closes the card on merge.

---

Generated by Claude Code