Skip to content

chore(ui-tooling): drop the changeset polarity census's test and fixture corpus (slice 4 of #25920) - #26098

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-slsqxn
Oct 26, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-slsqxn

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Elon · project thread

Part of #25920 — slice 4 of the unwired-tooling cleanup (slices 1–3: #26004, #26024, #26057). The card stays open.

Summary

Deletions only: 17 files, −1,654 lines, on main b63fdf7.

  • ui/scripts/__tests__/changeset-polarity-census.test.ts + its fixture corpus ui/scripts/__tests__/fixtures/changeset-polarity/ → delete. They pin changeset-polarity-census.mjs, the instrument for objectui#9727, which closed after the rebuild. No gate, workflow or document runs the census or its test.
  • ui/scripts/markdown-test-inputs.mjs: the test's row (and its comment) goes with it, so the markdown-input inventory stays exact.

The census script itself and its census:changeset-polarity alias (−1,882) follow in the next slice: the two together would cross the 3,000-line single-PR threshold.

Verification (head 2c26b8a)

  • Exact-name git grep across the whole tree for the test and the fixture path: the only hit left is the census script's own header comment, which goes in the next slice. Nothing in AGENTS.md, skills/** or .claude/** names either.
  • ui suites that read the scripts inventory and manifest (markdown-test-inputs, package-scripts-vitest-projects, check-unreferenced-sources, vitest-invocation-guard): 4 files, 107 tests passed. (ci-cd-pipeline-doc.test.ts, run on earlier slices, was retired on main by ci(ui-merge): delete objectui's nested workflows and Dependabot config; retire the action-ref scan and the CI page pin test with them #26058.)
  • check:unreferenced-sources, check:test-path-roots, check-ci-filter-parity and its --self-test: exit 0. check:commit-card-trailers: exit 0.
  • dispatch-gates --commands families: per-family exit codes in the report on the card.
  • No changeset: private ui tooling only.

Generated by Claude Code

🤖 Generated with Claude Code

https://claude.ai/code/session_012eXtKYmXEnCc1GExP4go12

…ure corpus

First half of retiring ui/scripts/changeset-polarity-census.mjs, a report-only
census whose card closed once the instrument was rebuilt; no gate or workflow
runs it. Its test, the fixture corpus under
scripts/__tests__/fixtures/changeset-polarity/ and the markdown-test-inputs
row for that test go here; the script and its alias follow in the next PR
(the two halves together exceed the 3,000-line human-merge threshold).

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012eXtKYmXEnCc1GExP4go12
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 26, 2026
@github-actions github-actions Bot added size/xl documentation Improvements or additions to documentation tests labels Oct 26, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 — ACCEPT at 2c26b8af

Seat review of #26098, slice 4 of #25920 (devx seat #6023).

  • Deletions only: 17 files, −1,654. Not governed. Under the 3,000-line human-merge threshold, which is why the 3,525-line census removal was split in two.
  • What goes: the changeset-polarity census test, its fixture corpus (corpus, dependency, types, workspace) and its markdown-test-inputs.mjs row. Its card objectui#9727 is closed, and the instrument was rebuilt by objectui PR IEmailService JSDoc claims alignment with a CoreServiceName 'email' member that does not exist #9752.
  • The in-between state is sound. The script and its census:changeset-polarity alias stay until slice 5. The script's default --corpus is the repository's .changeset and reads none of the deleted fixtures, so the alias still runs.
  • CI at 2c26b8af: 46 success, 13 skipped, 0 failed, and Test UI 1–16 green. skip-changeset is set. Contract review is not triggered.

Landing: pr_ready + automerge_enable now, under the maintainer's standing grant. #25920 stays open for slices 5 and 6.

Card: #25920


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/xl skip-changeset PR has no user-facing published change; bypasses the changeset gate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants