Repository navigation
chore(ui-tooling): drop package tsconfig keys that restate the root's value (slice 6 of #25920) - #26139
Merged
Conversation
42 package tsconfigs that extend ui/tsconfig.json restated `"jsx": "react-jsx"` (42) and `"skipLibCheck": true` (24) with exactly the root's value. Removing them changes no effective config: `tsc -p <file> --showConfig` is byte-identical before and after for all 78 package tsconfigs. Kept on purpose: - `"noEmit": true` in tsconfig.test.json / tsconfig.typetests.json / tsconfig.examples.json: check-type-check-coverage requires it to be stated in the file, and the checking-project convention states it. - packages/cli module/target/moduleResolution/resolveJsonModule: that config emits the CLI, so its emit settings stay pinned locally. - baseUrl + `"@/*"` paths: not root-equal in effect (a child `paths` replaces the root's, and removing it would expose the root's @object-ui/* source paths with a different baseUrl). Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012eXtKYmXEnCc1GExP4go12
Contributor
Author
席位核对 — ACCEPT at
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elon · project thread
Part of #25920 — slice 6, the card's tsconfig dedupe (slices 1–5: #26004, #26024, #26057, #26098, #26107).
Summary
42 files, +24 / −90, on
main95294be. No effective configuration changes.42 package tsconfigs that extend
ui/tsconfig.jsonrestated root values exactly:"jsx": "react-jsx"in 42 files and"skipLibCheck": truein 24. Both keys are removed. The 24+lines only move a trailing comma when the removed key was the last entry incompilerOptions.Proof the edit is mechanical:
tsc -p <file> --showConfigoutput is byte-identical before and after for all 78 trackedui/packages/*/tsconfig*.json. TypeScript 6.0.3 resolves the fullextendschain, and every resolved option and file list matches.Kept on purpose
These are root-equal or close to it, but are not mechanical to drop:
"noEmit": trueintsconfig.test.json,tsconfig.typetests.jsonandpackages/types/tsconfig.examples.json.check-type-check-coverage.mjschecks these files' text for"noEmit": true, so the key must stay written in the file. The checking-project convention, stated in their comments, also writes it explicitly.packages/climodule/target/moduleResolution/resolveJsonModule. That config emits the CLI. Its emit settings stay pinned locally so they don't follow a later change to the root.baseUrl+"paths": { "@/*": ["src/*"] }in 24 packages. Not equal to the root in effect. A childpathsreplaces the root's, so removing it would expose the root's@object-ui/*→srcpaths, resolved against the root'sbaseUrl. Checked with--showConfigonplugin-map: the effective config changes.Verification (head bad0f29)
--showConfigidentity: 78 of 78 configs identical, measured on this base.check-type-check-coverage,check-published-tsconfig-tooling-exclude,check-unreferenced-sourcesandcheck-test-path-rootsall exit 0.check-node-esm-loadgives the same result before and after: its specifier leg passes, and its load leg stops at a localpnpm buildthat this environment cannot run.dispatch-gates --commandsfamilies: per-family exit codes are in the report on the card.check:commit-card-trailers: exit 0.Generated by Claude Code
🤖 Generated with Claude Code
https://claude.ai/code/session_012eXtKYmXEnCc1GExP4go12