Skip to content

test(ui-e2e): delete the vacuous MSW worker test and the unused msw declarations #26032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 1 commit into from
Oct 26, 2026
Merged

test(ui-e2e): delete the vacuous MSW worker test and the unused msw declarations #26032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 45 additions & 26 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions ui/apps/console/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,3 @@ plugin.d.ts
*.sln
*.sw?

# MSW
public/mockServiceWorker.js
18 changes: 0 additions & 18 deletions ui/e2e/console-rendering.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,22 +67,4 @@ test.describe('Console Rendering', () => {
const childCount = await root.evaluate((el) => el.children.length);
expect(childCount, 'React did not mount on deep route').toBeGreaterThan(0);
});

test('should include the MSW service worker in the build output', async ({ page }) => {
// The mock server requires mockServiceWorker.js to be served from /public.
// If it's missing, the app may hang during bootstrap.
const response = await page.request.get(`${CONSOLE_BASE}/mockServiceWorker.js`);

// In production builds without MSW, the asset may be absent. The static
// server returns the SPA fallback (index.html) for unknown paths, which
// is a 200 with `text/html`. Treat that as "MSW not bundled" and skip.
if (response.ok()) {
const contentType = response.headers()['content-type'] || '';
if (contentType.includes('text/html')) {
// SPA fallback — mockServiceWorker.js is not bundled in this build.
return;
}
expect(contentType).toContain('javascript');
}
});
});
6 changes: 0 additions & 6 deletions ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@
"globals": "^17.11.0",
"happy-dom": "^20.11.2",
"jsdom": "^29.1.1",
"msw": "^2.15.0",
"playwright": "^1.62.1",
"react": "19.3.0",
"react-dom": "19.3.0",
Expand All @@ -177,10 +176,5 @@
"vitest-axe": "^0.1.0",
"wait-on": "^9.5.1",
"yaml": "^2.9.0"
},
"msw": {
"workerDirectory": [
"public"
]
}
}
1 change: 0 additions & 1 deletion ui/packages/plugin-form/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
"@object-ui/data-objectstack": "workspace:*",
"@object-ui/test-support": "workspace:*",
"@vitejs/plugin-react": "^6.0.5",
"msw": "^2.15.0",
"typescript": "^6.0.3",
"vite": "^8.2.1",
"vite-plugin-dts": "^5.0.3"
Expand Down
1 change: 0 additions & 1 deletion ui/packages/plugin-grid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"@objectstack/spec": "workspace:^",
"@tailwindcss/postcss": "^4.3.3",
"@vitejs/plugin-react": "^6.0.5",
"msw": "^2.15.0",
"postcss": "^8.5.26",
"tailwindcss": "^4.3.3",
"typescript": "^6.0.3",
Expand Down
Loading
Loading