Repository navigation
test(ui-e2e): delete the vacuous MSW worker test and the unused msw declarations - #26032
Merged
Merged
Conversation
…eclarations The console-rendering spec's "should include the MSW service worker in the build output" returned without asserting whenever mockServiceWorker.js was missing, and it is missing: the console ships no worker. msw itself was declared in the ui root, plugin-form and plugin-grid with no importer, plus a generated worker under ui/public and a console .gitignore entry for it. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ATRAHgc6RT4GLFAL1N5Zfy
Contributor
Author
席位核对 — ACCEPT at
|
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elon · project thread
Part of #25914 — the in-scope half (triage 2026-10-24: "delete the vacuous MSW test"). The card stays open for the items left to the maintainer, listed at the end.
Clause-②: no
Metadata-protocol: none
Summary
Re-measured on
main88531fa:ui/apps/console/public/mockServiceWorker.jsdoes not exist, soui/e2e/console-rendering.spec.ts"should include the MSW service worker in the build output" always took its silentreturn(SPA fallback servedtext/html) and asserted nothing. Deleted.msw: it was still declared inui/package.json(devDependency plus the"msw": { "workerDirectory": ["public"] }block),ui/packages/plugin-formandui/packages/plugin-grid(devDependencies).git grepfor'msw',msw/*,setupServer,setupWorkeroutside the lockfile finds no importer in code; the only hit is the example snippet inui/skills/objectui/guides/testing.md, which is consumer guidance and imports nothing here. Removed, together with the generated workerui/public/mockServiceWorker.jsthat theworkerDirectoryblock produced and the console.gitignoreentry for a worker nothing generates any more.pnpm-lock.yamlregenerated withpnpm install --lockfile-only: the three importer entries go;msw@2.15.0stays in the lock as an optional peer of another package, so its transitive entries flip tooptional: truerather than disappearing.Verification (head d1dc66c)
dispatch-gates --commandsderived 42 families;--ranreconciliation: 42 derived, 38 run (all exit 0), 4 NOT MEASURED (exit 3, need whole-treedist/:check:dts-closure,check:dual-build-cjs-loads,check:lean-entry-closure,check:sourcemap-no-sources-content), 0 UNRUN. CI's Build/Lint lanes own those four.pnpm install --frozen-lockfileagainst the new lock: exit 0.check-test-completenessreads vitest logs only):playwright test --list --project=chromium→ 77 tests in 12 files (one fewer thanmain);console-rendering.spec.tslists its remaining 3 tests.check:commit-card-trailers --range origin/main..HEADgreen.Left for a maintainer ruling (out of scope here)
test:e2e:live:ci) a required check — a new gate.live-e2e.yml) from every PR to daily only — a governed workflow change.Noticed, not changed
ui/apps/console/vercel.jsonstill excludesmockServiceWorker.jsfrom its SPA rewrite; harmless, left as deploy config.ui/.claude/skills/objectui-contributor/guides/console-development.mdstill tells contributors to start a mock API with@objectstack/plugin-msw, whichdocs/upgrading-to-11.mdsays was removed.console-rendering.spec.ts's console-error filter still ignoresMSW/mockServiceWorkermessages; inert, left alone.Generated by Claude Code
🤖 Generated with Claude Code
https://claude.ai/code/session_01ATRAHgc6RT4GLFAL1N5Zfy