Repository navigation
fix(i18n): localise the console's round-3 leftovers — data table titles, chart fallback, react pages, References columns, Flow Runs diagnostics - #25978
Merged
Conversation
Claude-Session: https://claude.ai/code/session_01C6T942afhqAP5w9XBmfTDC Co-authored-by: Claude <noreply@anthropic.com>
…trols (#25916) Claim-free WIP on the card branch. Claude-Session: https://claude.ai/code/session_01C6T942afhqAP5w9XBmfTDC Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C6T942afhqAP5w9XBmfTDC Co-authored-by: Claude <noreply@anthropic.com>
…25916) Claude-Session: https://claude.ai/code/session_01C6T942afhqAP5w9XBmfTDC Co-authored-by: Claude <noreply@anthropic.com>
…round-3 copy edits (#25916) The manifest's content is unchanged (106 components); only the hash of the registry sources it was generated from moved, because data-table.tsx and react-page.tsx are registry sources. Claude-Session: https://claude.ai/code/session_01C6T942afhqAP5w9XBmfTDC Co-authored-by: Claude <noreply@anthropic.com>
…d-3 locale pin (#25916) react-hooks/static-components refused the in-render registry lookup. Claude-Session: https://claude.ai/code/session_01C6T942afhqAP5w9XBmfTDC Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
席位核对 · ACCEPT · seat
|
2 tasks
This was referenced Oct 26, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 26, 2026
Resolve the scripts/sdui-manifest.record.json conflict with #25977 by regenerating the record with node scripts/gen-sdui-manifest-node.mjs. Claude-Session: https://claude.ai/code/session_01C6T942afhqAP5w9XBmfTDC Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Steve · project thread
Part of #25916
Clause-②: no
Metadata-protocol: none
Third pass on the card's leftover list (the second pass's hand-back, comment 6407864045), under claim 6410094565. Implemented by the card-thread session
https://claude.ai/code/session_01C6T942afhqAP5w9XBmfTDC.What changes
data-table(components)table.openRecord,table.cancelChanges,table.saveRow(also in the renderer's provider-less defaults table)ObjectView.tsx, Loading-chart region only)chart.loadingrowkind:'react'page renderer (react-page.tsx, not(before)reactPage.*(new namespace, six rows)ResourceEditPage.tsx)engine.edit.refsColFromType,refsColFromName,refsColPathin the Studio's ownengine.*table (en-US + zh-CN), per the carve-out the first pass usedFlowRunsPage.tsx)console.developer.flowRuns.clientMethodUnavailable(method interpolated). A message the call threw is still drawn verbatimenplus nine real translations); each call carries theenvalue as its inline default, so provider-less mounts and existing English tests are unchanged.reactPagesentences with inline code chips are ONE translated string each: the chips' slots are interpolated with private-use marks and the translated sentence is split on them, so each language decides where the chip sits. Same technique aselement:metadata_viewer(a local copy of itsCHIP/withChipshelper, in the same package).scripts/sdui-manifest.record.json:check-sdui-manifestwent red becausedata-table.tsxandreact-page.tsxare registry sources. Regenerated withnode scripts/gen-sdui-manifest-node.mjs:sdui.manifest.jsonis byte-unchanged (106 components); only the recorded source hash moved.Tests
New, through the real renderers / pages and a real
I18nProvider(zh expectations read from the packs and guarded as real Han rows, plus provider-less English controls):ui/packages/components/src/__tests__/renderer-copy-locale-25916.test.tsx: data-table titles; react-page notice and empty-source refusal with chips in the zh position and no slot leak. 7/7.ui/packages/app-shell/src/views/metadata-admin/ResourceEditPage.referencesColumns-25916.test.tsx: References column headers zh / en. 3/3.ui/apps/console/src/pages/developer/flowRunsClientDiagnostic-25916.test.tsx: the three diagnostics in zh with the method name, a thrown message verbatim, English controls. 6/6.Affected set (195 files: every test naming the touched titles, strings or components, plus all of
ui/packages/i18nand the i18n script tests), under the verify lock at962206c5: Test Files 195 passed (195), Tests 3305 passed, 13 skipped. The References-columns file was re-run (3/3) after its typing fix in522c33d6. Type-check of@object-ui/i18n,components,app-shell,console(turbo, with^build): green after one test-typing fix.Gates
Local: the 34 commands
dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived, pluscheck-changeset-fixed(its roster sits under.changeset): all exit 0 exceptcheck-sdui-manifest(cleared by the re-record above, now exit 0) andcheck:type-check-debt(timed out under the 300 s per-command cap; re-run reported in the os-dev report). ui scripts:check-i18n-call-site-keys,check-i18n-en-drift,check-i18n-dead-keys(none of the new keys listed),check-i18n-designer-table-parity,check-new-cross-file-line-citations(0 new): all exit 0. Repo-wide lint and the full ui shard battery are CI's.Acceptance notes
ui/apps/console/src/dev/*(Dev · … headings,PerformanceDashboard) and the console*-preview.tsxentries are developer harnesses, moved underdev/by the second pass precisely so a census can exclude them by path; translating their headings buys no user-facing language. Not done here; this is why the PR saysPart of.formatDatehelpers (plugin-list, plugin-map, plugin-timeline: the record preview overlay is a raw Object.entries dump in four views while five views render RecordDetailPanel — plus four byte-identical helpers to collapse objectui#13458), the Agent key-name prefill (kept by decision),ConnectAgentWidgetproduct names (proper nouns).StudioDesignSurfaceplaceholder: already localised onmain; its only remaining literal isplaceholder="https://", a URL scheme, not copy.ObjectView.tsx: only the Loading-chart region changed; the view-tab regions belong to console: a page or list view whose label is an inline locale map shows a machine name (InterfaceListPage) or reaches viewTabLabel raw (AppHeader view branch, ObjectView tab bar) #25901.Generated by Claude Code