Repository navigation
fix(ui-merge): two tests that #25745 broke on main read the merged tree — the Changesets config through changesetConfigPath(), the SDUI html tier by its tags (#25711) - #25852
Conversation
…rough changesetConfigPath() (objectstack#25711) 4a deleted ui/.changeset/config.json, since changesets reads the monorepo root's config. app-generator.test.ts "pins the release lockstep that lets the platform range be derived" still opened `<ui>/.changeset/config.json` directly and failed with ENOENT in Test UI 3/16. It now resolves the config the way every other reader does: the tree's own standalone, the monorepo root's when nested. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0149BHSXfCdQywGaLdpRAtWe
… the retired html component (objectstack#25711)
4a regenerated sdui.manifest.json from the in-tree ui/ (107 -> 106 components):
objectui#13449 retired the raw `html` renderer, so the witness's
`toContain('html')` failed in Test Core 5/8. The tier is now pinned by two of
its intrinsic tags (`a`, `p`); the clean run over the three shipped pages, which
never used `html`, still passes.
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0149BHSXfCdQywGaLdpRAtWe
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
…ts's ambient read to its new line (objectstack#25711) The changesetConfigPath() import and comment moved the registered `existsSync(join(process.cwd(), 'pnpm-workspace.yaml'))` read from line 1326 to 1329, so check:test-path-roots saw it as unregistered and the entry as stale. Same entry, same reason, new line. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0149BHSXfCdQywGaLdpRAtWe
…roject-thread-a0vh3h
|
Gate verdict: head Since the PR opened, Local, this head:
Known reds on
|
⛔ merge queue 构建失败 — 先分诊,再决定要不要重排队列构建 40251505048 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集), 分类: 失败的 job(日志抽取,best effort):
跨 PR 相同签名(24h,按失败测试文件聚合):
历史信号:
分诊清单:
Generated by Claude Code · merge-queue-triage workflow (#4859) |
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6SEitNngAMugGbuJHWsDS
Requested by Tesla · project thread
Part of #25677
Part of #25711
Clause-②: no
Metadata-protocol: none
Follow-up to #25745 (4a), per ruling 30 = B: the two Test UI / Test Core reds that #25745 caused once it merged are fixed here, on the same card. Test-only; nothing is released, so this carries
skip-changeset.What changes
1. Test UI shard 3/16:
ui/packages/cli/src/__tests__/app-generator.test.ts. The release-lockstep test readui/.changeset/config.json, which #25745 deleted (Changesets reads one config per repository). It now reads the config throughchangesetConfigPath()fromui/scripts/workspace-root.mjs, the helper every other reader of the Changesets config already uses: the tree's own config when standalone, the monorepo root's when nested underui/.2. Test Core 5/8:
packages/lint/src/validate-jsx-pages.production-witness.test.ts. The witness asserted that the SDUI manifest contains thehtmlcomponent. objectui#13449 retiredhtml, and the manifest #25745 regenerated from the in-treeui/has 106 components, without it. The witness now pins the html tier by two of its intrinsic tags (a,p). The shipped pages never used the rawhtmlcomponent, and the clean-run witness in the same file still checks them.Verification (this branch, on
main2a61f08)app-generator.test.ts: 48/48 pass. Without fix 1: 1 failed / 47 passed (ENOENT onui/.changeset/config.json).pnpm --dir ui run test --shard=3/16): 361 files passed, 1 skipped; 4,724 tests passed, 102 skipped.validate-jsx-pages.production-witness.test.ts: 5/5 pass. Also green:@objectstack/sdui-parser225/225, the cli sdui test files 79/79, app-showcase metric-filter 7/7.🤖 Generated with Claude Code
https://claude.ai/code/session_0149BHSXfCdQywGaLdpRAtWe