Skip to content

test(ui-merge): the repo-gates wiring pins retire with their port; "no workflow runs this" pins read the root workflows - #25904

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-6qe56u
Oct 26, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-6qe56u

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Tesla · project thread

Part of #25712 (4b PR 2d-2a: the per-gate wiring pins among the ui/scripts/__tests__ files that scan ui/.github/workflows/ stop reading it).
Part of objectstack#25677.

Clause-②: no
Metadata-protocol: none

维护者速读(草稿)

席位核对

(left for the dispatch seat)

Why

GitHub runs only the repository root's .github/workflows/. Since the cutover (#25825), objectui's workflows sit at ui/.github/workflows/ and run nowhere. 2d-1 (#25879) moved the 28 files that read ui/.github/workflows/ci.yml to the root ci.yml. This PR takes 18 of the 27 files that scan the workflow directory as a population. The dispatcher split the population in two: the other 8 (the governance files, which read through workflow-checks.ts or scan every workflow for a repo-wide rule) are 2d-2b. check-pre-install-import-graph stays with 2d-3, because its gate, not just its test, derives its population from the nested workflows.

The rule is the 2d-1 rule: retarget a pin to the root workflows by path, or retire it with a comment naming who carries its subject. Nothing is skipped and nothing is folded into a root workflow.

The 19 gates in ui/.github/workflows/repo-gates.yml run in no root workflow. #25880 ports them into the root Lint UI job. Per the dispatcher, the pins on their wiring retire against #25880, not against roster row 24.

What changes

Disposition table (18 files)

# File Retired (reads repo-gates.yml unless noted) Kept Carried by now
1 check-doc-component-types workflow, path filter, one home, install order, header-count pin alias, import-graph walk, 3 header-count controls #25880
2 check-doc-example-ids workflow, path filter, one home, install order, header count alias, neighbour-alias pin #25880
3 check-doc-example-types workflow, path filter, one home, after build, after sibling; the alias case's workflow half CI-page by-command row, alias #25880
4 check-doc-json-fences one home + filter, after build and siblings alias + CI page #25880
5 check-doc-snippet-types workflow, path filter, one home, builds a filter, builds before; the objectui#6221 step-script describe (6) build-filter emission (3), alias #25880
6 check-prompt-component-keys one home, unfiltered, install order alias, import-graph walk #25880
7 check-readme-exports one home, no trigger filter, triggers, builds before; step names alias, REQUIRED_CONTEXTS classification #25880
8 check-shell-escape-residue workflow, merge_group, path filter, one home, install order alias, REQUIRED_CONTEXTS classification #25880
9 check-skill-eval-tokens workflow, self-test, installs nothing, path filter, one home, neighbour; step name alias, classification, CI-page heading #25880
10 check-skill-examples workflow, self-test, derived build filter, path filter, one home, neighbour; step name alias, classification, CI-page heading #25880
11 check-skills-paths workflow, path filter, one home alias, baseline #25880
12 check-vi-mock-inherit workflow, merge_group, path filter, one home, install order alias #25880
13 check-vi-mock-specifiers workflow, merge_group, path filter, one home, install order alias #25880
14 docs-links-workflow runs the checker, triggers, no path filter, one home, docs-only startable; the workflow half of exists at all script exists, alias #25880
15 check-hand-rolled-comment-mask (none) nothing GitHub runs names this gate retargeted: root .github/workflows/
16 check-i18n-dead-keys (none) is NOT invoked by any GitHub workflow retargeted: root .github/workflows/
17 check-lint-rule-coverage (none) the inverse pin, not in a workflow yet retargeted: root .github/workflows/
18 check-published-dist-tooling runs nightly (published-dist-gate.yml) is NOT wired into any per-PR workflow per-PR half retargeted: root .github/workflows/; nightly half roster row 23

Some pins outlive their meaning but still read no workflow. For example, the CI page still says the doc gates block. They stay green and are #25880's to restate when the gates run again.

What 2d-2b and 2d-3 still owe (not here)

Verification

Run from ui/ per ui/AGENTS.md, at this head (main 6e0597f2 plus this commit):

Run Result
The 18 modified test files, ui/.github/workflows/ present 18 files, 1,034 tests, all passed
The same 18 files with ui/.github/workflows/ moved aside (the 2d-3 layout) 18 files, 1,034 tests, all passed
The same 18 with all of ui/.github/ moved aside 17 pass; check-prompt-component-keys fails 7 prompt-surface cases, because the prompts are under ui/.github/prompts/. 2d-3 moves them (above).
Whole scripts/__tests__ suite, --shard=1/4 through 4/4, under scripts/pm/os-verify-lock.sh 5,403 passed, 1 failed, 2 skipped, after the ledger fix
Every test that imports markdown-test-inputs.mjs (10 files) 340 passed
pnpm type-check:scripts the one error is packages/components/src/renderers/action/resolve-icon.ts(265,69) TS2339, identical on unmodified main here; none in a touched file
pnpm exec eslint --max-warnings=0 (touched files), lint:coverage, check:test-path-roots, check:vi-mock-override-shape; root pnpm check:test-source-alias all exit 0

The one suite failure is the base red riding main since 2c: check-pre-install-import-graph, unresolved: scripts/objectstack-pin.mjs. It clears in 2d-3 with the nested workflows.

Derived gates (node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack from this diff): 18 families, all exit 0 at this head. --ran reconciles 18 run, 0 NOT-MEASURED, 0 UNRUN. The slowest were check:query-options-erasure (320 s), check-comment-mask-corpus (202 s) and check:engine-double-contract (68 s).

The push-environment battery (GITHUB_ACTIONS=true GITHUB_EVENT_NAME=push node scripts/pm/check-dispatch-gates.mjs, both tiers) is running on this head. Its line goes to the dispatch seat.

🤖 Generated with Claude Code

https://claude.ai/code/session_01A6SEitNngAMugGbuJHWsDS

…o workflow runs this" pins read the root workflows

GitHub runs only the repository root's .github/workflows/. 18 of the
ui/scripts/__tests__ files that scan ui/.github/workflows/ ask a question of
a directory that runs nowhere.

- 14 files pin the wiring of a gate whose only home is objectui's
  repo-gates.yml: its home, triggers, path filters, install order, step
  names, and the header-count pin. No root workflow runs these gates; the
  card that ports repo-gates.yml into the root Lint UI job brings the pins
  back against that job. They retire with a comment naming it. What reads
  no workflow stays: the package.json aliases, the import-graph walks, the
  build-filter emission, the REQUIRED_CONTEXTS classifications, the CI page
  sections, and the header-count controls. The doc-snippet-types file's
  six cases that ran repo-gates.yml's derive and build steps under bash
  retire the same way.
- 4 files assert that no workflow runs a gate (comment-mask, i18n dead
  keys, lint-rule coverage, the published-dist scan per PR). They now ask
  the root directory through a new helpers/root-ci.ts rootWorkflowFiles(),
  which refuses a scan that reads implausibly few files. The published-dist
  scan's "runs nightly" pin retires as roster row 23, a follow-up port.
- markdown-test-inputs.mjs drops the ten `walker` declarations those
  workflow-directory walks produced, and the three entries the scanner no
  longer offers at all.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A6SEitNngAMugGbuJHWsDS
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 26, 2026
@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 26, 2026 04:05
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 26, 2026 04:06
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 26, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Standing down on two red Test UI shards at 8086728e. Neither is this PR's.

Neither shard is a required context.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 40267487698 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

分类:failure —— 按下面的日志分诊。

失败的 job(日志抽取,best effort):

  • Test UI (13/16) — 失败步骤: Run the ui tests (shard 13/16)

    × finds no pre-install gate reaching a package 9ms
    FAIL   unit  scripts/__tests__/check-pre-install-import-graph.test.ts > the real tree — every step objectui#6148 measured is still derived > finds no pre-install gate reaching a package
      ↳ 失败原因: AssertionError: a script this repository runs before `pnpm install` needs `node_modules` to load: expected [ Array(1) ] to deeply equal []
    

↳ 失败原因 是判读的关键:超时(Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言(AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️ 断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError。 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 13 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Merged via the queue into main with commit 2a728ba Oct 26, 2026
84 of 87 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/project-thread-6qe56u branch October 26, 2026 04:23
@github-actions

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 40268208875 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

分类:failure —— 按下面的日志分诊。

失败的 job(日志抽取,best effort):

  • Test UI (13/16) — 失败步骤: Run the ui tests (shard 13/16)

    × finds no pre-install gate reaching a package 14ms
    FAIL   unit  scripts/__tests__/check-pre-install-import-graph.test.ts > the real tree — every step objectui#6148 measured is still derived > finds no pre-install gate reaching a package
      ↳ 失败原因: AssertionError: a script this repository runs before `pnpm install` needs `node_modules` to load: expected [ Array(1) ] to deeply equal []
    

↳ 失败原因 是判读的关键:超时(Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言(AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️ 断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError。 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • ⚠️ 本 PR 过去 24h 已在队列失败 1 次(不含本次)。 内容未变而反复失败 ⇒ 高度怀疑 flaky 测试或与同组 PR 的语义冲突,重排不解决。
  • 过去 24h 队列共有 14 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl skip-changeset PR has no user-facing published change; bypasses the changeset gate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants