Skip to content

src: release uv_fs_t in permission WildcardIfDir #66555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RafaelGSS wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −9
Open

src: release uv_fs_t in permission WildcardIfDir #66555

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fd9e0b
src: release uv_fs_t in permission WildcardIfDir
RafaelGSS Oct 6, 2026
367ef6c
src: format WildcardIfDir in fs_permission.cc
RafaelGSS Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/permission/fs_permission.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@ namespace {
std::string WildcardIfDir(const std::string& res) noexcept {
uv_fs_t req;
int rc = uv_fs_stat(nullptr, &req, res.c_str(), nullptr);
if (rc == 0) {
const uv_stat_t* const s = static_cast<const uv_stat_t*>(req.ptr);
if ((s->st_mode & S_IFMT) == S_IFDIR) {
// add wildcard when directory
if (res.back() == node::kPathSeparator) {
return res + "*";
}
return res + node::kPathSeparator + "*";
const bool is_dir =
rc == 0 &&
(static_cast<const uv_stat_t*>(req.ptr)->st_mode & S_IFMT) == S_IFDIR;
uv_fs_req_cleanup(&req);
if (is_dir) {
// add wildcard when directory
if (res.back() == node::kPathSeparator) {
return res + "*";
}
return res + node::kPathSeparator + "*";
}
uv_fs_req_cleanup(&req);
return res;
}

Expand Down
Loading