Skip to content

src: release uv_fs_t in permission WildcardIfDir - #66555

Open
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:release-uv-fs-t-in-permission-wildcardifdir
Open

RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:release-uv-fs-t-in-permission-wildcardifdir

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

src: release uv_fs_t in permission WildcardIfDir

Call uv_fs_req_cleanup() before returning for directories, otherwise
the path buffer allocated by uv_fs_stat() leaks on Windows.

Call uv_fs_req_cleanup() before returning for directories, otherwise
the path buffer allocated by uv_fs_stat() leaks on Windows.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model. labels Oct 6, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.40%. Comparing base (fcfb7ec) to head (367ef6c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/permission/fs_permission.cc 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #66555   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files         791      791           
  Lines      276226   276226           
  Branches    53045    53037    -8     
=======================================
  Hits       249732   249732           
+ Misses      16899    16897    -2     
- Partials     9595     9597    +2     
Files with missing lines Coverage Δ
src/permission/fs_permission.cc 69.30% <75.00%> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS RafaelGSS added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants