Skip to content

deps: V8: cherry-pick 8e374caa66ce #66526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IlyasShabi wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −5
Open

deps: V8: cherry-pick 8e374caa66ce #66526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.22',
'v8_embedder_string': '-node.23',

##### V8 defaults for Node.js #####

Expand Down
13 changes: 9 additions & 4 deletions deps/v8/src/profiler/sampling-heap-profiler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ v8::AllocationProfile::Node* SamplingHeapProfiler::TranslateAllocationNode(
// a GC kicks in during the tree retrieval.
node->pinned_ = true;
Local<v8::String> script_name =
ToApiHandle<v8::String>(isolate_->factory()->InternalizeUtf8String(""));
ToApiHandle<v8::String>(isolate_->factory()->empty_string());
int line = v8::AllocationProfile::kNoLineNumberInfo;
int column = v8::AllocationProfile::kNoColumnNumberInfo;
std::vector<v8::AllocationProfile::Allocation> allocations;
Expand All @@ -252,10 +252,15 @@ v8::AllocationProfile::Node* SamplingHeapProfiler::TranslateAllocationNode(
auto script_iterator = scripts.find(node->script_id_);
if (script_iterator != scripts.end()) {
DirectHandle<Script> script = script_iterator->second;
if (IsName(script->name())) {
Tagged<Name> name = Cast<Name>(script->name());
if (IsString(script->name())) {
script_name =
ToApiHandle<v8::String>(isolate_->factory()->InternalizeString(
direct_handle(Cast<String>(script->name()), isolate_)));
} else if (IsSymbol(script->name())) {
Tagged<Symbol> symbol = Cast<Symbol>(script->name());
script_name = ToApiHandle<v8::String>(
isolate_->factory()->InternalizeUtf8String(names_->GetName(name)));
isolate_->factory()->InternalizeUtf8String(
names_->GetName(symbol)));
}
Script::PositionInfo pos_info;
Script::GetPositionInfo(script, node->script_position_, &pos_info);
Expand Down
Loading