deps: V8: cherry-pick 8e374caa66ce - #66526
Open
IlyasShabi wants to merge 1 commit into
Open
IlyasShabi wants to merge 1 commit into
IlyasShabi wants to merge 1 commit into
Conversation
Original commit message:
[profiler] Internalize string script names directly
Avoid converting script names to UTF-8 by internalizing String names
directly. Keep the existing conversion for Symbol names and use the
canonical empty string for unnamed scripts.
This improved profile retrieval performance by ~30% in local benchmarks.
Change-Id: I5eb6e8fa79517dc4902ddc1f26d75a9dd228ef39
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8449311
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110089}
Refs: v8/v8@8e374ca
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@8e374ca