Skip to content

[fix]: issue not rendering report without bib files from {journals} - #586

Open
Schiano-NOAA wants to merge 1 commit into
mainfrom
fix-bib-f-render
Open

Schiano-NOAA wants to merge 1 commit into
mainfrom
fix-bib-f-render

Conversation

@Schiano-NOAA

Copy link
Copy Markdown
Collaborator

What is the feature?

How have you implemented the solution?

  • removed journals reference from base in-header.tex and customized in function when bib is set to something

Does the PR impact any other area of the project, maybe another repo?

  • no

Note: do not merge until update_report is merged. This will need to be rebased after bc the code base is so different. Or the other way -- not sure which one is less annoying

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Code Metrics Report

Coverage Code to Test Ratio Test Execution Time
41.4% 1:0.3 59s

Code coverage of files in pull request scope (48.7%, patch 60.0%)

Files Coverage Patch Coverage
R/create_template.R 47.3% 66.6%
R/utils_tex.R 61.5% 50.0%

Reported by octocov

@sbreitbart-NOAA sbreitbart-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Schiano-NOAA

Copy link
Copy Markdown
Collaborator Author

Note: Merge after #563 and #576 are merged -- rebase first. Will have conflicts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Reports not rendering when create_template(bib_file = FALSE)

2 participants