Skip to content

Avoid integer underflow and wasted iterations in ToPagedEnumerable. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
extraes wants to merge 5 commits into from
Closed

Avoid integer underflow and wasted iterations in ToPagedEnumerable. #13

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c18dc22
add missing event enums
extraes Jan 27, 2026
0cb322a
Merge branch 'nickelc:master' into master
extraes Apr 13, 2026
4e9db6a
avoid integer underflow by making "remaining" a huge signed type.
extraes Aug 25, 2026
582e173
Fix comment and whitespace
extraes Aug 25, 2026
a18d64c
Also early-out for empty responses
extraes Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Modio/Clients/SearchClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ public async IAsyncEnumerable<T> ToEnumerable()
public async IAsyncEnumerable<IReadOnlyList<T>> ToPagedEnumerable()
{
var (method, path) = this.route;
uint? remaining = null;
// Huge integer type that does signed arithmetic and encompasses uint's max value
long? remaining = null;
do
{
var req = new Request(method, path);
Expand All @@ -93,6 +94,10 @@ public async IAsyncEnumerable<IReadOnlyList<T>> ToPagedEnumerable()
remaining ??= result.Total;
remaining -= result.Count;

// Don't bother returning anything or continuing for an empty response
if (result.Count == 0)
yield break;

var limit = result.Limit;
var offset = result.Offset;

Expand Down
Loading