Conversation
the method already seems to treat it like it can go under zero with the while condition
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SearchClient.ToPagedEnumerable can underflow
remainingifresult.Totalandresult.Countare different (particularly, if count is greater than total), leading to the paginator asking for a bunch of empty pages at absurd offsets.This has actually happened, as a heap dump from a running bot confirmed that the
remainingvariable was0xFFFFFFFE(4,294,967,294in decimal, or0 - 2in math).And to avoid wasting iterations on empty responses, in case someone intentionally puts a huge
offsetin, justyield breakwhen receiving an empty count.