Skip to content

Fix/update container bam - #119

Merged
KateSakharova merged 7 commits into
devfrom
fix/update-container-bam
Oct 27, 2026
Merged

KateSakharova merged 7 commits into
devfrom
fix/update-container-bam

Conversation

@KateSakharova

@KateSakharova KateSakharova commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Continuing #117

Note: I have modified mag_no_rna samplesheet developing euks part - it required snapshot change as well (but proper version would come with #104 )

@github-actions

Copy link
Copy Markdown

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 4.1.0.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the Synchronisation documentation.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8f2b4e6

+| ✅ 258 tests passed       |+
#| ❔   9 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_exist - File is ignored: .github/workflows/linting_comment.yml
  • nextflow_config - Config variable ignored: params.input
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-seqsubmit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-seqsubmit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-seqsubmit_logo_dark.png
  • container_configs - container_configs

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 4.1.0
  • Run at 2026-10-27 20:44:20

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

❌ nf-test failed with latest Nextflow version

Note

Tests with Nextflow's latest version failed but it will not cause a CI workflow failure.
Please check if the failure is expected with newer (edge-)releases of Nextflow or if it needs fixing.

  • ❌ docker | latest-everything | Shard 1/7

See the full run for details.

@KateSakharova
KateSakharova marked this pull request as ready for review October 26, 2026 20:46
@KateSakharova
KateSakharova force-pushed the fix/update-container-bam branch from e303450 to 3387b30 Compare October 26, 2026 20:56
submission_study = "PRJEB98843"
centre_name = "TEST_CENTER"

test_upload = false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_upload = true?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand it won't submit anything because webincli_mode = "validate"
But comment is needed here with WARNING and exclamation marks

@KateSakharova KateSakharova Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_upload adds -test to command. For -validate mode we do not need that -test (I think it doesn't really matter but I tried with -test and something was wrong...). Let me try again

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, works, I have changed to -test

@Vkale1 Vkale1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one comment made.

Comment thread conf/test_reads_long_bam.config Outdated
Comment thread conf/test_reads_long_bam.config Outdated
Comment thread conf/test_reads_long_bam_validate.config Outdated
Comment thread conf/test_reads_long_bam_validate.config Outdated
Comment thread docs/usage.md Outdated
Comment on lines +110 to +114
"no_rna_presence_euk_bac.gff:md5,df19e1b84ba6f691d20c72b397c88abf",
"no_rna_presence_euk.tsv:md5,68d0b807755e195d09aaa082d59827e7",
"no_rna_presence_prok_bac.gff:md5,468c2be7060d743f95295f1ecf751e19",
"no_rna_presence_prok.tsv:md5,23c19ff33ce36f041803b5b3e7b7681b",
"genomes_metadata.tsv:md5,2acbde2a328213ee6b5153bffa72d697",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if md5 change of those files is expected?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably because I renamed no_rna_presence to no_rna_presence_prok at least

Comment on lines +27 to +45
"multiqc",
"multiqc/multiqc_data",
"multiqc/multiqc_data/llms-full.txt",
"multiqc/multiqc_data/multiqc.log",
"multiqc/multiqc_data/multiqc.parquet",
"multiqc/multiqc_data/multiqc_citations.txt",
"multiqc/multiqc_data/multiqc_data.json",
"multiqc/multiqc_data/multiqc_software_versions.txt",
"multiqc/multiqc_data/multiqc_sources.txt",
"multiqc/multiqc_report.html",
"pipeline_info",
"pipeline_info/nf_core_seqsubmit_software_mqc_versions.yml",
"reads",
"reads/bacteroides_fragilis_ont_bam",
"reads/bacteroides_fragilis_ont_bam/upload",
"reads/bacteroides_fragilis_ont_bam/upload/webin_cli",
"reads/bacteroides_fragilis_ont_bam/upload/webin_cli/bacteroides_fragilis_ont_bam_accessions.tsv",
"reads/upload",
"reads/upload/reads_accessions.tsv"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some multiqc files seem to be missing, did you run with docker_arm?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did. We have images for custom data coming to multiqc. For reads we didn't add those and there is an issue #70 about it. I have compared it also with reads_long_bam.nf.test.snap and it looks the same

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have freaked a bit and added report to multiqc 8f2b4e6 and now images appeared

@KateSakharova
KateSakharova merged commit e0eed0d into dev Oct 27, 2026
20 checks passed
@KateSakharova
KateSakharova deleted the fix/update-container-bam branch October 27, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants