Repository navigation
Fix/update container bam - #119
Conversation
… bam tests will currently fail until toolkit containers are updated
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 4.1.0. For more documentation on how to update your pipeline, please see the Synchronisation documentation. |
|
❌ nf-test failed with latest Nextflow versionNote Tests with Nextflow's latest version failed but it will not cause a CI workflow failure.
See the full run for details. |
e303450 to
3387b30
Compare
| submission_study = "PRJEB98843" | ||
| centre_name = "TEST_CENTER" | ||
|
|
||
| test_upload = false |
There was a problem hiding this comment.
As far as I understand it won't submit anything because webincli_mode = "validate"
But comment is needed here with WARNING and exclamation marks
There was a problem hiding this comment.
test_upload adds -test to command. For -validate mode we do not need that -test (I think it doesn't really matter but I tried with -test and something was wrong...). Let me try again
There was a problem hiding this comment.
hmm, works, I have changed to -test
Vkale1
left a comment
There was a problem hiding this comment.
Looks good to me! Just one comment made.
| "no_rna_presence_euk_bac.gff:md5,df19e1b84ba6f691d20c72b397c88abf", | ||
| "no_rna_presence_euk.tsv:md5,68d0b807755e195d09aaa082d59827e7", | ||
| "no_rna_presence_prok_bac.gff:md5,468c2be7060d743f95295f1ecf751e19", | ||
| "no_rna_presence_prok.tsv:md5,23c19ff33ce36f041803b5b3e7b7681b", | ||
| "genomes_metadata.tsv:md5,2acbde2a328213ee6b5153bffa72d697", |
There was a problem hiding this comment.
Do you know if md5 change of those files is expected?
There was a problem hiding this comment.
probably because I renamed no_rna_presence to no_rna_presence_prok at least
| "multiqc", | ||
| "multiqc/multiqc_data", | ||
| "multiqc/multiqc_data/llms-full.txt", | ||
| "multiqc/multiqc_data/multiqc.log", | ||
| "multiqc/multiqc_data/multiqc.parquet", | ||
| "multiqc/multiqc_data/multiqc_citations.txt", | ||
| "multiqc/multiqc_data/multiqc_data.json", | ||
| "multiqc/multiqc_data/multiqc_software_versions.txt", | ||
| "multiqc/multiqc_data/multiqc_sources.txt", | ||
| "multiqc/multiqc_report.html", | ||
| "pipeline_info", | ||
| "pipeline_info/nf_core_seqsubmit_software_mqc_versions.yml", | ||
| "reads", | ||
| "reads/bacteroides_fragilis_ont_bam", | ||
| "reads/bacteroides_fragilis_ont_bam/upload", | ||
| "reads/bacteroides_fragilis_ont_bam/upload/webin_cli", | ||
| "reads/bacteroides_fragilis_ont_bam/upload/webin_cli/bacteroides_fragilis_ont_bam_accessions.tsv", | ||
| "reads/upload", | ||
| "reads/upload/reads_accessions.tsv" |
There was a problem hiding this comment.
Some multiqc files seem to be missing, did you run with docker_arm?
There was a problem hiding this comment.
I did. We have images for custom data coming to multiqc. For reads we didn't add those and there is an issue #70 about it. I have compared it also with reads_long_bam.nf.test.snap and it looks the same
There was a problem hiding this comment.
I have freaked a bit and added report to multiqc 8f2b4e6 and now images appeared
Continuing #117
Note: I have modified mag_no_rna samplesheet developing euks part - it required snapshot change as well (but proper version would come with #104 )