[stable35] fix: only call the legacy files sidebar methods when they exist

css/viewer-main.css

@@ -1,3 +1,3 @@
 /* extracted by css-entry-points-plugin */
-@import './main-D1HzHdhz.chunk.css';
+@import './main-labEDf3j.chunk.css';
 @import './previewUtils-CU5qdRbf.chunk.css';

playwright/e2e/actions/sidebar.spec.ts

@@ -22,12 +22,14 @@ import {
 
 test.describe.serial('Open the sidebar from the viewer and open viewer with sidebar already opened', () => {
 	let page: Page
+	const pageErrors: string[] = []
 
 	test.beforeAll(async ({ browser }) => {
 		({ page } = await setupFilesPage(browser, [1, 2, 3, 4].map((i) => ({
 			fixture: `image${i}.jpg`,
 			mimeType: 'image/jpeg',
 		}))))
+		page.on('pageerror', (error) => pageErrors.push(error.message))
 	})
 
 	test.afterAll(async () => {
@@ -103,4 +105,10 @@ test.describe.serial('Open the sidebar from the viewer and open viewer with side
 		await expect(getSidebar(page)).not.toBeVisible()
 		await expect(getMenuToggle(page)).toBeVisible()
 	})
+
+	test('Close the viewer without errors', async () => {
+		await getCloseButton(page).click()
+		await expect(getViewer(page)).toHaveCount(0)
+		expect(pageErrors).toEqual([])
+	})
 })

src/views/Viewer.vue

@@ -1055,7 +1055,7 @@ export default defineComponent({
 			// which then triggers cleanup.
 			OCA.Viewer.close()
 
-			if (OCA?.Files?.Sidebar) {
+			if (typeof OCA?.Files?.Sidebar?.setFullScreenMode === 'function') {
 				OCA.Files.Sidebar.setFullScreenMode(false)
 			}
 
@@ -1192,7 +1192,7 @@ export default defineComponent({
 
 				// some apps mocked the files api to allow their sidebar to be used with the viewer
 				// to not break them keep this at least until Nextcloud 34.
-				if (OCA?.Files?.Sidebar) {
+				if (typeof OCA?.Files?.Sidebar?.open === 'function') {
 					// TODO: also hide figure, needs a proper method for it in server Sidebar
 					await OCA.Files.Sidebar.open(this.sidebarOpenFilePath)
 				}