Repository navigation
[stable35] fix: only call the legacy files sidebar methods when they exist - #3448
Merged
Merged
Conversation
Member
Author
|
/compile |
Member
Author
|
/compile rebase |
Nextcloud 35 defines OCA.Files.Sidebar only as a namespace for the new sidebar's shared state, so closing the viewer threw 'OCA.Files.Sidebar.setFullScreenMode is not a function', and opening the sidebar from the viewer threw on OCA.Files.Sidebar.open. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvo忙 <14975046+skjnldsv@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/legacy-sidebar-calls-stable35
branch
from
October 20, 2026 06:52
3ca4307 to
2480817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3447
On Nextcloud 35,
OCA.Files.Sidebaronly holds the new sidebar's shared state, so the viewer's legacy calls threw: closing a preview gaveTypeError: OCA.Files.Sidebar.setFullScreenMode is not a function, and opening the sidebar from the viewer threw onOCA.Files.Sidebar.open. Both now check that the method exists, likebeforeOpen()already did.Fixes #3446
The sidebar e2e suite now fails on any page error, closing the viewer included.
馃懢 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.