Repository navigation
[stable34] fix(viewer): register handlers not yet in the lookup table when opening a file - #3422
Merged
Merged
Conversation
…ng a file On single-file public shares, the files app can open the file before DOMContentLoaded, while the component's handler lookup table is still empty. This shows "There is no plugin available to display this file type". Register any missing handlers when a file is opened, as well as on DOMContentLoaded. On this branch the end-to-end test is the Playwright version of the Cypress test. (cherry picked from commit 0d33b35) Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by:ClaudeCode:claude-opus-5.5 Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3418.
On this branch the end-to-end test is the Playwright version of the Cypress test, and the
DOMContentLoadedlistener had already dropped the Sidebar binding, so it only callsregisterNewHandlers()now.It also stops the duplicate "Could not register handler" errors from #3362, as queued handlers already registered are skipped.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.