Repository navigation
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
1 task done
skjnldsv
added
3. to review
skjnldsv
marked this pull request as ready for review
October 6, 2026 07:43
Member
Author
|
/compile |
Member
Author
|
/backport to stable34 please |
Member
Author
|
/backport to stable33 please |
Member
Author
|
/backport to stable32 please |
Member
Author
|
/backport to stable31 please |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since e9a9933 the viewer registers the handlers queued in
window._oca_viewer_handlersas it starts, and theDOMContentLoadedpass registers the queue again for handlers added in between. The second pass hit the first ones and logged "Could not register handler" for each.registerHandler()now returns early for a handler it already has; a different handler with the same id is still rejected.Resolves #3362
I didn't clear the Map as suggested in the issue:
@nextcloud/vieweralso uses it to spot the same handler from several bundled copies, so clearing it would let duplicates back in.The new e2e test queues a handler before the viewer starts and checks it is registered once, with no error.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.