Repository navigation
chore(config): refactor all signaling server related configs to AppConfig - #19915
Merged
Merged
Conversation
sudormant
added
feature: settings ⚙️
sudormant
force-pushed
the
refactor/config/RefactorTalkConfigToAppConfig7
branch
4 times, most recently
from
October 20, 2026 13:28
b722524 to
c687178
Compare
Contributor
Author
|
rebased after #19400 merge and cleaned up, unit tests now pass
that behavior remains unchanged and should be checked / streamlined in another PR. |
sudormant
marked this pull request as ready for review
October 20, 2026 13:49
2 of 3 tasks
sudormant
force-pushed
the
refactor/config/RefactorTalkConfigToAppConfig7
branch
5 times, most recently
from
October 27, 2026 16:10
b658bcf to
5c6e37a
Compare
nickvergessen
requested changes
Oct 27, 2026
…nfig Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
…ix and config lexicon entries for different key types to split off in new PRs Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
…ling secret was reverted Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
sudormant
force-pushed
the
refactor/config/RefactorTalkConfigToAppConfig7
branch
from
October 28, 2026 08:06
5c6e37a to
0c4d194
Compare
nickvergessen
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI (if applicable)
🏁 Checklist
docs/has been updated or is not requiredrefactoring all signaling server related configs to AppConfig.
These unit test failures are expected and solved by #19400:
There were 3 failures:
OCA\Talk\Tests\BackgroundJob\CheckHostedSignalingServerTest::testRunWithNoChange
Expectation failed for method name is "fetchAccountInfo" when invoked 1 time.
Method was expected to be called 1 time, actually called 0 times.
OCA\Talk\Tests\BackgroundJob\CheckHostedSignalingServerTest::testRunWithPendingToActiveChange
Expectation failed for method name is "fetchAccountInfo" when invoked 1 time.
Method was expected to be called 1 time, actually called 0 times.
OCA\Talk\Tests\BackgroundJob\CheckHostedSignalingServerTest::testRunWithPendingToActiveIncludingStunAndTurn
Expectation failed for method name is "fetchAccountInfo" when invoked 1 time.
Method was expected to be called 1 time, actually called 0 times.
Checking CI for tests and clean occ app config as some types were enforced.
needs further cleaning up, tests validations, polishing and checks that signaling_servers is used as the same array type everywhere, [servers] vs [secret] vs [server, server..]