Repository navigation
refactor: remove deprecated calls to IConfig::getAppValue - #17171
miaulalala wants to merge 1 commit into
Conversation
| $groups = $this->config->getAppValue('spreed', 'allowed_groups', '[]'); | ||
| $groups = json_decode($groups, true); | ||
| return \is_array($groups) ? $groups : []; | ||
| $groups = $this->appConfig->getAppValueArray('allowed_groups'); |
There was a problem hiding this comment.
We should document the types and included changed defaults in the settings.md
There was a problem hiding this comment.
but the setter didn't change?
There was a problem hiding this comment.
Well we should use the same type in get and set, otherwise this is "based on assumptions that might change".
There was a problem hiding this comment.
ah I see, fair enough. I just figured your comment in #17171 (comment) was meant to point me towards using getArrayValue
0bdd092 to
bb2ab2c
Compare
Signed-off-by: Anna Larch <anna@nextcloud.com>
bb2ab2c to
1adc137
Compare
|
to do: do the config values one by one and change settings itself, the documentation, the occ config options and every part of the code where the config options is written or read. |
Yes, the rest will be merged soon and a cleanup of some leftovers and test will follow soon. |
To fix:
🏁 Checklist
docs/has been updated or is not required