Repository navigation
chore(config): refactor sip settings to AppConfig, changes to different similar flags - #19739
Merged
sudormant merged 6 commits intoOct 27, 2026
Merged
Conversation
sudormant
added
feature: settings ⚙️
sudormant
force-pushed
the
refactor/config/RefactorTalkConfigToAppConfigSIP
branch
2 times, most recently
from
October 13, 2026 14:20
264d70b to
450c9d6
Compare
sudormant
marked this pull request as ready for review
October 13, 2026 15:25
nickvergessen
force-pushed
the
refactor/config/RefactorTalkConfigToAppConfigSIP
branch
from
October 13, 2026 19:45
3497928 to
f98f789
Compare
sudormant
force-pushed
the
refactor/config/RefactorTalkConfigToAppConfigSIP
branch
from
October 19, 2026 11:48
f98f789 to
7bf65b3
Compare
sudormant
force-pushed
the
refactor/config/RefactorTalkConfigToAppConfigSIP
branch
from
October 20, 2026 13:58
bb33529 to
33cc0af
Compare
2 of 3 tasks
…nt similar flags Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
…pconfig values checked by SIP configuration checks and remove redundant boolean asserts to itself Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
…ing value as json to backend for sip_dialout Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
…d of calling both app configs directly Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
sudormant
force-pushed
the
refactor/config/RefactorTalkConfigToAppConfigSIP
branch
3 times, most recently
from
October 26, 2026 12:47
083ce80 to
996c93c
Compare
nickvergessen
requested changes
Oct 27, 2026
…n different names in other places instead Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
sudormant
force-pushed
the
refactor/config/RefactorTalkConfigToAppConfigSIP
branch
from
October 27, 2026 14:43
996c93c to
1c3000a
Compare
nickvergessen
approved these changes
Oct 27, 2026
sudormant
deleted the
refactor/config/RefactorTalkConfigToAppConfigSIP
branch
October 27, 2026 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work in progress, checking with CI here
🏁 Checklist
docs/has been updated or is not required