Skip to content

Refactor/config/refactor federation to app config - #18850

Merged
sudormant merged 5 commits into
mainfrom
refactor/config/RefactorFederationToAppConfig
Oct 27, 2026
Merged

sudormant merged 5 commits into
mainfrom
refactor/config/RefactorFederationToAppConfig

Conversation

@sudormant

Copy link
Copy Markdown
Contributor

๐Ÿ› ๏ธ API Checklist

๐Ÿ Checklist

  • โ›‘๏ธ Tests (unit and/or integration) are included or not possible
  • ๐Ÿ“˜ API documentation in docs/ has been updated or is not required
  • ๐Ÿ”– Capability is added or not needed

@sudormant sudormant added this to the โ›… Next Major (35) milestone Jul 28, 2026
@sudormant
sudormant requested a review from nickvergessen July 28, 2026 14:32
@sudormant sudormant self-assigned this Jul 28, 2026
@sudormant sudormant added feature: settings โš™๏ธ Settings and config related issues feature: api ๐Ÿ› ๏ธ OCS API for conversations, chats and participants technical debt feature: federation ๐ŸŒ labels Jul 28, 2026
@sudormant
sudormant force-pushed the refactor/config/RefactorFederationToAppConfig branch from 6c205c8 to 42e0247 Compare July 28, 2026 14:34
@nickvergessen

Copy link
Copy Markdown
Member

Federation is failing again, something to check

Comment thread lib/Settings/Admin/AdminSettings.php Outdated
Comment thread lib/ConfigLexicon.php Outdated
@sudormant
sudormant requested a review from nickvergessen July 31, 2026 09:09
@nickvergessen

Copy link
Copy Markdown
Member

This branch has conflicts that must be resolved

@sudormant

Copy link
Copy Markdown
Contributor Author

This branch has conflicts that must be resolved

No merge yet please, federation integration tests are still failing again with reach-remote. Still working on it, conflicts will be resolved once it's working properly.

@sudormant
sudormant force-pushed the refactor/config/RefactorFederationToAppConfig branch from b9b9733 to c70d854 Compare October 6, 2026 15:29
@sudormant
sudormant marked this pull request as draft October 6, 2026 15:29
Comment thread docs/external-call-service.md Outdated
Comment thread docs/external-call-service.md Outdated
Comment thread tests/integration/features/federation/archive.feature Outdated
Comment thread lib/Federation/BackendNotifier.php Outdated
@Antreesy Antreesy mentioned this pull request Oct 13, 2026
3 of 14 tasks
@sudormant
sudormant force-pushed the refactor/config/RefactorFederationToAppConfig branch from c70d854 to fce67b3 Compare October 19, 2026 10:12
@sudormant
sudormant marked this pull request as ready for review October 19, 2026 10:59
Comment thread lib/Settings/Admin/AdminSettings.php Outdated
Comment thread src/components/AdminSettings/FederationSettings.vue Outdated
Comment thread docs/settings.md Outdated
Comment thread lib/Capabilities.php Outdated
Comment thread lib/Capabilities.php Outdated
Comment thread lib/Capabilities.php Outdated
@sudormant
sudormant force-pushed the refactor/config/RefactorFederationToAppConfig branch 2 times, most recently from 8fad84f to 10360c3 Compare October 20, 2026 08:49

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG from my side, tested UI

Comment thread lib/Capabilities.php Outdated
Comment thread lib/Settings/Admin/AdminSettings.php Outdated
@sudormant
sudormant force-pushed the refactor/config/RefactorFederationToAppConfig branch from 10360c3 to f975436 Compare October 26, 2026 10:37
Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
โ€ฆfig ConfigLexicon entries

Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
โ€ฆ in admin settings and fix copy paste error in ConfigLexicon definiton

Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
@sudormant
sudormant force-pushed the refactor/config/RefactorFederationToAppConfig branch from f975436 to ebc3af3 Compare October 27, 2026 15:43
@sudormant
sudormant merged commit d6e586a into main Oct 27, 2026
74 checks passed
@sudormant
sudormant deleted the refactor/config/RefactorFederationToAppConfig branch October 27, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: api ๐Ÿ› ๏ธ OCS API for conversations, chats and participants feature: federation ๐ŸŒ feature: settings โš™๏ธ Settings and config related issues technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants