Skip to content

feat(files_sharing): show pending shares on top of All files and Shares #66147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jancborchardt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(files_sharing): show pending shares on top of All files and Shares #66147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bc89db
feat(files_sharing): show pending shares on top of All files and Shares
jancborchardt Nov 2, 2026
101ae73
fix(files_sharing): show owner names unescaped and clean up pending s…
jancborchardt Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
285 changes: 0 additions & 285 deletions apps/files_sharing/src/files_actions/acceptShareAction.spec.ts
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions apps/files_sharing/src/files_actions/acceptShareAction.ts
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions apps/files_sharing/src/files_actions/openInFilesAction.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type { IFolder, IView } from '@nextcloud/files'

import { DefaultType, File, Permission } from '@nextcloud/files'
import { describe, expect, test, vi } from 'vitest'
import { deletedSharesViewId, pendingSharesViewId, sharedWithOthersViewId, sharedWithYouViewId, sharesViewId, sharingByLinksViewId } from '../files_views/shares.ts'
import { deletedSharesViewId, sharedWithOthersViewId, sharedWithYouViewId, sharesViewId, sharingByLinksViewId } from '../files_views/shares.ts'
import { action } from './openInFilesAction.ts'

import '../main.ts'
Expand All @@ -26,7 +26,6 @@ const validViews = [

const invalidViews = [
deletedSharesViewId,
pendingSharesViewId,
].map((id) => ({ id, name: id })) as IView[]

describe('Open in files action conditions tests', () => {
Expand Down
2 changes: 1 addition & 1 deletion apps/files_sharing/src/files_actions/openInFilesAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const action: IFileAction = {
sharedWithYouViewId,
sharedWithOthersViewId,
sharingByLinksViewId,
// Deleted and pending shares are not
// Deleted shares are not
// accessible in the files app.
].includes(view.id),

Expand Down
Loading
Loading