Skip to content

feat(files_sharing): show pending shares on top of All files and Shares - #66147

Open
jancborchardt wants to merge 2 commits into
masterfrom
feat/pending-shares-inline
Open

jancborchardt wants to merge 2 commits into
masterfrom
feat/pending-shares-inline

Conversation

@jancborchardt

@jancborchardt jancborchardt commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

In Nextcloud Files, "Pending shares" are currently a separate view with an entry in the left navigation that needs to be accessed as a sub-entry of "Shares".

Instead, pending shares are now directly shown both on the top of the "All files" as well as "Shares" lists. With inline action to accept (reject in an actions menu to prevent misclicks) and styled like the "recommended files".

Before After
before-all-files final-all-files-menu
before-pending-nav No extra step, it’s that simple

On accepting, if it’s a folder it is opened, and if it’s a filed it’s highlighted in the list and the sidebar opened.

Automatically opening folder Automatically focusing file
after-accept-folder after-accept-file

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@jancborchardt jancborchardt self-assigned this Nov 2, 2026
@jancborchardt jancborchardt added the design Design, UI, UX, etc. label Nov 2, 2026
@jancborchardt
jancborchardt requested a review from a team as a code owner November 2, 2026 15:32
@jancborchardt jancborchardt added 3. to review Waiting for reviews feature: sharing feature: files papercut Annoying recurring UX issue with possibly simple fix. AI assisted labels Nov 2, 2026
@jancborchardt
jancborchardt requested review from skjnldsv and susnux and removed request for a team November 2, 2026 15:32
@jancborchardt
jancborchardt requested a review from szaimen November 2, 2026 15:32
@jancborchardt
jancborchardt force-pushed the feat/pending-shares-inline branch 4 times, most recently from 0128cb3 to 02ddcbc Compare November 2, 2026 16:16
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
@jancborchardt

Copy link
Copy Markdown
Member Author

Here is the PR to make this work very nicely with recommendations: nextcloud/recommendations#1221

@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Nov 2, 2026
@szaimen
szaimen removed their request for review November 2, 2026 17:24
…hares header

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
@jancborchardt
jancborchardt requested a review from susnux November 3, 2026 10:49

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susnux thanks for your review comments! :) All addressed, please re-review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted design Design, UI, UX, etc. feature: files feature: sharing papercut Annoying recurring UX issue with possibly simple fix.

Projects

Status: 🏗️ At engineering

Development

Successfully merging this pull request may close these issues.

2 participants