Repository navigation
fix(appstore): do not wrap app store screenshots in the proxy twice - #64771
Conversation
edward-ly
left a comment
edward-ly
left a comment
There was a problem hiding this comment.
Nice work! Just one small change from me and we can get this in. Also remember to rebase the branch so that the base keeps up with master.
0e6d75a to
3c28332
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
edward-ly
left a comment
edward-ly
left a comment
There was a problem hiding this comment.
Sorry for the delay, but LGTM!
edward-ly
added
feature: apps management
php
The app store now serves screenshot URLs already pointing at usercontent.apps.nextcloud.com. Wrapping them again names a file the proxy never stores the image under, so no app shows its screenshot. Pass such URLs through unchanged, and encode the others with the URL-safe alphabet the proxy stores its files under. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Martin Rüegg <martin.rueegg@metaworx.ch>
3c28332 to
dc341b4
Compare
|
/backport to stable35 |
|
/backport to stable34 |
|
/backport to stable33 |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/64771/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick dc341b43
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/64771/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Since nextcloud/appstore@fd69d12680,
apps.jsonserves every screenshot URL already in proxy form,https://usercontent.apps.nextcloud.com/<base64url of the source>(all 1267 in/api/v1/platform/33.0.0/apps.jsonon 2026-09-25).ApiControllerwraps it in the proxy again, so the Apps page links to a key the proxy never stores the image under. Today every app's preview is empty or a "Preview not available" placeholder, including apps whose screenshots load on apps.nextcloud.com.createProxyPreviewUrl()now passes a URL already in proxy form through unchanged, and the app list uses it too instead of its own inline copy. URLs still wrapped here, from an app's owninfo.xml, are encoded with the URL-safe alphabet the proxy stores its files under since nextcloud/usercontent.apps.nextcloud.com#25; plainbase64_encodemisses whenever the encoding contains+or/.The double-wrapped keys that answer at all today do so only because of a proxy bug that caches placeholders under them, fixed in nextcloud/usercontent.apps.nextcloud.com#31.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
🤖 Generated with Claude Code