Skip to content

[stable33] fix(appstore): do not wrap app store screenshots in the proxy twice - #65992

Open
edward-ly wants to merge 1 commit into
stable33from
backport/64771/stable33
Open

edward-ly wants to merge 1 commit into
stable33from
backport/64771/stable33

Conversation

@edward-ly

Copy link
Copy Markdown
Contributor

Backport of PR #64771

The app store now serves screenshot URLs already pointing at
usercontent.apps.nextcloud.com. Wrapping them again names a file the
proxy never stores the image under, so no app shows its screenshot.

Pass such URLs through unchanged, and encode the others with the URL-safe
alphabet the proxy stores its files under.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Martin Rüegg <martin.rueegg@metaworx.ch>
(cherry picked from commit dc341b4)
@edward-ly
edward-ly requested a review from a team as a code owner October 28, 2026 21:17
@edward-ly
edward-ly requested review from come-nc, leftybournes, provokateurin and sorbaugh and removed request for a team October 28, 2026 21:17
@edward-ly edward-ly added this to the Nextcloud 33.0.11 milestone Oct 28, 2026
@edward-ly edward-ly added bug 3. to review Waiting for reviews feature: apps management php Pull requests that update Php code community pull requests from community labels Oct 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug community pull requests from community feature: apps management php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants