Skip to content

[stable31] fix(loopback): circles:check always fails due to APCu race and missing CLI wrapper #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristianscheid merged 2 commits into from
Oct 5, 2026
Merged

[stable31] fix(loopback): circles:check always fails due to APCu race and missing CLI wrapper #2990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b180cc8
fix(loopback): set test_dummy_token before first HTTP request
i2h3 Mar 6, 2026
4ed7eef
fix(loopback): allow wrapper creation for loopback tests from CLI
i2h3 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/Command/CirclesCheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,11 +254,12 @@ private function setupLoopback(InputInterface $input, OutputInterface $output, s
* @throws UnknownRemoteException
*/
private function testLoopback(InputInterface $input, OutputInterface $output): bool {
$this->appConfig->setValueInt(Application::APP_ID, 'test_dummy_token', time() + 10);

if (!$this->testRequest($output, 'GET', 'core.CSRFToken.index')) {
return false;
}

$this->appConfig->setValueInt(Application::APP_ID, 'test_dummy_token', time() + 10);
if (!$this->testRequest(
$output, 'POST', 'circles.EventWrapper.asyncBroadcast',
['token' => 'test-dummy-token']
Expand Down
4 changes: 3 additions & 1 deletion lib/Service/FederatedEventService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,9 @@ private function configureEvent(FederatedEvent $event, IFederatedItem $item) {
public function initBroadcast(FederatedEvent $event): bool {
$instances = $this->getInstances($event);
// if empty instance and ran from CLI, any action as already been managed
if (empty($instances) && (!$event->isAsync() || OC::$CLI)) {
// except for loopback tests which need async verification even from CLI
$isLoopbackTest = is_a($event->getClass(), IFederatedItemLoopbackTest::class, true);
if (empty($instances) && (!$event->isAsync() || (OC::$CLI && !$isLoopbackTest))) {
return false;
}

Expand Down
Loading