Repository navigation
[stable31] fix(loopback): circles:check always fails due to APCu race and missing CLI wrapper - #2990
Merged
Merged
Conversation
The `circles:check` loopback test always fails with a 401 on the POST request to `asyncBroadcast` with `test-dummy-token` when the config key `test_dummy_token` does not already exist in the database. Root cause: The GET request to `core.CSRFToken.index` (which runs first) causes the web server process to load all `appconfig` values into its APCu local cache (TTL=3s). Only then does the CLI process insert `test_dummy_token` into the database and clear its own APCu cache — but CLI and web server run in separate SAPI contexts with independent APCu stores, so the web cache is unaffected. When the POST request arrives shortly after the GET (well within the 3-second TTL), the web process reads from its still-valid APCu cache, which does not contain the newly inserted key. `getValueInt()` therefore returns the default `0`, and `0 < time()` evaluates to true, causing the controller to return 401. Moving `setValueInt()` before the GET request ensures the key exists in the database before any web request loads the appconfig into APCu. Signed-Off-By: Iva Horn <iva.horn@nextcloud.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Even after the 401 is resolved, `circles:check` still fails with
"Event created too many Wrappers" (actually zero wrappers found, the
message is misleading). The LoopbackTest FederatedEvent never gets an
EventWrapper created when running from CLI.
Root cause: `initBroadcast()` has an early-return guard:
if (empty($instances) && (!$event->isAsync() || OC::$CLI))
For a LoopbackTest event (which implements IFederatedItemAsyncProcess but
has no remote instances), `$instances` is empty. Combined with
`OC::$CLI === true`, the guard returns false — skipping all wrapper
creation. This optimisation is correct for regular async events in CLI
mode, where `newEvent()` already calls `manage()` synchronously and no
async broadcast is needed. However, the LoopbackTest specifically exists
to verify that the async loopback path works end-to-end: wrapper
creation, async POST, `manageWrapper()`, and `confirmStatus()` must all
run to produce the verify/manage values that `testLoopback()` asserts.
The fix exempts events whose class implements IFederatedItemLoopbackTest
from the CLI guard, so that a wrapper is created and the async broadcast
is triggered even when running from CLI. The double call to `manage()`
(once synchronously in `newEvent()`, once asynchronously via the
wrapper) is harmless for LoopbackTest since it only sets an idempotent
result value.
Signed-Off-By: Iva Horn <iva.horn@nextcloud.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CarlSchwan
approved these changes
Oct 2, 2026
cristianscheid
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #2387