feat: add favorite functionality for teams by Fin-c · Pull Request #2963 · nextcloud/circles

Fin-c · 2026-09-28T15:25:33Z

Add ability to favourite teams
#2904

Summary

Add personal team favorites with persistent ordering.

Allow users to favorite and unfavorite teams from the team overview.
Display favorites in a dedicated section and prioritize them in the team
switcher with a star indicator.
Support drag-and-drop ordering with a local preview, saving only accepted drops. Move up / Move down actions as accessible alternative
Add frontend and backend regression tests.

TODO

...

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

The content of this PR was partly or fully generated using AI

codecov · 2026-10-06T07:35:56Z

Codecov Report

❌ Patch coverage is 68.38710% with 49 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/teams/views/HomeView.vue	55.55%	29 Missing and 11 partials ⚠️
src/teams/components/TeamCard.vue	81.48%	4 Missing and 1 partial ⚠️
src/teams/store.ts	88.00%	2 Missing and 1 partial ⚠️
src/teams/components/TeamAvatar.vue	50.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copilot

Copilot review overview

🟡 Changes recommended

Team-page favoriting is incomplete, and filtered ordering plus accessibility issues can produce incorrect or inaccessible behavior.

Review effort: Balanced
Findings: 5 · 1

Open (6)

Expose favorite state to screen readers · New
Avoid duplicate team links and keyboard stops · New
Show favorite state for the current team avatars · New
Add favorite action for the current team · New
Disable favorite sorting while a search query is active · New
Include TeamCard.spec.ts in the focused test command · New

What changed in this PR

Adds persistent, ordered team favorites across the backend, home view, and team switcher.

Changes:

Adds favorite APIs, storage, locking, cleanup, and ordering.
Adds favorite controls, drag-and-drop ordering, and switcher indicators.
Adds frontend/backend tests and testing documentation.

File	Description
`tests/unit/lib/Service/TeamFavoriteServiceTest.php`	Tests service ordering and locking.
`tests/unit/lib/Db/TeamFavoriteRequestTest.php`	Tests favorite persistence and access filtering.
`TESTING.md`	Documents favorite regression tests.
`src/teams/views/HomeView.vue`	Adds favorite sections and ordering controls.
`src/teams/views/HomeView.spec.ts`	Tests drag-and-drop behavior.
`src/teams/types.ts`	Adds favorite metadata to teams.
`src/teams/store.ts`	Manages favorite state and mutations.
`src/teams/store.spec.ts`	Tests favorite store behavior.
`src/teams/components/TeamHeader.vue`	Prioritizes favorites in the switcher.
`src/teams/components/TeamCard.vue`	Adds favorite and ordering actions.
`src/teams/components/TeamCard.spec.ts`	Tests card actions and dragging.
`src/teams/components/TeamAvatar.vue`	Adds the favorite star indicator.
`src/teams/api.ts`	Adds favorite API integration.
`src/teams/api.spec.ts`	Tests favorite API requests.
`REUSE.toml`	Adds licensing annotations for tests.
`lib/Service/TeamFavoriteService.php`	Implements favorite business logic.
`lib/Migration/Version20260922120000.php`	Creates the favorites table.
`lib/Listeners/UserDeleted.php`	Cleans favorites after user deletion.
`lib/Db/TeamFavoriteRequest.php`	Implements favorite database operations.
`lib/Db/CoreRequestBuilder.php`	Registers favorite table metadata.
`lib/Db/CircleRequest.php`	Cleans favorites after team deletion.
`lib/Controller/TeamFavoritesController.php`	Exposes favorite endpoints.
`appinfo/routes.php`	Registers favorite routes.
`appinfo/info.xml`	Bumps the app version.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Assisted-by: GitHub Copilot GPT-5.6 Terra Assisted-by: GitHub Copilot GPT-6 Astra Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>

Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>

Assisted-by: GitHub Copilot Claude Opus 5.5 Assisted-by: GitHub Copilot GPT-5.6 Luna Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>

…osition Assisted-by: GitHub Copilot Claude Opus 5.5 Assisted-by: GitHub Copilot GPT-5.6 Luna Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>

pringelmann · 2026-10-09T10:56:37Z

@@ -0,0 +1,63 @@
+<?php


nit: naming convention for migrations is Version{appVersion}Date{timestamp}. Not a big deal for this migration since it creates a new table, but might be a problem if a future migration alters the table. Not blocking though :)

github-actions · 2026-10-13T09:05:48Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

artonge · 2026-10-15T16:31:50Z

+	public int $position = 0;
+
+	#[Column(name: 'created', type: ColumnType::Datetime)]
+	public DateTime $created;


Do we really need this column?

Alternatively we can replace the incremental id with a snowflake id which will contain the creation date.

No, you’re right. The creation timestamp is not used anywhere, so I’ll remove this column in a follow-up PR.

A snowflake ID would make sense if we needed the creation timestamp. Since the feature does not use that information, I think keeping the generated integer ID and removing created is the simpler option.

Fin-c force-pushed the feature/add_ability_to_favorite_teams branch 2 times, most recently from 409f74d to d578b7e Compare October 5, 2026 09:00

Fin-c force-pushed the feature/add_ability_to_favorite_teams branch from 09ed404 to 956839c Compare October 6, 2026 07:29

Fin-c marked this pull request as ready for review October 6, 2026 07:37

Fin-c requested review from ArtificialOwl and provokateurin as code owners October 6, 2026 07:37

Fin-c requested review from artonge and marcoambrosini and removed request for ArtificialOwl and provokateurin October 6, 2026 07:38

Fin-c linked an issue Oct 6, 2026 that may be closed by this pull request

Add ability to favourite teams #2904

Closed

tomek2k1 added this to 👥 Teams Oct 6, 2026

github-project-automation Bot moved this to Backlog in 👥 Teams Oct 6, 2026

Fin-c added the 3. to review label Oct 6, 2026

Fin-c self-assigned this Oct 6, 2026

marcoambrosini requested review from pringelmann and a balanced review from Copilot October 6, 2026 12:21

Copilot started reviewing on behalf of marcoambrosini October 6, 2026 12:23

View session

Copilot AI reviewed Oct 6, 2026

View reviewed changes

Comment thread src/teams/components/TeamAvatar.vue

Comment thread src/teams/components/TeamCard.vue

Comment thread src/teams/components/TeamHeader.vue

Comment thread src/teams/components/TeamHeader.vue

Comment thread src/teams/views/HomeView.vue Outdated

Comment thread TESTING.md Outdated

artonge reviewed Oct 7, 2026

View reviewed changes

Comment thread REUSE.toml Outdated

Comment thread TESTING.md Outdated

Comment thread lib/Db/TeamFavoriteRequest.php Outdated

Fin-c added 2 commits October 8, 2026 08:12

feat: add favorite functionality for teams

14862bd

Assisted-by: GitHub Copilot GPT-5.6 Terra Assisted-by: GitHub Copilot GPT-6 Astra Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>

test: cover TeamCard favorite actions and dragging

ee7d5ff

Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>

Fin-c force-pushed the feature/add_ability_to_favorite_teams branch 2 times, most recently from 8d8e6a4 to 7c4424a Compare October 8, 2026 06:16

pringelmann reviewed Oct 8, 2026

View reviewed changes

Comment thread src/teams/views/HomeView.vue Outdated

pringelmann reviewed Oct 8, 2026

View reviewed changes

Comment thread src/teams/api.ts Outdated

pringelmann reviewed Oct 8, 2026

View reviewed changes

Comment thread src/teams/components/TeamCard.vue Outdated

Fin-c force-pushed the feature/add_ability_to_favorite_teams branch from 931c22d to 422f167 Compare October 9, 2026 10:07

fix: address review feedback for team favorites

e311ed4

Assisted-by: GitHub Copilot Claude Opus 5.5 Assisted-by: GitHub Copilot GPT-5.6 Luna Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>

fix: smoother favorite drag & drop, soft-fail favorites, RTL action p…

8ff4842

…osition Assisted-by: GitHub Copilot Claude Opus 5.5 Assisted-by: GitHub Copilot GPT-5.6 Luna Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>

Fin-c force-pushed the feature/add_ability_to_favorite_teams branch from 422f167 to 8ff4842 Compare October 9, 2026 10:10

Fin-c requested review from artonge and pringelmann October 9, 2026 10:15

pringelmann reviewed Oct 9, 2026

View reviewed changes

pringelmann approved these changes Oct 9, 2026

View reviewed changes

Fin-c merged commit 0a2317d into master Oct 12, 2026
51 checks passed

Fin-c deleted the feature/add_ability_to_favorite_teams branch October 12, 2026 06:28

github-project-automation Bot moved this from In review to Done in 👥 Teams Oct 12, 2026

github-actions Bot added the feedback-requested label Oct 13, 2026

artonge requested changes Oct 15, 2026

View reviewed changes

Fin-c mentioned this pull request Oct 16, 2026

fix: remove unused team favorite creation date #3059

Open

4 of 7 tasks

Conversation

Fin-c commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

AI (if applicable)

Uh oh!

codecov Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pringelmann Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

artonge Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

artonge Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

Fin-c Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fin-c commented Sep 28, 2026 •

edited

Loading

codecov Bot commented Oct 6, 2026 •

edited

Loading