Repository navigation
fix(native): avoid a missing WebKit runtime library on older OS versions - #526
Merged
Merged
Conversation
Contributor
Desktop build
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The clients crash before launching on supported older OS runtimes because the Swift
callAsyncJavaScriptwrapper adds a required dependency on/usr/lib/swift/libswiftWebKit.dylib. Call the same public Objective-C WebKit method directly, preserving structured arguments, the page content world and asynchronous delivery.__callAsyncJavaScriptis the public method refined for Swift, not a private API; WebKit's wrapper calls this entry point itself. This change applies to iOS and macOS.Evidence
Library not loaded: /usr/lib/swift/libswiftWebKit.dylib. The production IPA 1.0.0 (15.1) contains the same required library and one undefined wrapper symbol.After: simulator and Mac store builds now check the produced binaries for this runtime dependency. Native acceptance is running against the corrected code in test(native): capture store screenshots and verify Apple clients #523.
Merge Danger
Door: two-way
Blast Radius: native
Rebuild both store artifacts after merging; the already-generated binaries still contain the incompatible library dependency. Full TestFlight acceptance remains separate from compilation checks.