Skip to content

test(native): capture store screenshots and verify Apple clients - #523

Draft
markbang wants to merge 27 commits into
mainfrom
codex/apple-store-validation
Draft

markbang wants to merge 27 commits into
mainfrom
codex/apple-store-validation

Conversation

@markbang

@markbang markbang commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add a manual Apple client acceptance workflow with separate XCTest projects. It captures real native screens and exercises the dedicated review account without adding hooks to shipping targets.

Apple Acceptance
  iOS: native email-code login OR authenticated screenshot fixture
  Mac: verify signed PKG → sandboxed screenshot copy + review-session fixture
  relaunch → English/Chinese chats and document previews → named PNGs

Evidence

  • Before: signing could succeed without native launch or screenshot verification.
    After: iPhone fixture acceptance and latest signed Mac package acceptance pass session restoration and capture actual chat/document views. iPad full-screen acceptance also passes, including landscape content readiness. All 18 English/Chinese screenshots for Mac, iPhone and iPad have been uploaded to App Store Connect and processed successfully.
  • Validation found two shipping defects, fixed separately in fix(ios): enable native messaging on app-bound domains #525 and fix(native): avoid a missing WebKit runtime library on older OS versions #526. Formal build 1.0.0 (24.1) exports both platforms; executable inspection confirms neither loads libswiftWebKit.dylib. Upload follow-up fixes fix(apple): satisfy SDK and package upload validation #528 and fix(apple): upload individual-key builds through App Store Connect API #529 select Xcode 26, make the embedded Mac profile readable, and support the individual API key. Apple has processed both builds as VALID and they are selected for their 1.0.0 store versions; review has not been submitted.
  • Native first-login acceptance was waived by the user on 2026-11-18. The diagnostic run proves the web click reaches auth.signIn, a presentation window exists, and ASWebAuthenticationSession.start() succeeds, followed by system canceledLogin (code 1) before email entry. The clean-source consent-handler retry reports a simulator SafariViewService webcredentials-association failure for cohub.live. Distribution entitlements and the Apple CDN AASA match; No further TestFlight/provisioned-device login validation is required for this release per the user’s instruction. Temporary source instrumentation has been removed. Screenshot fixture success does not establish that the system-browser callback works.
  • Production browser email-code login and the native-client authorization-code/PKCE exchange passed separately. The Apple CDN contains the required webcredentials association.
  • actionlint, YAML parsing, embedded shell syntax and git diff --check pass. Full local repository checks were unavailable because a private npm dependency returned 401; the native projects were compiled and exercised on hosted macOS runners.

Merge Danger

Door: two-way

Only a manual workflow and test projects change. There is no release, binary upload or review-submission step.

Blast Radius: tests

Mac App Store distribution apps cannot launch directly on a fresh hosted runner. Mac screenshots use the verified executable with ad hoc sandbox signing and a real review-session fixture; iOS screenshots use simulator builds. Neither substitutes for distribution installation or TestFlight callback acceptance. Credentials stay in encrypted Actions secrets. Only named PNG attachments are uploaded; raw xcresult bundles are excluded.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Desktop build

0.325.1 · dev · 903f1cb

Platform Download
macOS, Apple silicon Workflow artifacts, unsigned
macOS, Intel Workflow artifacts, unsigned
Windows x64 Workflow artifacts, unsigned
Linux x64 Cohub-0.325.1-dev-x64.AppImage · SHA-256

@markbang markbang changed the title test(native): add Apple client acceptance and screenshot capture fix(ios): restore the native bridge and add Apple acceptance captures Nov 18, 2026
@markbang markbang changed the title fix(ios): restore the native bridge and add Apple acceptance captures test(native): capture store screenshots and verify Apple clients Nov 18, 2026
@markbang
markbang force-pushed the codex/apple-store-validation branch from db4ab69 to 7f4842e Compare November 18, 2026 08:30
@markbang
markbang force-pushed the codex/apple-store-validation branch from 76b021f to 92fe603 Compare November 18, 2026 09:23
@markbang
markbang force-pushed the codex/apple-store-validation branch from afe6b63 to 903f1cb Compare November 21, 2026 01:06

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant