Skip to content

feat: simplify the built-in team shelf and keep first-project compatible - #864

Merged
mvschwarz merged 4 commits into
mainfrom
feat/builtin-team-names
Oct 6, 2026
Merged

mvschwarz merged 4 commits into
mainfrom
feat/builtin-team-names

Conversation

@mvschwarz

@mvschwarz mvschwarz commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

The built-in team shelf now offers starter, factory, code-review, research and pm, alongside the unchanged kernel. Starter has a Claude builder and Codex reviewer; factory has lead, advisor, build, QA, design and two review seats. Factory reuses the PM agent through an advisor profile and retains role skills and openrig-core. Implementer and QA defaults and recommended skill routing no longer select TDD; its library resource remains available to existing user specs.

rig up first-project resolves to the built-in starter and explains its providers and Codex-only adaptation on stderr. Exact library IDs/names and --existing retain precedence; existing and archived rigs under either name keep their recovery checks. Seven old spec folders retain their original culture bytes so stored startup paths still restore after upgrade, without restoring their catalog entries. Factory-RSI and secrets-manager retain their YAML as world-bundle.yaml pending migration to world bundles.

Validation covers catalog membership, seat/runtime/resource projection, alias routing, legacy culture restore (including a restore regression for a stored first-project culture file), skill mirrors and the skill index, topology, packing and TUI readers.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d06a440e-2679-4f3a-b032-8d8820caef81
📥 Commits

Reviewing files that changed from the base of the PR and between 5b05076 and de57592.

⛔ Files ignored due to path filters (1)
  • scripts/skill-edge-digests.generated.json is excluded by !**/*.generated.*
📒 Files selected for processing (51)
  • packages/cli/src/commands/specs.ts
  • packages/cli/src/commands/up.ts
  • packages/cli/test/specs-alias.test.ts
  • packages/cli/test/up.test.ts
  • packages/daemon/assets/plugins/openrig-core/skills/openrig-skills/SKILL.md
  • packages/daemon/specs/agents/development/implementer/agent.yaml
  • packages/daemon/specs/agents/development/qa/agent.yaml
  • packages/daemon/specs/agents/product-management/pm/agent.yaml
  • packages/daemon/specs/agents/shared/skills/core/openrig-skills/SKILL.md
  • packages/daemon/specs/agents/shared/skills/process/systematic-debugging/SKILL.md
  • packages/daemon/specs/rigs/focused/code-review/rig.yaml
  • packages/daemon/specs/rigs/focused/pm/CULTURE.md
  • packages/daemon/specs/rigs/focused/pm/rig.yaml
  • packages/daemon/specs/rigs/focused/research/rig.yaml
  • packages/daemon/specs/rigs/launch/conveyor/README.md
  • packages/daemon/specs/rigs/launch/conveyor/rig.yaml
  • packages/daemon/specs/rigs/launch/demo/project-example/README.md
  • packages/daemon/specs/rigs/launch/demo/project-example/missions/improve-onboarding/SPEC.md
  • packages/daemon/specs/rigs/launch/demo/project-example/missions/improve-onboarding/slices/01-shorten-first-run/PROGRESS.md
  • packages/daemon/specs/rigs/launch/demo/project-example/missions/improve-onboarding/slices/01-shorten-first-run/PROOF.md
  • packages/daemon/specs/rigs/launch/demo/project-example/missions/improve-onboarding/slices/01-shorten-first-run/SPEC.md
  • packages/daemon/specs/rigs/launch/factory-rsi/world-bundle.yaml
  • packages/daemon/specs/rigs/launch/factory/CULTURE.md
  • packages/daemon/specs/rigs/launch/factory/rig.yaml
  • packages/daemon/specs/rigs/launch/factory/topology/instance/CRAFT.md
  • packages/daemon/specs/rigs/launch/factory/topology/rig/CRAFT.md
  • packages/daemon/specs/rigs/launch/factory/topology/rig/ORCHESTRATION-CRAFT.md
  • packages/daemon/specs/rigs/launch/factory/topology/seats/dev-qa/CRAFT.md
  • packages/daemon/specs/rigs/launch/factory/topology/seats/orch-lead/CRAFT.md
  • packages/daemon/specs/rigs/launch/factory/topology/seats/review-r1/CRAFT.md
  • packages/daemon/specs/rigs/launch/factory/topology/seats/review-r2/CRAFT.md
  • packages/daemon/specs/rigs/launch/first-project-claude/rig.yaml
  • packages/daemon/specs/rigs/launch/first-project-mixed/rig.yaml
  • packages/daemon/specs/rigs/launch/implementation-pair/rig.yaml
  • packages/daemon/specs/rigs/launch/secrets-manager/world-bundle.yaml
  • packages/daemon/specs/rigs/launch/starter/CULTURE.md
  • packages/daemon/specs/rigs/launch/starter/rig.yaml
  • packages/daemon/specs/rigs/preview/product-team/rig.yaml
  • packages/daemon/test/builtin-team-providers.test.ts
  • packages/daemon/test/factory-rsi-rig.test.ts
  • packages/daemon/test/openrig-skills-router-coverage.test.ts
  • packages/daemon/test/restore-orchestrator.test.ts
  • packages/daemon/test/sdlc-role-startup.test.ts
  • packages/daemon/test/slice16-starter-hygiene.test.ts
  • packages/daemon/test/spec-library-starters.test.ts
  • packages/daemon/test/topology-defaults-door.e2e.test.ts
  • packages/tui/test/hydrate.test.ts
  • scripts/check-cli-daemon-freshness.test.mjs
  • scripts/check-packing.test.mjs
  • skills/_canonical/core/openrig-skills/SKILL.md
  • skills/_canonical/process/systematic-debugging/SKILL.md
 _______________________________________________________
< Veni, Vidi, VCS: I came, I saw, I version-controlled. >
 -------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mvschwarz
mvschwarz force-pushed the feat/builtin-team-names branch from aa101ed to 5e1d4a7 Compare October 6, 2026 07:16
@mvschwarz
mvschwarz marked this pull request as ready for review October 6, 2026 08:04

@openrig-review openrig-review left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at de57592 after two independent review rounds. The built-in team shelf now offers starter (a Claude builder delegating to a Codex reviewer), factory (lead, advisor, build, QA, design and two reviewers), and the specialist teams code-review, research and pm, with the kernel and its variants unchanged. The per-provider first-project variants, implementation-pair, product-team, demo and conveyor leave the shelf. first-project resolves to starter only after every exact library ID and name fails, prints that starter is a Claude builder and a Codex reviewer and that the OpenRig operator can adapt it on a Codex-only machine, and keeps the existing-rig and archived-rig checks for both names. The seven removed or renamed folders keep their original CULTURE.md bytes so rigs launched from them still restore after upgrade, with a restore test that fails without them; no rig.yaml stays beside them, so they don't return to the shelf. The implementer and QA defaults and the recommended skill routing no longer select test-driven development; the optional skill stays available to existing user specs. factory-rsi and secrets-manager keep their files as world-bundle.yaml for the move to openrig-world.

— dev60-planner@v-openrig-build

@mvschwarz
mvschwarz merged commit d1e9d5e into main Oct 6, 2026
9 of 10 checks passed
@mvschwarz
mvschwarz deleted the feat/builtin-team-names branch October 6, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants