Skip to content

fix(finance): extend product master list sort keys and multi-type filter #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilramdhan merged 1 commit into from
Jul 2, 2026
Merged

fix(finance): extend product master list sort keys and multi-type filter #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions finance/v1/cost_product_master.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ message DeactivateCostProductMasterResponse {
// =============================================================================

message ListCostProductMastersRequest {
string search = 1 [(buf.validate.field).string.max_len = 200]; // matches product_code OR product_name OR erp_item_code
string search = 1 [(buf.validate.field).string.max_len = 200]; // matches product_code OR product_name OR erp_item_code OR oracle sys id (flex_02)
int32 product_type_id = 2;
string shade_code = 3 [(buf.validate.field).string.max_len = 50];
string active_filter = 4 [(buf.validate.field).string = {
Expand All @@ -163,7 +163,15 @@ message ListCostProductMastersRequest {
"",
"product_code",
"product_name",
"created_at"
"created_at",
"updated_at",
"product_type_code",
"shade_code",
"grade_code",
"oracle_sys_id",
"erp_compound_key",
"type_label",
"status"
]
}];
string sort_order = 7 [(buf.validate.field).string = {
Expand All @@ -173,6 +181,7 @@ message ListCostProductMastersRequest {
"desc"
]
}];
repeated int32 product_type_ids = 8; // additional type filter, unioned with product_type_id
}

message ListCostProductMastersResponse {
Expand Down
Loading